Browse Source

fix(issue-details): Add error boundary outside ResourcesAndMaybeSolutions (#70107)

*Before*
<img width="1690" alt="Screenshot 2024-05-01 at 3 29 11 PM"
src="https://github.com/getsentry/sentry/assets/30991498/2ad6e510-1564-4cd1-8095-4aa94b58c47b">

*After*
<img width="1348" alt="Screenshot 2024-05-01 at 3 31 39 PM"
src="https://github.com/getsentry/sentry/assets/30991498/15b04072-11c3-42c6-b189-b41c945145a2">

Fixes [JAVASCRIPT-2SXB](https://sentry.sentry.io/issues/5289857994/)
Resolves https://getsentry.atlassian.net/browse/INC-743
Jenn Mueng 10 months ago
parent
commit
6d8b6ff488

+ 22 - 2
static/app/views/issueDetails/groupEventDetails/groupEventDetailsContent.tsx

@@ -175,7 +175,11 @@ function DefaultGroupEventDetailsContent({
         <EventTagsAndScreenshot event={event} projectSlug={project.slug} />
       )}
       {showMaybeSolutionsHigher && (
-        <ResourcesAndMaybeSolutions event={event} project={project} group={group} />
+        <ResourcesAndMaybeSolutionsIssueDetailsContent
+          event={event}
+          project={project}
+          group={group}
+        />
       )}
       <EventEvidence event={event} group={group} project={project} />
       <GroupEventEntry entryType={EntryType.MESSAGE} {...eventEntryProps} />
@@ -200,7 +204,11 @@ function DefaultGroupEventDetailsContent({
       <GroupEventEntry entryType={EntryType.TEMPLATE} {...eventEntryProps} />
       <GroupEventEntry entryType={EntryType.BREADCRUMBS} {...eventEntryProps} />
       {!showMaybeSolutionsHigher && (
-        <ResourcesAndMaybeSolutions event={event} project={project} group={group} />
+        <ResourcesAndMaybeSolutionsIssueDetailsContent
+          event={event}
+          project={project}
+          group={group}
+        />
       )}
       <GroupEventEntry entryType={EntryType.DEBUGMETA} {...eventEntryProps} />
       <GroupEventEntry entryType={EntryType.REQUEST} {...eventEntryProps} />
@@ -239,6 +247,18 @@ function DefaultGroupEventDetailsContent({
   );
 }
 
+function ResourcesAndMaybeSolutionsIssueDetailsContent({
+  event,
+  project,
+  group,
+}: Required<GroupEventDetailsContentProps>) {
+  return (
+    <ErrorBoundary mini>
+      <ResourcesAndMaybeSolutions event={event} project={project} group={group} />
+    </ErrorBoundary>
+  );
+}
+
 function PerformanceDurationRegressionIssueDetailsContent({
   group,
   event,