ref: delete some misc dead code (#84460)

found with https://github.com/asottile/dead

<!-- Describe your PR here. -->

fixtures/emails/digest.txt

@@ -1,55 +1,37 @@
 Notifications for example
-June 22, 2016, 4:16 p.m. UTC to July 4, 2016, 2:18 p.m. UTC
+June 22, 2016, 4:16 p.m. UTC to June 22, 2016, 4:16 p.m. UTC
 
 Rule #3
 
-* DecidingKoiError: faithful hookworm top sharp filly merely sought trivially (8193 events, 9186 users)
-  http://testserver/organizations/example/issues/2/?referrer=digest_email
-
-* something bad happened (5113 events, 5954 users)
-  http://testserver/organizations/example/issues/201/?referrer=digest_email
-
-* N+1 Query (4418 events, 3851 users)
-  http://testserver/organizations/example/issues/100/?referrer=digest_email
-
-* SnailError: molly engaged wahoo feline hedgehog salmon novel boxer polecat (920 events, 5856 users)
-  http://testserver/organizations/example/issues/3/?referrer=digest_email
+* N+1 Query (8481 events, 3702 users)
+  http://testserver/organizations/example/issues/101/?referrer=digest_email
 
-* something bad happened (349 events, 6979 users)
+* something bad happened (7367 events, 8961 users)
   http://testserver/organizations/example/issues/200/?referrer=digest_email
 
-Rule #2
-
-* DecidingKoiError: faithful hookworm top sharp filly merely sought trivially (8193 events, 9186 users)
-  http://testserver/organizations/example/issues/2/?referrer=digest_email
+* something bad happened (6616 events, 8490 users)
+  http://testserver/organizations/example/issues/201/?referrer=digest_email
 
-* N+1 Query (4418 events, 3851 users)
+* N+1 Query (538 events, 6347 users)
   http://testserver/organizations/example/issues/100/?referrer=digest_email
 
-* N+1 Query (2057 events, 2439 users)
-  http://testserver/organizations/example/issues/101/?referrer=digest_email
+Rule #1
 
-* SnailError: molly engaged wahoo feline hedgehog salmon novel boxer polecat (920 events, 5856 users)
-  http://testserver/organizations/example/issues/3/?referrer=digest_email
+* N+1 Query (8481 events, 3702 users)
+  http://testserver/organizations/example/issues/101/?referrer=digest_email
 
-* something bad happened (349 events, 6979 users)
+* something bad happened (7367 events, 8961 users)
   http://testserver/organizations/example/issues/200/?referrer=digest_email
 
-Rule #1
-
-* DecidingKoiError: faithful hookworm top sharp filly merely sought trivially (8193 events, 9186 users)
-  http://testserver/organizations/example/issues/2/?referrer=digest_email
-
-* something bad happened (5113 events, 5954 users)
+* something bad happened (6616 events, 8490 users)
   http://testserver/organizations/example/issues/201/?referrer=digest_email
 
-* N+1 Query (4418 events, 3851 users)
-  http://testserver/organizations/example/issues/100/?referrer=digest_email
+Rule #2
 
-* SnailError: molly engaged wahoo feline hedgehog salmon novel boxer polecat (920 events, 5856 users)
-  http://testserver/organizations/example/issues/3/?referrer=digest_email
+* N+1 Query (8481 events, 3702 users)
+  http://testserver/organizations/example/issues/101/?referrer=digest_email
 
-* something bad happened (349 events, 6979 users)
+* something bad happened (7367 events, 8961 users)
   http://testserver/organizations/example/issues/200/?referrer=digest_email
 
 

src/bitfield/admin.py

@@ -1,41 +0,0 @@
-from django.contrib.admin import FieldListFilter
-from django.contrib.admin.options import IncorrectLookupParameters
-from django.core.exceptions import ValidationError
-from django.db.models import F
-from django.utils.translation import gettext_lazy as _
-
-from bitfield import Bit
-from bitfield.compat import bitor
-
-
-class BitFieldListFilter(FieldListFilter):
-    def __init__(self, field, request, params, model, model_admin, field_path):
-        self.lookup_kwarg = field_path
-        self.lookup_val = int(request.GET.get(self.lookup_kwarg, 0))
-        self.flags = field.flags
-        self.labels = field.labels
-        super().__init__(field, request, params, model, model_admin, field_path)
-
-    def queryset(self, request, queryset):
-        _filter = {p: bitor(F(p), v) for p, v in self.used_parameters.items()}
-        try:
-            return queryset.filter(**_filter)
-        except ValidationError as e:
-            raise IncorrectLookupParameters(e)
-
-    def expected_parameters(self):
-        return [self.lookup_kwarg]
-
-    def choices(self, cl):
-        yield {
-            "selected": self.lookup_val == 0,
-            "query_string": cl.get_query_string({}, [self.lookup_kwarg]),
-            "display": _("All"),
-        }
-        for number, flag in enumerate(self.flags):
-            bit_mask = Bit(number).mask
-            yield {
-                "selected": self.lookup_val == bit_mask,
-                "query_string": cl.get_query_string({self.lookup_kwarg: bit_mask}),
-                "display": self.labels[number],
-            }

src/sentry/api/event_search.py

@@ -541,10 +541,6 @@ class SearchConfig:
     # Keys which are considered valid for duration filters
     duration_keys: set[str] = field(default_factory=set)
 
-    # Keys considered valid for the percentage aggregate and may have
-    # percentage search values
-    percentage_keys: set[str] = field(default_factory=set)
-
     # Keys considered valid for numeric filter types
     numeric_keys: set[str] = field(default_factory=set)
 
@@ -654,9 +650,6 @@ class SearchVisitor(NodeVisitor):
     def is_boolean_key(self, key):
         return key in self.config.boolean_keys
 
-    def is_percentage_key(self, key):
-        return key in self.config.percentage_keys
-
     def visit_search(self, node, children):
         return flatten(remove_space(children[1]))
 
@@ -1234,7 +1227,6 @@ class SearchVisitor(NodeVisitor):
 
 default_config = SearchConfig(
     duration_keys={"transaction.duration"},
-    percentage_keys={"percentage"},
     text_operator_keys={SEMVER_ALIAS, SEMVER_BUILD_ALIAS},
     # do not put aggregate functions in this list
     numeric_keys={

src/sentry/api/helpers/actionable_items_helper.py

@@ -9,23 +9,6 @@ class ActionPriority:
     UNKNOWN = 4
 
 
-sourcemap_sdks = [
-    "sentry.javascript.astro",
-    "sentry.javascript.browser",
-    "sentry.javascript.node",
-    "sentry.javascript.react",
-    "sentry.javascript.angular",
-    "sentry.javascript.angular-ivy",
-    "sentry.javascript.ember",
-    "sentry.javascript.gatsby",
-    "sentry.javascript.vue",
-    "sentry.javascript.nextjs",
-    "sentry.javascript.remix",
-    "sentry.javascript.svelte",
-    "sentry.javascript.sveltekit",
-    "sentry.javascript.react-native",
-]
-
 fileNameBlocklist = ["@webkit-masked-url"]
 
 priority_ranking = {
@@ -89,26 +72,6 @@ deprecated_event_errors = [
 ]
 
 
-# These checks mirror what we do in the front end in getUniqueFilesFromException
-def find_debug_frames(event):
-    debug_frames = []
-    exceptions = event.interfaces["exception"].values
-    seen_filenames = []
-
-    for exception_idx, exception in enumerate(exceptions):
-        for frame_idx, frame in enumerate(exception.stacktrace.frames):
-            if (
-                frame.in_app
-                and is_frame_filename_valid(frame)
-                and frame.lineno
-                and frame.filename not in seen_filenames
-            ):
-                debug_frames.append((frame_idx, exception_idx))
-                seen_filenames.append(frame.filename)
-
-    return debug_frames
-
-
 def get_file_extension(filename):
     segments = filename.split(".")
     if len(segments) > 1:

src/sentry/feedback/usecases/spam_detection.py

@@ -35,7 +35,6 @@ def make_input_prompt(message: str):
 @metrics.wraps("feedback.spam_detection", sample_rate=1.0)
 def is_spam(message: str):
     labeled_spam = False
-    _trimmed_response = ""
     response = complete_prompt(
         usecase=LLMUseCase.SPAM_DETECTION,
         message=make_input_prompt(message),
@@ -43,7 +42,7 @@ def is_spam(message: str):
         max_output_tokens=20,
     )
     if response:
-        labeled_spam, _trimmed_response = trim_response(response)
+        labeled_spam, _ = trim_response(response)
 
     return labeled_spam
 

src/sentry/tasks/summaries/utils.py

@@ -13,7 +13,6 @@ from snuba_sdk.orderby import Direction, OrderBy
 from snuba_sdk.query import Join, Limit, Query
 from snuba_sdk.relationships import Relationship
 
-from sentry.api.serializers.snuba import zerofill
 from sentry.constants import DataCategory
 from sentry.models.group import Group, GroupStatus
 from sentry.models.grouphistory import GroupHistory
@@ -396,9 +395,6 @@ def project_event_counts_for_organization(start, end, ctx, referrer: str) -> lis
     Populates context.projects which is { project_id: ProjectContext }
     """
 
-    def zerofill_data(data):
-        return zerofill(data, start, end, ONE_DAY, fill_default=0)
-
     query = Query(
         match=Entity("outcomes"),
         select=[

src/sentry/tasks/summaries/weekly_reports.py

@@ -677,9 +677,6 @@ def render_template_context(ctx, user_id: int | None) -> dict[str, Any] | None:
 
         return heapq.nlargest(3, all_key_performance_issues(), lambda d: d["count"])
 
-    def key_replays():
-        return []
-
     def issue_summary():
         new_substatus_count = 0
         escalating_substatus_count = 0

src/sentry/templates/sentry/emails/reports/body.html

@@ -541,26 +541,5 @@
   </div>
   {% endif %}
 
-  {% if key_replays|length > 0 %}
-  <div id="key-replays">
-    <h4>Most erroneous replays</h4>
-    {% for a in key_replays %}
-    <div style="display: flex; flex-direction: row; margin-bottom: 8px; align-items: flex-start;">
-      <div style="width: 10%; font-size: 17px;">{{a.count|small_count:1}}</div>
-      <div style="width: 65%;">
-        {% url 'sentry-organization-replay-details' organization.slug a.replay.id as replay_details %}
-        {% querystring referrer="weekly_report" notification_uuid=notification_uuid as query %}
-        <a style="display: block; text-overflow: ellipsis; white-space: nowrap; overflow: hidden; font-size: 17px;"
-          href="{% org_url organization replay_details query=query %}">{{a.id}}</a>
-        <div style="font-size: 12px; color: #80708F;">{{a.project.name}}</div>
-      </div>
-      <div style="font-size: 14px; margin-left: auto; display: flex;">
-        <span>{{600000 | duration}}</span>
-      </div>
-    </div>
-    {% endfor %}
-  </div>
-  {% endif %}
-
 </div>
 {% endblock %}

src/sentry/web/frontend/debug/mail.py

@@ -509,10 +509,7 @@ def digest(request):
         group = next(group_generator)
         groups[group.id] = group
 
-        offset = timedelta(seconds=0)
         for _ in range(random.randint(1, 10)):
-            offset += timedelta(seconds=random.random() * 120)
-
             data_dct = dict(load_data("python"))
             data_dct["message"] = group.message
             data_dct.pop("logentry", None)