Browse Source

ref(replays): remove annotation from clicks and route to breadcrumbs (#58211)

Michelle Zhang 1 year ago
parent
commit
694790fba9

+ 2 - 2
static/app/utils/replays/hooks/useActiveReplayTab.spec.tsx

@@ -44,12 +44,12 @@ describe('useActiveReplayTab', () => {
     expect(result.current.getActiveTab()).toBe(TabKey.BREADCRUMBS);
   });
 
-  it('should use DOM as a default, when there is a click search in the url', () => {
+  it('should use Breadcrumbs as a default, when there is a click search in the url', () => {
     mockLocation('click.tag:button');
 
     const {result} = reactHooks.renderHook(useActiveReplayTab);
 
-    expect(result.current.getActiveTab()).toBe(TabKey.DOM);
+    expect(result.current.getActiveTab()).toBe(TabKey.BREADCRUMBS);
   });
 
   it('should allow case-insensitive tab names', () => {

+ 2 - 22
static/app/utils/replays/hooks/useActiveReplayTab.tsx

@@ -1,9 +1,6 @@
-import {useCallback, useMemo} from 'react';
+import {useCallback} from 'react';
 
-import {parseSearch} from 'sentry/components/searchSyntax/parser';
 import type {Organization} from 'sentry/types';
-import {decodeScalar} from 'sentry/utils/queryString';
-import {useLocation} from 'sentry/utils/useLocation';
 import useOrganization from 'sentry/utils/useOrganization';
 import useUrlParams from 'sentry/utils/useUrlParams';
 
@@ -34,25 +31,8 @@ function isReplayTab(tab: string, organization: Organization): tab is TabKey {
   return Object.values<string>(TabKey).includes(tab);
 }
 
-function useDefaultTab() {
-  const location = useLocation();
-
-  const hasClickSearch = useMemo(() => {
-    const parsed = parseSearch(decodeScalar(location.query.query) || '');
-    return parsed?.some(
-      token => token.type === 'filter' && token.key.text.startsWith('click.')
-    );
-  }, [location.query.query]);
-
-  if (hasClickSearch) {
-    return TabKey.DOM;
-  }
-
-  return TabKey.BREADCRUMBS;
-}
-
 function useActiveReplayTab() {
-  const defaultTab = useDefaultTab();
+  const defaultTab = TabKey.BREADCRUMBS;
   const organization = useOrganization();
   const {getParamValue, setParamValue} = useUrlParams('t_main', defaultTab);
 

+ 2 - 2
static/app/utils/replays/hooks/useInitialTimeOffsetMs.spec.tsx

@@ -201,7 +201,7 @@ describe('useInitialTimeOffsetMs', () => {
       // Expecting 5 minutes difference, in ms
       expect(result.current).toStrictEqual({
         highlight: {
-          annotation: 'click.tag:button',
+          annotation: undefined,
           nodeId: 7,
           spotlight: true,
         },
@@ -246,7 +246,7 @@ describe('useInitialTimeOffsetMs', () => {
       expect(MockFetchReplayClicks).toHaveBeenCalledTimes(1);
       expect(result.current).toStrictEqual({
         highlight: {
-          annotation: 'click.tag:button',
+          annotation: undefined,
           nodeId: 7,
           spotlight: true,
         },

+ 1 - 1
static/app/utils/replays/hooks/useInitialTimeOffsetMs.tsx

@@ -143,7 +143,7 @@ async function fromListPageQuery({
     const firstTimestmpMs = new Date(firstTimestamp).getTime();
     return {
       highlight: {
-        annotation: listPageQuery,
+        annotation: undefined,
         nodeId,
         spotlight: true,
       },