Browse Source

ref: clean up BaseTestCase trick (#50807)

this was a hack for the type checker
anthony sottile 1 year ago
parent
commit
681232b031

+ 2 - 2
tests/sentry/middleware/integrations/parsers/test_jira.py

@@ -5,13 +5,13 @@ from django.test import RequestFactory, override_settings
 from sentry.middleware.integrations.integration_control import IntegrationControlMiddleware
 from sentry.middleware.integrations.parsers.jira import JiraRequestParser
 from sentry.silo.base import SiloMode
-from sentry.testutils.cases import BaseTestCase, TestCase
+from sentry.testutils.cases import TestCase
 from sentry.testutils.silo import control_silo_test
 from sentry.types.region import Region, RegionCategory
 
 
 @control_silo_test(stable=True)
-class JiraRequestParserTest(TestCase, BaseTestCase):
+class JiraRequestParserTest(TestCase):
     get_response = MagicMock()
     middleware = IntegrationControlMiddleware(get_response)
     factory = RequestFactory()

+ 3 - 4
tests/sentry/services/test_organization_actions.py

@@ -13,7 +13,6 @@ from sentry.services.hybrid_cloud.organization_actions.impl import (
     upsert_organization_by_org_id_with_outbox_message,
 )
 from sentry.testutils import TestCase
-from sentry.testutils.cases import BaseTestCase
 from sentry.testutils.outbox import outbox_runner
 from sentry.testutils.silo import region_silo_test
 
@@ -32,7 +31,7 @@ def assert_outbox_update_message_exists(org: Organization, expected_count: int):
 
 
 @region_silo_test(stable=True)
-class OrganizationUpdateTest(TestCase, BaseTestCase):
+class OrganizationUpdateTest(TestCase):
     def setUp(self):
         self.org: Organization = self.create_organization(slug="sluggy", name="barfoo")
 
@@ -54,7 +53,7 @@ class OrganizationUpdateTest(TestCase, BaseTestCase):
 
 
 @region_silo_test(stable=True)
-class OrganizationUpdateWithOutboxTest(TestCase, BaseTestCase):
+class OrganizationUpdateWithOutboxTest(TestCase):
     def setUp(self):
         self.org: Organization = self.create_organization(slug="sluggy", name="barfoo")
 
@@ -75,7 +74,7 @@ class OrganizationUpdateWithOutboxTest(TestCase, BaseTestCase):
 
 
 @region_silo_test(stable=True)
-class OrganizationUpsertWithOutboxTest(TestCase, BaseTestCase):
+class OrganizationUpsertWithOutboxTest(TestCase):
     def setUp(self):
         self.org: Organization = self.create_organization(slug="sluggy", name="barfoo")