build: upgrade to latest flake8 (3.5.0) (#9000)

requirements-dev.txt

@@ -1,5 +1,5 @@
-autopep8
+autopep8>=1.3.5,<1.4.0
 Babel
-flake8>=2.6,<2.7
+flake8>=3.5.0<3.6.0
 isort>=4.2.2,<4.3.0
-pycodestyle>=2.0,<2.1
+pycodestyle>=2.3,<2.4.0

src/bitfield/forms.py

@@ -43,11 +43,11 @@ class BitFormField(IntegerField):
     def __init__(self, choices=(), widget=BitFieldCheckboxSelectMultiple, *args, **kwargs):
         if isinstance(kwargs['initial'], int):
             iv = kwargs['initial']
-            l = []
+            L = []
             for i in range(0, 63):
                 if (1 << i) & iv > 0:
-                    l += [choices[i][0]]
-            kwargs['initial'] = l
+                    L += [choices[i][0]]
+            kwargs['initial'] = L
         self.widget = widget
         super(BitFormField, self).__init__(widget=widget, *args, **kwargs)
         self.choices = self.widget.choices = choices

src/sentry/api/endpoints/user_authenticator_enroll.py

@@ -55,6 +55,7 @@ class U2fRestSerializer(serializers.Serializer):
         required=True,
     )
 
+
 serializer_map = {
     'totp': TotpRestSerializer,
     'sms': SmsRestSerializer,

src/sentry/api/serializers/models/authenticator.py

@@ -38,5 +38,6 @@ class SmsInterfaceSerializer(AuthenticatorInterfaceSerializer):
         data['phone'] = obj.phone_number
         return data
 
+
 for interface in RecoveryCodeInterface, TotpInterface, U2fInterface:
     register(interface)(AuthenticatorInterfaceSerializer)

src/sentry/db/models/fields/citext.py

@@ -64,4 +64,5 @@ def create_citext_extension(db, **kwargs):
         except Exception:
             pass
 
+
 pre_syncdb.connect(create_citext_extension)

src/sentry/db/models/utils.py

@@ -21,6 +21,7 @@ from sentry.db.exceptions import CannotResolveExpression
 class _UnknownType(object):
     pass
 
+
 try:
     from django.db.models.expressions import ExpressionNode
     Value = _UnknownType

src/sentry/integrations/example/integration.py

@@ -26,6 +26,7 @@ class ExampleSetupView(PipelineView):
 
         return HttpResponse(self.TEMPLATE)
 
+
 DESCRIPTION = """
 This is an example integration
 

src/sentry/interfaces/schemas.py

@@ -34,6 +34,7 @@ def apierror(message="Invalid data"):
     from sentry.coreapi import APIForbidden
     raise APIForbidden(message)
 
+
 PAIRS = {
     'type': 'array',
     'items': {

src/sentry/lang/javascript/errorlocale.py

@@ -51,6 +51,7 @@ def find_translation(message):
 def format_message(message, data):
     return message.replace('%s', data)
 
+
 message_type_regexp = re.compile('^(?P<type>[a-zA-Z]*Error): (?P<message>.*)')
 
 

src/sentry/lint/engine.py

@@ -114,7 +114,7 @@ def get_python_files(file_list=None):
 
 # parseable is a no-op
 def py_lint(file_list, parseable=False):
-    from flake8.engine import get_style_guide
+    from flake8.api.legacy import get_style_guide
 
     file_list = get_python_files(file_list)
     flake8_style = get_style_guide(parse_argv=True)