Просмотр исходного кода

feat(webvitals): Add link and fix typo in perf score alert message (#63353)

Adds a link to the perf score update blog post
Fixes a typo in perf score alert message
edwardgou-sentry 1 год назад
Родитель
Сommit
67895cf519

+ 1 - 1
static/app/views/performance/browser/webVitals/pageOverview.spec.tsx

@@ -76,7 +76,7 @@ describe('PageOverview', function () {
     });
     render(<PageOverview />);
     await screen.findByText(
-      'We made improvements to how Performance Scores are calculated for your projects. Starting on 17 December 2023, scores are updated to more accurately reflect user experiences. Read more these improvements here.'
+      /We made improvements to how Performance Scores are calculated for your projects/
     );
   });
 });

+ 12 - 7
static/app/views/performance/browser/webVitals/pageOverview.tsx

@@ -11,6 +11,7 @@ import {AggregateSpans} from 'sentry/components/events/interfaces/spans/aggregat
 import FloatingFeedbackWidget from 'sentry/components/feedback/widget/floatingFeedbackWidget';
 import {COL_WIDTH_UNDEFINED, GridColumnOrder} from 'sentry/components/gridEditable';
 import * as Layout from 'sentry/components/layouts/thirds';
+import ExternalLink from 'sentry/components/links/externalLink';
 import {DatePageFilter} from 'sentry/components/organizations/datePageFilter';
 import {EnvironmentPageFilter} from 'sentry/components/organizations/environmentPageFilter';
 import PageFilterBar from 'sentry/components/organizations/pageFilterBar';
@@ -240,13 +241,17 @@ export default function PageOverview() {
               {shouldUseStoredScores && !isDismissed && (
                 <StyledAlert type="info" showIcon>
                   <AlertContent>
-                    {
-                      // TODO: Add link to blog when ready
-                      tct(
-                        `We made improvements to how Performance Scores are calculated for your projects. Starting on [scoreMigrationTimestampString], scores are updated to more accurately reflect user experiences. Read more these improvements here.`,
-                        {scoreMigrationTimestampString}
-                      )
-                    }
+                    <span>
+                      {tct(
+                        `We made improvements to how Performance Scores are calculated for your projects. Starting on [scoreMigrationTimestampString], scores are updated to more accurately reflect user experiences. [link:Read more about these improvements].`,
+                        {
+                          scoreMigrationTimestampString,
+                          link: (
+                            <ExternalLink href="https://sentry.engineering/blog/how-we-improved-performance-score-accuracy" />
+                          ),
+                        }
+                      )}
+                    </span>
                     <DismissButton
                       priority="link"
                       icon={<IconClose />}

+ 1 - 1
static/app/views/performance/browser/webVitals/webVitalsLandingPage.spec.tsx

@@ -72,7 +72,7 @@ describe('WebVitalsLandingPage', function () {
     });
     render(<WebVitalsLandingPage />);
     await screen.findByText(
-      'We made improvements to how Performance Scores are calculated for your projects. Starting on 17 December 2023, scores are updated to more accurately reflect user experiences. Read more these improvements here.'
+      /We made improvements to how Performance Scores are calculated for your projects/
     );
   });
 });

+ 12 - 7
static/app/views/performance/browser/webVitals/webVitalsLandingPage.tsx

@@ -8,6 +8,7 @@ import {Breadcrumbs} from 'sentry/components/breadcrumbs';
 import {Button} from 'sentry/components/button';
 import FloatingFeedbackWidget from 'sentry/components/feedback/widget/floatingFeedbackWidget';
 import * as Layout from 'sentry/components/layouts/thirds';
+import ExternalLink from 'sentry/components/links/externalLink';
 import {DatePageFilter} from 'sentry/components/organizations/datePageFilter';
 import {EnvironmentPageFilter} from 'sentry/components/organizations/environmentPageFilter';
 import PageFilterBar from 'sentry/components/organizations/pageFilterBar';
@@ -113,13 +114,17 @@ export default function WebVitalsLandingPage() {
               {shouldUseStoredScores && !isDismissed && (
                 <StyledAlert type="info" showIcon>
                   <AlertContent>
-                    {
-                      // TODO: Add link to blog when ready
-                      tct(
-                        `We made improvements to how Performance Scores are calculated for your projects. Starting on [scoreMigrationTimestampString], scores are updated to more accurately reflect user experiences. Read more these improvements here.`,
-                        {scoreMigrationTimestampString}
-                      )
-                    }
+                    <span>
+                      {tct(
+                        `We made improvements to how Performance Scores are calculated for your projects. Starting on [scoreMigrationTimestampString], scores are updated to more accurately reflect user experiences. [link:Read more about these improvements].`,
+                        {
+                          scoreMigrationTimestampString,
+                          link: (
+                            <ExternalLink href="https://sentry.engineering/blog/how-we-improved-performance-score-accuracy" />
+                          ),
+                        }
+                      )}
+                    </span>
                     <DismissButton
                       priority="link"
                       icon={<IconClose />}