Browse Source

chore(ts): Use UPPER_CASE for non-exported enums (#50361)

Evan Purkhiser 1 year ago
parent
commit
658a5b4a8c

+ 6 - 6
static/app/components/events/interfaces/breadcrumbs/index.tsx

@@ -44,15 +44,15 @@ type Props = {
 };
 
 enum BreadcrumbSort {
-  Newest = 'newest',
-  Oldest = 'oldest',
+  NEWEST = 'newest',
+  OLDEST = 'oldest',
 }
 
 const EVENT_BREADCRUMB_SORT_LOCALSTORAGE_KEY = 'event-breadcrumb-sort';
 
 const sortOptions = [
-  {label: t('Newest'), value: BreadcrumbSort.Newest},
-  {label: t('Oldest'), value: BreadcrumbSort.Oldest},
+  {label: t('Newest'), value: BreadcrumbSort.NEWEST},
+  {label: t('Oldest'), value: BreadcrumbSort.OLDEST},
 ];
 
 function BreadcrumbsContainer({data, event, organization, projectSlug, isShare}: Props) {
@@ -61,7 +61,7 @@ function BreadcrumbsContainer({data, event, organization, projectSlug, isShare}:
   const [displayRelativeTime, setDisplayRelativeTime] = useState(false);
   const [sort, setSort] = useLocalStorageState<BreadcrumbSort>(
     EVENT_BREADCRUMB_SORT_LOCALSTORAGE_KEY,
-    BreadcrumbSort.Newest
+    BreadcrumbSort.NEWEST
   );
 
   const entryIndex = event.entries.findIndex(
@@ -249,7 +249,7 @@ function BreadcrumbsContainer({data, event, organization, projectSlug, isShare}:
     // Breadcrumbs come back from API sorted oldest -> newest.
     // Need to `reverse()` instead of sort by timestamp because crumbs with
     // exact same timestamp will appear out of order.
-    return sort === BreadcrumbSort.Newest
+    return sort === BreadcrumbSort.NEWEST
       ? [...filteredBreadcrumbs].reverse()
       : filteredBreadcrumbs;
   }, [

+ 8 - 8
static/app/components/events/interfaces/spans/dragManager.tsx

@@ -8,8 +8,8 @@ import {setBodyUserSelect, UserSelectValues} from 'sentry/utils/userselect';
 const MINIMUM_WINDOW_SIZE = 0.5 / 100; // 0.5% window size
 
 enum ViewHandleType {
-  Left,
-  Right,
+  LEFT,
+  RIGHT,
 }
 
 export type DragManagerChildrenProps = {
@@ -136,11 +136,11 @@ class DragManager extends Component<DragManagerProps, DragManagerState> {
     };
 
   onLeftHandleDragStart = (event: React.MouseEvent<HTMLDivElement, MouseEvent>) => {
-    this.onDragStart(ViewHandleType.Left)(event);
+    this.onDragStart(ViewHandleType.LEFT)(event);
   };
 
   onRightHandleDragStart = (event: React.MouseEvent<HTMLDivElement, MouseEvent>) => {
-    this.onDragStart(ViewHandleType.Right)(event);
+    this.onDragStart(ViewHandleType.RIGHT)(event);
   };
 
   onDragMove = (event: MouseEvent) => {
@@ -158,7 +158,7 @@ class DragManager extends Component<DragManagerProps, DragManagerState> {
     const rawMouseX = (event.pageX - rect.x) / rect.width;
 
     switch (this.state.currentDraggingHandle) {
-      case ViewHandleType.Left: {
+      case ViewHandleType.LEFT: {
         const min = 0;
         const max = this.state.rightHandlePosition - MINIMUM_WINDOW_SIZE;
 
@@ -168,7 +168,7 @@ class DragManager extends Component<DragManagerProps, DragManagerState> {
         });
         break;
       }
-      case ViewHandleType.Right: {
+      case ViewHandleType.RIGHT: {
         const min = this.state.leftHandlePosition + MINIMUM_WINDOW_SIZE;
         const max = 1;
 
@@ -209,7 +209,7 @@ class DragManager extends Component<DragManagerProps, DragManagerState> {
     // indicate drag has ended
 
     switch (this.state.currentDraggingHandle) {
-      case ViewHandleType.Left: {
+      case ViewHandleType.LEFT: {
         this.setState(state => ({
           isDragging: false,
           currentDraggingHandle: void 0,
@@ -219,7 +219,7 @@ class DragManager extends Component<DragManagerProps, DragManagerState> {
         }));
         return;
       }
-      case ViewHandleType.Right: {
+      case ViewHandleType.RIGHT: {
         this.setState(state => ({
           isDragging: false,
           currentDraggingHandle: void 0,

+ 3 - 3
static/app/components/replays/replayContext.tsx

@@ -18,7 +18,7 @@ import useOrganization from 'sentry/utils/useOrganization';
 import usePrevious from 'sentry/utils/usePrevious';
 
 enum ReplayLocalstorageKeys {
-  ReplayConfig = 'replay-config',
+  REPLAY_CONFIG = 'replay-config',
 }
 type ReplayConfig = {
   skip?: boolean;
@@ -210,7 +210,7 @@ function useCurrentTime(callback: () => number) {
 }
 
 function updateSavedReplayConfig(config: ReplayConfig) {
-  localStorage.setItem(ReplayLocalstorageKeys.ReplayConfig, JSON.stringify(config));
+  localStorage.setItem(ReplayLocalstorageKeys.REPLAY_CONFIG, JSON.stringify(config));
 }
 
 export function Provider({
@@ -224,7 +224,7 @@ export function Provider({
   const organization = useOrganization();
   const events = replay?.getRRWebEvents();
   const savedReplayConfigRef = useRef<ReplayConfig>(
-    JSON.parse(localStorage.getItem(ReplayLocalstorageKeys.ReplayConfig) || '{}')
+    JSON.parse(localStorage.getItem(ReplayLocalstorageKeys.REPLAY_CONFIG) || '{}')
   );
 
   const theme = useTheme();

+ 13 - 13
static/app/utils/profiling/fzf/fzf.ts

@@ -41,10 +41,10 @@ const bonusConsecutive = -(scoreGapStart + scoreGapExtention);
 const bonusFirstCharMultiplier = 2;
 
 enum CharTypes {
-  charLower,
-  charUpper,
-  charNumber,
-  charNonWord,
+  CHAR_LOWER,
+  CHAR_UPPER,
+  CHAR_NUMBER,
+  CHAR_NON_WORD,
 }
 
 const CharCodes = {
@@ -58,15 +58,15 @@ const CharCodes = {
 
 function getCharClass(c: number): CharTypes {
   if (c >= CharCodes.lowerA && c <= CharCodes.lowerZ) {
-    return CharTypes.charLower;
+    return CharTypes.CHAR_LOWER;
   }
   if (c >= CharCodes.upperA && c <= CharCodes.upperZ) {
-    return CharTypes.charUpper;
+    return CharTypes.CHAR_UPPER;
   }
   if (c >= CharCodes.zero && c <= CharCodes.nine) {
-    return CharTypes.charNumber;
+    return CharTypes.CHAR_NUMBER;
   }
-  return CharTypes.charNonWord;
+  return CharTypes.CHAR_NON_WORD;
 }
 
 // Algo functions make two assumptions
@@ -146,18 +146,18 @@ export function fzf(text: string, pattern: string, caseSensitive: boolean): Resu
 }
 
 function bonusForCharClass(prevClass: CharTypes, currentClass: CharTypes): number {
-  if (prevClass === CharTypes.charNonWord && currentClass !== CharTypes.charNonWord) {
+  if (prevClass === CharTypes.CHAR_NON_WORD && currentClass !== CharTypes.CHAR_NON_WORD) {
     // Word boundary
     return bonusBoundary;
   }
   if (
-    (prevClass === CharTypes.charLower && currentClass === CharTypes.charUpper) ||
-    (prevClass !== CharTypes.charNumber && currentClass === CharTypes.charNumber)
+    (prevClass === CharTypes.CHAR_LOWER && currentClass === CharTypes.CHAR_UPPER) ||
+    (prevClass !== CharTypes.CHAR_NUMBER && currentClass === CharTypes.CHAR_NUMBER)
   ) {
     // camelCase letter123
     return bonusCamel123;
   }
-  if (currentClass === CharTypes.charNonWord) {
+  if (currentClass === CharTypes.CHAR_NON_WORD) {
     return bonusNonWord;
   }
   return 0;
@@ -177,7 +177,7 @@ function calculateScore(
   let firstBonus = 0;
   let consecutive = 0;
 
-  let prevCharClass = CharTypes.charNonWord;
+  let prevCharClass = CharTypes.CHAR_NON_WORD;
   const pos: number[] = new Array(pattern.length);
 
   if (sidx > 0) {

+ 5 - 5
static/app/views/settings/projectSourceMaps/projectSourceMaps.tsx

@@ -40,8 +40,8 @@ enum SORT_BY {
 }
 
 enum SourceMapsBundleType {
-  Release,
-  DebugId,
+  RELEASE,
+  DEBUG_ID,
 }
 
 function SourceMapsTableRow({
@@ -62,7 +62,7 @@ function SourceMapsTableRow({
   idColumnDetails?: React.ReactNode;
 }) {
   const isEmptyReleaseBundle =
-    bundleType === SourceMapsBundleType.Release && fileCount === -1;
+    bundleType === SourceMapsBundleType.RELEASE && fileCount === -1;
 
   return (
     <Fragment>
@@ -340,7 +340,7 @@ export function ProjectSourceMaps({location, router, project}: Props) {
           ? debugIdBundlesData?.map(data => (
               <SourceMapsTableRow
                 key={data.bundleId}
-                bundleType={SourceMapsBundleType.DebugId}
+                bundleType={SourceMapsBundleType.DEBUG_ID}
                 date={data.date}
                 fileCount={data.fileCount}
                 name={data.bundleId}
@@ -356,7 +356,7 @@ export function ProjectSourceMaps({location, router, project}: Props) {
           : archivesData?.map(data => (
               <SourceMapsTableRow
                 key={data.name}
-                bundleType={SourceMapsBundleType.Release}
+                bundleType={SourceMapsBundleType.RELEASE}
                 date={data.date}
                 fileCount={data.fileCount}
                 name={data.name}