Browse Source

feat(trace): use message (#69988)

Jonas 10 months ago
parent
commit
641edc5e0d

+ 1 - 0
fixtures/js-stubs/traceError.tsx

@@ -8,6 +8,7 @@ export function TraceErrorFixture(params: Partial<TraceError> = {}): TraceError
     project_id: 8,
     project_slug: 'santry',
     title: 'Error: Something went wrong',
+    message: 'Something went wrong',
     level: 'error',
     issue: '',
     ...params,

+ 1 - 0
fixtures/js-stubs/tracePerformanceIssue.tsx

@@ -9,6 +9,7 @@ export function TracePerformanceIssueFixture(
     project_id: 8,
     project_slug: 'santry',
     title: 'Large HTTP payload',
+    message: 'Large HTTP payload',
     level: 'info',
     type: 1015,
     culprit: '',

+ 1 - 0
static/app/utils/performance/quickTrace/types.tsx

@@ -29,6 +29,7 @@ export type TraceError = {
   issue: string;
   issue_id: number;
   level: keyof Theme['level'];
+  message: string;
   project_id: number;
   project_slug: string;
   span: string;

+ 2 - 0
static/app/views/issueDetails/groupEventDetails/groupEventDetails.spec.tsx

@@ -164,6 +164,7 @@ const mockedTrace = (project: Project) => {
         project_id: parseInt(project.id, 10),
         project_slug: project.slug,
         title: 'ApplicationNotResponding: ANR for at least 5000 ms.',
+        message: 'ANR for at least 5000 ms.',
         level: 'error',
         issue: '',
       },
@@ -178,6 +179,7 @@ const mockedTrace = (project: Project) => {
         project_id: parseInt(project.id, 10),
         project_slug: project.slug,
         title: 'File IO on Main Thread',
+        message: 'File IO on Main Thread',
         level: 'info',
         culprit: 'MainActivity.add_attachment',
         type: 1008,

+ 3 - 1
static/app/views/performance/newTraceDetails/trace.tsx

@@ -1000,7 +1000,9 @@ function RenderRow(props: {
               {ERROR_LEVEL_LABELS[props.node.value.level ?? 'error']}
             </span>
             <strong className="TraceEmDash"> — </strong>
-            <span className="TraceDescription">{props.node.value.title}</span>
+            <span className="TraceDescription">
+              {props.node.value.message ?? props.node.value.title}
+            </span>
           </div>
         </div>
         <div

+ 1 - 1
static/app/views/performance/newTraceDetails/traceDrawer/details/error.tsx

@@ -74,7 +74,7 @@ export function ErrorNodeDetails({
             <div>{node.value.level ?? t('error')}</div>
             <TraceDrawerComponents.TitleOp>
               {' '}
-              {node.value.title}
+              {node.value.message ?? node.value.title ?? 'Error'}
             </TraceDrawerComponents.TitleOp>
           </TraceDrawerComponents.TitleText>
         </TraceDrawerComponents.Title>

+ 1 - 0
static/app/views/performance/newTraceDetails/traceRenderers/virtualizedViewManager.spec.tsx

@@ -679,6 +679,7 @@ describe('VirtualizedViewManger', () => {
               span: '',
               level: 'error',
               title: 'ded fo good',
+              message: 'ded fo good',
               timestamp: 1,
             },
           ],

+ 1 - 1
static/app/views/performance/newTraceDetails/traceState/traceTabs.tsx

@@ -38,7 +38,7 @@ export function getTraceTabTitle(node: TraceTreeNode<TraceTree.NodeValue>) {
   }
 
   if (isTraceErrorNode(node)) {
-    return node.value.title || 'Error';
+    return node.value.message ?? node.value.title ?? 'Error';
   }
 
   if (isTraceNode(node)) {