Browse Source

ci: Fix lint violations passing build

David Cramer 7 years ago
parent
commit
641c03314a
4 changed files with 4 additions and 4 deletions
  1. 1 0
      .gitignore
  2. 2 2
      Makefile
  3. 0 1
      src/sentry/coreapi.py
  4. 1 1
      src/sentry/static/sentry/app/views/projectFilters.jsx

+ 1 - 0
.gitignore

@@ -37,3 +37,4 @@ Gemfile.lock
 .vscode/tags
 coverage.xml
 junit.xml
+*.codestyle.xml

+ 2 - 2
Makefile

@@ -158,12 +158,12 @@ lint: lint-python lint-js
 
 lint-python:
 	@echo "--> Linting python"
-	bin/lint --python --parseable | tee flake8.pycodestyle.log
+	bash -eo pipefail -c "bin/lint --python --parseable | tee flake8.pycodestyle.log"
 	@echo ""
 
 lint-js:
 	@echo "--> Linting javascript"
-	bin/lint --js --parseable | tee eslint.codestyle.xml
+	bash -eo pipefail -c "bin/lint --js --parseable | tee eslint.codestyle.xml"
 	@echo ""
 
 coverage: develop

+ 0 - 1
src/sentry/coreapi.py

@@ -25,7 +25,6 @@ from time import time
 
 from sentry import filters
 from sentry.cache import default_cache
-from sentry.constants import VERSION_LENGTH
 from sentry.interfaces.csp import Csp
 from sentry.event_manager import EventManager
 from sentry.lang.native.utils import merge_minidump_event

+ 1 - 1
src/sentry/static/sentry/app/views/projectFilters.jsx

@@ -638,7 +638,7 @@ const ProjectFilters = React.createClass({
               orgId,
               projectId,
               onToggle: this.onToggleFilter,
-              idx: idx,
+              idx,
             };
             return filter.id === 'legacy-browsers' ? (
               <LegacyBrowserFilterRow {...props} />