Browse Source

chore(suspect-spans): Remove project from suspect spans query (#30886)

As a minor optimization, remove the project and transaction columns from the
suspect spans query. Reducing the number of columns we group by should give us
a minor performance improvement.
Tony Xiao 3 years ago
parent
commit
60b8c982e8

+ 0 - 12
src/sentry/api/endpoints/organization_events_spans_performance.py

@@ -321,9 +321,6 @@ class ExampleTransaction:
 
 @dataclasses.dataclass(frozen=True)
 class SuspectSpan:
-    project_id: int
-    project: str
-    transaction: str
     op: str
     group: str
     frequency: Optional[int]
@@ -337,9 +334,6 @@ class SuspectSpan:
 
     def serialize(self) -> Any:
         return {
-            "projectId": self.project_id,
-            "project": self.project,
-            "transaction": self.transaction,
             "op": self.op,
             "group": self.group.rjust(16, "0"),
             "frequency": self.frequency,
@@ -407,9 +401,6 @@ def query_suspect_span_groups(
         for column in suspect_span_columns.suspect_op_group_columns + fields
         if not is_equation(column)
     ] + [
-        "project.id",
-        "project",
-        "transaction",
         "array_join(spans_op)",
         "array_join(spans_group)",
         "count()",
@@ -477,9 +468,6 @@ def query_suspect_span_groups(
 
     return [
         SuspectSpan(
-            project_id=suspect["project.id"],
-            project=suspect["project"],
-            transaction=suspect["transaction"],
             op=suspect["array_join_spans_op"],
             group=suspect["array_join_spans_group"],
             frequency=suspect.get("count_unique_id"),

+ 0 - 6
tests/snuba/api/endpoints/test_organization_events_spans_performance.py

@@ -182,9 +182,6 @@ class OrganizationEventsSpansEndpointTestBase(APITestCase, SnubaTestCase):
             result,
             expected_result,
             [
-                "projectId",
-                "project",
-                "transaction",
                 "op",
                 "group",
                 "frequency",
@@ -203,9 +200,6 @@ class OrganizationEventsSpansEndpointTestBase(APITestCase, SnubaTestCase):
 
     def suspect_span_group_snuba_results(self, op, event):
         results = {
-            "project.id": self.project.id,
-            "project": self.project.slug,
-            "transaction": event.transaction,
             "array_join_spans_op": op,
         }