Browse Source

Revert "fix(sentry-apps): fix bug with external install of sentry apps (#49979)"

This reverts commit cf981a5c074ac3e281c90482cf7b5cd902a387ac.

Co-authored-by: scefali <8533851+scefali@users.noreply.github.com>
getsentry-bot 1 year ago
parent
commit
5f69981621
1 changed files with 3 additions and 17 deletions
  1. 3 17
      static/app/views/sentryAppExternalInstallation/index.tsx

+ 3 - 17
static/app/views/sentryAppExternalInstallation/index.tsx

@@ -3,7 +3,6 @@ import styled from '@emotion/styled';
 
 import {addErrorMessage} from 'sentry/actionCreators/indicator';
 import {installSentryApp} from 'sentry/actionCreators/sentryAppInstallations';
-import {Client} from 'sentry/api';
 import {Alert} from 'sentry/components/alert';
 import OrganizationAvatar from 'sentry/components/avatar/organizationAvatar';
 import SelectControl from 'sentry/components/forms/controls/selectControl';
@@ -11,7 +10,6 @@ import FieldGroup from 'sentry/components/forms/fieldGroup';
 import SentryAppDetailsModal from 'sentry/components/modals/sentryAppDetailsModal';
 import NarrowLayout from 'sentry/components/narrowLayout';
 import {t, tct} from 'sentry/locale';
-import ConfigStore from 'sentry/stores/configStore';
 import {Organization, SentryApp, SentryAppInstallation} from 'sentry/types';
 import {trackIntegrationAnalytics} from 'sentry/utils/integrationUtil';
 import {addQueryParamsToExistingUrl} from 'sentry/utils/queryString';
@@ -19,11 +17,6 @@ import AsyncView from 'sentry/views/asyncView';
 
 import {OrganizationContext} from '../organizationContext';
 
-function generateBaseUrl() {
-  const baseUrl = ConfigStore.get('links').sentryUrl || '';
-  return baseUrl + '/api/0';
-}
-
 type Props = RouteComponentProps<{sentryAppSlug: string}, {}>;
 
 type State = AsyncView['state'] & {
@@ -36,7 +29,6 @@ type State = AsyncView['state'] & {
 
 export default class SentryAppExternalInstallation extends AsyncView<Props, State> {
   disableErrorReport = false;
-  controlSiloApi = new Client({baseUrl: generateBaseUrl()});
 
   getDefaultState() {
     const state = super.getDefaultState();
@@ -110,11 +102,7 @@ export default class SentryAppExternalInstallation extends AsyncView<Props, Stat
       organization,
     });
 
-    const install = await installSentryApp(
-      this.controlSiloApi,
-      organization.slug,
-      sentryApp
-    );
+    const install = await installSentryApp(this.api, organization.slug, sentryApp);
     // installation is complete if the status is installed
     if (install.status === 'installed') {
       trackIntegrationAnalytics('integrations.installation_complete', {
@@ -144,10 +132,8 @@ export default class SentryAppExternalInstallation extends AsyncView<Props, Stat
     try {
       const [organization, installations]: [Organization, SentryAppInstallation[]] =
         await Promise.all([
-          this.controlSiloApi.requestPromise(`/organizations/${orgSlug}/`),
-          this.controlSiloApi.requestPromise(
-            `/organizations/${orgSlug}/sentry-app-installations/`
-          ),
+          this.api.requestPromise(`/organizations/${orgSlug}/`),
+          this.api.requestPromise(`/organizations/${orgSlug}/sentry-app-installations/`),
         ]);
       const isInstalled = installations
         .map(install => install.app.slug)