Browse Source

test(hc): Delete default region_silo_test decorators (#67722)

Delete the `@region_silo_test` decorator where it is redundant to the
default test environment. Only instances with no arguments are affected;
`@region_silo_test` instances with `regions` or `include_monolith_run`
arguments remain in place.
Ryan Skonnord 11 months ago
parent
commit
5df59b5534

+ 0 - 4
tests/apidocs/endpoints/events/test_group_events.py

@@ -2,7 +2,6 @@ from django.test.client import RequestFactory
 
 
 from fixtures.apidocs_test_case import APIDocsTestCase
 from fixtures.apidocs_test_case import APIDocsTestCase
 from sentry.testutils.helpers.datetime import before_now, iso_format
 from sentry.testutils.helpers.datetime import before_now, iso_format
-from sentry.testutils.silo import region_silo_test
 
 
 
 
 class ProjectGroupEventBase(APIDocsTestCase):
 class ProjectGroupEventBase(APIDocsTestCase):
@@ -28,7 +27,6 @@ class ProjectGroupEventBase(APIDocsTestCase):
         self.login_as(user=self.user)
         self.login_as(user=self.user)
 
 
 
 
-@region_silo_test
 class ProjectGroupEventsDocs(ProjectGroupEventBase):
 class ProjectGroupEventsDocs(ProjectGroupEventBase):
     def setUp(self):
     def setUp(self):
         super().setUp()
         super().setUp()
@@ -41,7 +39,6 @@ class ProjectGroupEventsDocs(ProjectGroupEventBase):
         self.validate_schema(request, response)
         self.validate_schema(request, response)
 
 
 
 
-@region_silo_test
 class ProjectGroupEventsLatestDocs(ProjectGroupEventBase):
 class ProjectGroupEventsLatestDocs(ProjectGroupEventBase):
     def setUp(self):
     def setUp(self):
         super().setUp()
         super().setUp()
@@ -56,7 +53,6 @@ class ProjectGroupEventsLatestDocs(ProjectGroupEventBase):
         self.validate_schema(request, response)
         self.validate_schema(request, response)
 
 
 
 
-@region_silo_test
 class ProjectGroupEventsOldestDocs(ProjectGroupEventBase):
 class ProjectGroupEventsOldestDocs(ProjectGroupEventBase):
     def setUp(self):
     def setUp(self):
         super().setUp()
         super().setUp()

+ 0 - 2
tests/apidocs/endpoints/events/test_group_hashes.py

@@ -1,10 +1,8 @@
 from django.test.client import RequestFactory
 from django.test.client import RequestFactory
 
 
 from fixtures.apidocs_test_case import APIDocsTestCase
 from fixtures.apidocs_test_case import APIDocsTestCase
-from sentry.testutils.silo import region_silo_test
 
 
 
 
-@region_silo_test
 class ProjectGroupHashesDocs(APIDocsTestCase):
 class ProjectGroupHashesDocs(APIDocsTestCase):
     def setUp(self):
     def setUp(self):
         self.create_event("a")
         self.create_event("a")

+ 0 - 2
tests/apidocs/endpoints/events/test_group_issue_details.py

@@ -2,10 +2,8 @@ from django.test.client import RequestFactory
 
 
 from fixtures.apidocs_test_case import APIDocsTestCase
 from fixtures.apidocs_test_case import APIDocsTestCase
 from sentry.testutils.helpers.datetime import before_now, iso_format
 from sentry.testutils.helpers.datetime import before_now, iso_format
-from sentry.testutils.silo import region_silo_test
 
 
 
 
-@region_silo_test
 class ProjectGroupIssueDetailsDocs(APIDocsTestCase):
 class ProjectGroupIssueDetailsDocs(APIDocsTestCase):
     def setUp(self):
     def setUp(self):
         self.create_release(project=self.project, version="abcdabc")
         self.create_release(project=self.project, version="abcdabc")

+ 0 - 2
tests/apidocs/endpoints/events/test_group_tagkey_values.py

@@ -1,10 +1,8 @@
 from django.test.client import RequestFactory
 from django.test.client import RequestFactory
 
 
 from fixtures.apidocs_test_case import APIDocsTestCase
 from fixtures.apidocs_test_case import APIDocsTestCase
-from sentry.testutils.silo import region_silo_test
 
 
 
 
-@region_silo_test
 class GroupTagKeyValuesDocs(APIDocsTestCase):
 class GroupTagKeyValuesDocs(APIDocsTestCase):
     def setUp(self):
     def setUp(self):
         key, value = "foo", "bar"
         key, value = "foo", "bar"

+ 0 - 2
tests/apidocs/endpoints/events/test_project_event_details.py

@@ -2,10 +2,8 @@ from django.test.client import RequestFactory
 from django.urls import reverse
 from django.urls import reverse
 
 
 from fixtures.apidocs_test_case import APIDocsTestCase
 from fixtures.apidocs_test_case import APIDocsTestCase
-from sentry.testutils.silo import region_silo_test
 
 
 
 
-@region_silo_test
 class ProjectEventDetailsDocs(APIDocsTestCase):
 class ProjectEventDetailsDocs(APIDocsTestCase):
     endpoint = "sentry-api-0-project-event-details"
     endpoint = "sentry-api-0-project-event-details"
 
 

+ 0 - 2
tests/apidocs/endpoints/events/test_project_issues.py

@@ -1,10 +1,8 @@
 from django.test.client import RequestFactory
 from django.test.client import RequestFactory
 
 
 from fixtures.apidocs_test_case import APIDocsTestCase
 from fixtures.apidocs_test_case import APIDocsTestCase
-from sentry.testutils.silo import region_silo_test
 
 
 
 
-@region_silo_test
 class ProjectIssuesDocs(APIDocsTestCase):
 class ProjectIssuesDocs(APIDocsTestCase):
     def setUp(self):
     def setUp(self):
         self.create_event("a")
         self.create_event("a")

+ 0 - 2
tests/apidocs/endpoints/events/test_project_tagkey_values.py

@@ -2,10 +2,8 @@ from django.test.client import RequestFactory
 from django.urls import reverse
 from django.urls import reverse
 
 
 from fixtures.apidocs_test_case import APIDocsTestCase
 from fixtures.apidocs_test_case import APIDocsTestCase
-from sentry.testutils.silo import region_silo_test
 
 
 
 
-@region_silo_test
 class ProjectTagKeyValuesDocs(APIDocsTestCase):
 class ProjectTagKeyValuesDocs(APIDocsTestCase):
     def setUp(self):
     def setUp(self):
         key = "foo"
         key = "foo"

+ 1 - 2
tests/apidocs/endpoints/integration_platform/test_sentry_app_external_issue_details.py

@@ -4,10 +4,9 @@ from django.urls import reverse
 from fixtures.apidocs_test_case import APIDocsTestCase
 from fixtures.apidocs_test_case import APIDocsTestCase
 from sentry.models.integrations.sentry_app_installation import SentryAppInstallation
 from sentry.models.integrations.sentry_app_installation import SentryAppInstallation
 from sentry.silo import SiloMode
 from sentry.silo import SiloMode
-from sentry.testutils.silo import assume_test_silo_mode, region_silo_test
+from sentry.testutils.silo import assume_test_silo_mode
 
 
 
 
-@region_silo_test
 class SentryAppDetailsDocsTest(APIDocsTestCase):
 class SentryAppDetailsDocsTest(APIDocsTestCase):
     def setUp(self):
     def setUp(self):
         self.org = self.create_organization(owner=self.user, name="Rowdy Tiger")
         self.org = self.create_organization(owner=self.user, name="Rowdy Tiger")

+ 1 - 2
tests/apidocs/endpoints/integration_platform/test_sentry_app_external_issues.py

@@ -4,10 +4,9 @@ from django.urls import reverse
 from fixtures.apidocs_test_case import APIDocsTestCase
 from fixtures.apidocs_test_case import APIDocsTestCase
 from sentry.models.integrations.sentry_app_installation import SentryAppInstallation
 from sentry.models.integrations.sentry_app_installation import SentryAppInstallation
 from sentry.silo import SiloMode
 from sentry.silo import SiloMode
-from sentry.testutils.silo import assume_test_silo_mode, region_silo_test
+from sentry.testutils.silo import assume_test_silo_mode
 
 
 
 
-@region_silo_test
 class SentryAppDocsTest(APIDocsTestCase):
 class SentryAppDocsTest(APIDocsTestCase):
     def setUp(self):
     def setUp(self):
         self.org = self.create_organization(owner=self.user, name="Rowdy Tiger")
         self.org = self.create_organization(owner=self.user, name="Rowdy Tiger")

+ 0 - 2
tests/apidocs/endpoints/organizations/test_event_id_lookup.py

@@ -2,10 +2,8 @@ from django.test.client import RequestFactory
 from django.urls import reverse
 from django.urls import reverse
 
 
 from fixtures.apidocs_test_case import APIDocsTestCase
 from fixtures.apidocs_test_case import APIDocsTestCase
-from sentry.testutils.silo import region_silo_test
 
 
 
 
-@region_silo_test
 class OrganizationEventIDLookupDocs(APIDocsTestCase):
 class OrganizationEventIDLookupDocs(APIDocsTestCase):
     def setUp(self):
     def setUp(self):
         event = self.create_event("a", message="oh no")
         event = self.create_event("a", message="oh no")

Some files were not shown because too many files changed in this diff