Browse Source

make project id nullable (#20892)

Stephen Cefali 4 years ago
parent
commit
5dd2feb159

+ 1 - 1
migrations_lockfile.txt

@@ -10,7 +10,7 @@ auth: 0008_alter_user_username_max_length
 contenttypes: 0002_remove_content_type_name
 jira_ac: 0001_initial
 nodestore: 0001_initial
-sentry: 0105_remove_nullability_of_event_attachment_type
+sentry: 0106_service_hook_project_id_nullable
 sessions: 0001_initial
 sites: 0002_alter_domain_unique
 social_auth: 0001_initial

+ 38 - 0
src/sentry/migrations/0106_service_hook_project_id_nullable.py

@@ -0,0 +1,38 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.11.29 on 2020-09-21 19:33
+from __future__ import unicode_literals
+
+from django.db import migrations
+import sentry.db.models.fields.bounded
+
+
+class Migration(migrations.Migration):
+    # This flag is used to mark that a migration shouldn't be automatically run in
+    # production. We set this to True for operations that we think are risky and want
+    # someone from ops to run manually and monitor.
+    # General advice is that if in doubt, mark your migration as `is_dangerous`.
+    # Some things you should always mark as dangerous:
+    # - Large data migrations. Typically we want these to be run manually by ops so that
+    #   they can be monitored. Since data migrations will now hold a transaction open
+    #   this is even more important.
+    # - Adding columns to highly active tables, even ones that are NULL.
+    is_dangerous = False
+
+    # This flag is used to decide whether to run this migration in a transaction or not.
+    # By default we prefer to run in a transaction, but for migrations where you want
+    # to `CREATE INDEX CONCURRENTLY` this needs to be set to False. Typically you'll
+    # want to create an index concurrently when adding one to an existing table.
+    atomic = True
+
+
+    dependencies = [
+        ('sentry', '0105_remove_nullability_of_event_attachment_type'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='servicehook',
+            name='project_id',
+            field=sentry.db.models.fields.bounded.BoundedPositiveIntegerField(db_index=True, null=True),
+        ),
+    ]

+ 1 - 1
src/sentry/models/servicehook.py

@@ -51,7 +51,7 @@ class ServiceHook(Model):
     # hooks may be bound to an api application, or simply registered by a user
     application = FlexibleForeignKey("sentry.ApiApplication", null=True)
     actor_id = BoundedPositiveIntegerField(db_index=True)
-    project_id = BoundedPositiveIntegerField(db_index=True)
+    project_id = BoundedPositiveIntegerField(db_index=True, null=True)
     organization_id = BoundedPositiveIntegerField(db_index=True, null=True)
     url = models.URLField(max_length=512)
     secret = EncryptedTextField(default=generate_secret)