Просмотр исходного кода

fix(discover): Also set the value for device class tags in events-facets (#46449)

Also updates the events-facets endpoint to map the `value` when
returning the device.class tag
edwardgou-sentry 1 год назад
Родитель
Сommit
5d6ee503de

+ 1 - 2
src/sentry/api/endpoints/organization_events_facets.py

@@ -63,8 +63,7 @@ class OrganizationEventsFacetsEndpoint(OrganizationEventsV2EndpointBase):
                 for v in resp["device.class"]["topValues"]:
                     for key, value in DEVICE_CLASS.items():
                         if v["value"] in value:
-                            name = key
-                            v.update({"name": name})
+                            v.update({"name": key, "value": key})
                             filtered_values.append(v)
                             continue
 

+ 3 - 3
tests/snuba/api/endpoints/test_organization_events_facets.py

@@ -664,8 +664,8 @@ class OrganizationEventsFacetsEndpointTest(SnubaTestCase, APITestCase):
 
         assert response.status_code == 200, response.content
         expected = [
-            {"count": 1, "name": "high", "value": "3"},
-            {"count": 1, "name": "medium", "value": "2"},
-            {"count": 1, "name": "low", "value": "1"},
+            {"count": 1, "name": "high", "value": "high"},
+            {"count": 1, "name": "medium", "value": "medium"},
+            {"count": 1, "name": "low", "value": "low"},
         ]
         self.assert_facet(response, "device.class", expected)