Browse Source

feat(ddm): Send mri to tag values endpoint (#57095)

Matej Minar 1 year ago
parent
commit
5a3547b1b1
2 changed files with 4 additions and 5 deletions
  1. 2 2
      static/app/utils/metrics.tsx
  2. 2 3
      static/app/views/ddm/metricsExplorer.tsx

+ 2 - 2
static/app/utils/metrics.tsx

@@ -182,10 +182,10 @@ function getDateTimeParams({start, end, period}: PageFilters['datetime']) {
 type UseCase = 'sessions' | 'transactions' | 'custom';
 
 export function getUseCaseFromMri(mri?: string): UseCase {
-  if (mri?.includes('custom')) {
+  if (mri?.includes('custom/')) {
     return 'custom';
   }
-  if (mri?.includes('transactions')) {
+  if (mri?.includes('transactions/')) {
     return 'transactions';
   }
   return 'sessions';

+ 2 - 3
static/app/views/ddm/metricsExplorer.tsx

@@ -215,15 +215,14 @@ function MetricSearchBar({tags, mri, disabled, onChange, query}: MetricSearchBar
         `/organizations/${org.slug}/metrics/tags/${tag.key}/`,
         {
           query: {
-            // TODO(ddm): OrganizationMetricsTagDetailsEndpoint does not return values when metric is specified
-            // metric: mri,
+            metric: mri,
             useCase: getUseCaseFromMri(mri),
             project: selection.projects,
           },
         }
       );
 
-      return tagsValues.map(tv => tv.value);
+      return tagsValues.filter(tv => tv.value !== '').map(tv => tv.value);
     },
     [api, mri, org.slug, selection.projects]
   );