Browse Source

fix(ui): removed old feedback alert (#33352)

* fix(ui): removed old feedback alert

* fixed tests
Robin Rendle 2 years ago
parent
commit
56c3ce6781

+ 0 - 2
static/app/views/settings/account/notifications/notificationSettingsByType.tsx

@@ -15,7 +15,6 @@ import {
   NotificationSettingsByProviderObject,
   NotificationSettingsObject,
 } from 'sentry/views/settings/account/notifications/constants';
-import FeedbackAlert from 'sentry/views/settings/account/notifications/feedbackAlert';
 import {ACCOUNT_NOTIFICATION_FIELDS} from 'sentry/views/settings/account/notifications/fields';
 import {
   NOTIFICATION_SETTING_FIELDS,
@@ -321,7 +320,6 @@ class NotificationSettingsByType extends AsyncComponent<Props, State> {
         {hasSlack && unlinkedOrgs.length > 0 && (
           <UnlinkedAlert organizations={unlinkedOrgs} />
         )}
-        <FeedbackAlert />
         <Form
           saveOnBlur
           apiMethod="PUT"

+ 2 - 2
tests/js/spec/views/settings/account/notifications/notificationSettingsByType.spec.tsx

@@ -79,7 +79,7 @@ describe('NotificationSettingsByType', function () {
       [TestStubs.OrganizationIntegrations()]
     );
     const alert = wrapper.find('StyledAlert');
-    expect(alert).toHaveLength(2);
+    expect(alert).toHaveLength(1);
     const organizationSlugs = alert.at(0).find('li');
     expect(organizationSlugs).toHaveLength(1);
     expect(organizationSlugs.at(0).text()).toEqual(org.slug);
@@ -95,6 +95,6 @@ describe('NotificationSettingsByType', function () {
       [TestStubs.OrganizationIntegrations({organizationId: org.id})]
     );
     const alert = wrapper.find('StyledAlert');
-    expect(alert).toHaveLength(1);
+    expect(alert).toHaveLength(0);
   });
 });