Browse Source

ref(screens): Move module to performance dir (#69588)

Moving the screens module out of the starfish directory and into the
performance directory for the long term
Nar Saynorath 10 months ago
parent
commit
5257d43829

+ 2 - 4
static/app/routes.tsx

@@ -1610,14 +1610,12 @@ function buildRoutes() {
       <Route path="mobile/">
         <Route path="screens/">
           <IndexRoute
-            component={make(
-              () => import('sentry/views/starfish/modules/mobile/pageload')
-            )}
+            component={make(() => import('sentry/views/performance/screenload'))}
           />
           <Route
             path="spans/"
             component={make(
-              () => import('sentry/views/starfish/views/screens/screenLoadSpans')
+              () => import('sentry/views/performance/screenload/screenLoadSpans')
             )}
           />
         </Route>

+ 2 - 2
static/app/views/starfish/modules/mobile/pageload.spec.tsx → static/app/views/performance/screenload/index.spec.tsx

@@ -11,8 +11,8 @@ import useOrganization from 'sentry/utils/useOrganization';
 import usePageFilters from 'sentry/utils/usePageFilters';
 import useProjects from 'sentry/utils/useProjects';
 import {useOnboardingProject} from 'sentry/views/performance/browser/webVitals/utils/useOnboardingProject';
-import PageloadModule from 'sentry/views/starfish/modules/mobile/pageload';
-import {PLATFORM_LOCAL_STORAGE_KEY} from 'sentry/views/starfish/views/screens/platformSelector';
+import PageloadModule from 'sentry/views/performance/screenload';
+import {PLATFORM_LOCAL_STORAGE_KEY} from 'sentry/views/performance/screenload/screens/platformSelector';
 
 jest.mock('sentry/utils/useOrganization');
 jest.mock('sentry/views/performance/browser/webVitals/utils/useOnboardingProject');

+ 3 - 3
static/app/views/starfish/modules/mobile/pageload.tsx → static/app/views/performance/screenload/index.tsx

@@ -22,11 +22,11 @@ import {normalizeUrl} from 'sentry/utils/withDomainRequired';
 import {useOnboardingProject} from 'sentry/views/performance/browser/webVitals/utils/useOnboardingProject';
 import Onboarding from 'sentry/views/performance/onboarding';
 import {PlatformCompatibilityChecker} from 'sentry/views/performance/platformCompatibilityChecker';
+import {ScreensView, YAxis} from 'sentry/views/performance/screenload/screens';
+import {PlatformSelector} from 'sentry/views/performance/screenload/screens/platformSelector';
+import {isCrossPlatform} from 'sentry/views/performance/screenload/screens/utils';
 import {ReleaseComparisonSelector} from 'sentry/views/starfish/components/releaseSelector';
 import {ROUTE_NAMES} from 'sentry/views/starfish/utils/routeNames';
-import {ScreensView, YAxis} from 'sentry/views/starfish/views/screens';
-import {PlatformSelector} from 'sentry/views/starfish/views/screens/platformSelector';
-import {isCrossPlatform} from 'sentry/views/starfish/views/screens/utils';
 
 export default function PageloadModule() {
   const organization = useOrganization();

+ 12 - 12
static/app/views/starfish/views/screens/screenLoadSpans/charts.tsx → static/app/views/performance/screenload/screenLoadSpans/charts.tsx

@@ -21,29 +21,29 @@ import {MutableSearch} from 'sentry/utils/tokenizeSearch';
 import {useLocation} from 'sentry/utils/useLocation';
 import useOrganization from 'sentry/utils/useOrganization';
 import usePageFilters from 'sentry/utils/usePageFilters';
-import Chart, {ChartType} from 'sentry/views/starfish/components/chart';
-import MiniChartPanel from 'sentry/views/starfish/components/miniChartPanel';
-import {useReleaseSelection} from 'sentry/views/starfish/queries/useReleases';
-import {formatVersionAndCenterTruncate} from 'sentry/views/starfish/utils/centerTruncate';
-import {STARFISH_CHART_INTERVAL_FIDELITY} from 'sentry/views/starfish/utils/constants';
-import {appendReleaseFilters} from 'sentry/views/starfish/utils/releaseComparison';
-import {useEventsStatsQuery} from 'sentry/views/starfish/utils/useEventsStatsQuery';
 import {
   CHART_TITLES,
   OUTPUT_TYPE,
   YAXIS_COLUMNS,
-} from 'sentry/views/starfish/views/screens';
+} from 'sentry/views/performance/screenload/screens';
 import {
   DEFAULT_PLATFORM,
   PLATFORM_LOCAL_STORAGE_KEY,
   PLATFORM_QUERY_PARAM,
-} from 'sentry/views/starfish/views/screens/platformSelector';
-import {ScreensBarChart} from 'sentry/views/starfish/views/screens/screenBarChart';
-import {useTableQuery} from 'sentry/views/starfish/views/screens/screensTable';
+} from 'sentry/views/performance/screenload/screens/platformSelector';
+import {ScreensBarChart} from 'sentry/views/performance/screenload/screens/screenBarChart';
+import {useTableQuery} from 'sentry/views/performance/screenload/screens/screensTable';
 import {
   isCrossPlatform,
   transformDeviceClassEvents,
-} from 'sentry/views/starfish/views/screens/utils';
+} from 'sentry/views/performance/screenload/screens/utils';
+import Chart, {ChartType} from 'sentry/views/starfish/components/chart';
+import MiniChartPanel from 'sentry/views/starfish/components/miniChartPanel';
+import {useReleaseSelection} from 'sentry/views/starfish/queries/useReleases';
+import {formatVersionAndCenterTruncate} from 'sentry/views/starfish/utils/centerTruncate';
+import {STARFISH_CHART_INTERVAL_FIDELITY} from 'sentry/views/starfish/utils/constants';
+import {appendReleaseFilters} from 'sentry/views/starfish/utils/releaseComparison';
+import {useEventsStatsQuery} from 'sentry/views/starfish/utils/useEventsStatsQuery';
 
 export enum YAxis {
   WARM_START = 0,

+ 1 - 1
static/app/views/starfish/views/screens/screenLoadSpans/deviceClassSelector.tsx → static/app/views/performance/screenload/screenLoadSpans/deviceClassSelector.tsx

@@ -5,7 +5,7 @@ import {CompactSelect} from 'sentry/components/compactSelect';
 import {t} from 'sentry/locale';
 import {decodeScalar} from 'sentry/utils/queryString';
 import {useLocation} from 'sentry/utils/useLocation';
-import {MobileCursors} from 'sentry/views/starfish/views/screens/constants';
+import {MobileCursors} from 'sentry/views/performance/screenload/screens/constants';
 
 interface Props {
   clearSpansTableCursor?: boolean;

+ 3 - 3
static/app/views/starfish/views/screens/screenLoadSpans/eventSamples.spec.tsx → static/app/views/performance/screenload/screenLoadSpans/eventSamples.spec.tsx

@@ -4,12 +4,12 @@ import {ProjectFixture} from 'sentry-fixture/project';
 import {render, screen} from 'sentry-test/reactTestingLibrary';
 
 import usePageFilters from 'sentry/utils/usePageFilters';
-import {useReleaseSelection} from 'sentry/views/starfish/queries/useReleases';
+import {ScreenLoadEventSamples} from 'sentry/views/performance/screenload/screenLoadSpans/eventSamples';
 import {
   MobileCursors,
   MobileSortKeys,
-} from 'sentry/views/starfish/views/screens/constants';
-import {ScreenLoadEventSamples} from 'sentry/views/starfish/views/screens/screenLoadSpans/eventSamples';
+} from 'sentry/views/performance/screenload/screens/constants';
+import {useReleaseSelection} from 'sentry/views/starfish/queries/useReleases';
 
 jest.mock('sentry/utils/usePageFilters');
 jest.mock('sentry/views/starfish/queries/useReleases');

+ 8 - 8
static/app/views/starfish/views/screens/screenLoadSpans/eventSamples.tsx → static/app/views/performance/screenload/screenLoadSpans/eventSamples.tsx

@@ -10,19 +10,19 @@ import {MutableSearch} from 'sentry/utils/tokenizeSearch';
 import {useLocation} from 'sentry/utils/useLocation';
 import useOrganization from 'sentry/utils/useOrganization';
 import usePageFilters from 'sentry/utils/usePageFilters';
+import {EventSamplesTable} from 'sentry/views/performance/screenload/screenLoadSpans/eventSamplesTable';
+import {
+  DEFAULT_PLATFORM,
+  PLATFORM_LOCAL_STORAGE_KEY,
+  PLATFORM_QUERY_PARAM,
+} from 'sentry/views/performance/screenload/screens/platformSelector';
+import {useTableQuery} from 'sentry/views/performance/screenload/screens/screensTable';
+import {isCrossPlatform} from 'sentry/views/performance/screenload/screens/utils';
 import {
   PRIMARY_RELEASE_ALIAS,
   SECONDARY_RELEASE_ALIAS,
 } from 'sentry/views/starfish/components/releaseSelector';
 import {useReleaseSelection} from 'sentry/views/starfish/queries/useReleases';
-import {
-  DEFAULT_PLATFORM,
-  PLATFORM_LOCAL_STORAGE_KEY,
-  PLATFORM_QUERY_PARAM,
-} from 'sentry/views/starfish/views/screens/platformSelector';
-import {EventSamplesTable} from 'sentry/views/starfish/views/screens/screenLoadSpans/eventSamplesTable';
-import {useTableQuery} from 'sentry/views/starfish/views/screens/screensTable';
-import {isCrossPlatform} from 'sentry/views/starfish/views/screens/utils';
 
 const DEFAULT_SORT = {
   kind: 'desc',

+ 1 - 1
static/app/views/starfish/views/screens/screenLoadSpans/eventSamplesTable.spec.tsx → static/app/views/performance/screenload/screenLoadSpans/eventSamplesTable.spec.tsx

@@ -5,7 +5,7 @@ import {render, screen, userEvent} from 'sentry-test/reactTestingLibrary';
 
 import type {NewQuery} from 'sentry/types/organization';
 import EventView from 'sentry/utils/discover/eventView';
-import {EventSamplesTable} from 'sentry/views/starfish/views/screens/screenLoadSpans/eventSamplesTable';
+import {EventSamplesTable} from 'sentry/views/performance/screenload/screenLoadSpans/eventSamplesTable';
 
 describe('EventSamplesTable', function () {
   let mockLocation, mockQuery: NewQuery, mockEventView;

+ 1 - 1
static/app/views/starfish/views/screens/screenLoadSpans/eventSamplesTable.tsx → static/app/views/performance/screenload/screenLoadSpans/eventSamplesTable.tsx

@@ -26,7 +26,7 @@ import {generateProfileFlamechartRoute} from 'sentry/utils/profiling/routes';
 import {useLocation} from 'sentry/utils/useLocation';
 import useOrganization from 'sentry/utils/useOrganization';
 import type {TableColumn} from 'sentry/views/discover/table/types';
-import {DeviceClassSelector} from 'sentry/views/starfish/views/screens/screenLoadSpans/deviceClassSelector';
+import {DeviceClassSelector} from 'sentry/views/performance/screenload/screenLoadSpans/deviceClassSelector';
 
 type Props = {
   columnNameMap: Record<string, string>;

+ 1 - 1
static/app/views/starfish/views/screens/screenLoadSpans/index.spec.tsx → static/app/views/performance/screenload/screenLoadSpans/index.spec.tsx

@@ -11,7 +11,7 @@ import useOrganization from 'sentry/utils/useOrganization';
 import usePageFilters from 'sentry/utils/usePageFilters';
 import useProjects from 'sentry/utils/useProjects';
 import {useOnboardingProject} from 'sentry/views/performance/browser/webVitals/utils/useOnboardingProject';
-import ScreenLoadSpans from 'sentry/views/starfish/views/screens/screenLoadSpans';
+import ScreenLoadSpans from 'sentry/views/performance/screenload/screenLoadSpans';
 
 jest.mock('sentry/utils/useOrganization');
 jest.mock('sentry/views/performance/browser/webVitals/utils/useOnboardingProject');

Some files were not shown because too many files changed in this diff