chore(tests): Use data-test-id instead of .loading (#42257)

This test has been a bit flaky recently with the loading
some of the screenshots capturing the loading indicator.
AsyncComponent (which is inherited by the components
being screenshotted here uses LoadingIndicator in
the renderLoading method and has a dataclass-id
associated with it. Using that to ensure the loading
indicator is removed from the page instead of `.loading`

tests/acceptance/test_api.py

@@ -10,15 +10,15 @@ class ApiTokensTest(AcceptanceTestCase):
 
     def test_simple(self):
         self.browser.get(self.path)
-        self.browser.wait_until_not(".loading")
+        self.browser.wait_until_not('[data-test-id="loading-indicator"]')
         self.browser.snapshot("api tokens - no tokens")
 
         self.browser.click_when_visible('[data-test-id="create-token"]')
-        self.browser.wait_until_not(".loading")
+        self.browser.wait_until_not('[data-test-id="loading-indicator"]')
         self.browser.snapshot("api tokens - new token")
 
         self.browser.click_when_visible('[data-test-id="form-submit"]')
-        self.browser.wait_until_not(".loading")
+        self.browser.wait_until_not('[data-test-id="loading-indicator"]')
         self.browser.snapshot("api tokens - single token")
 
 
@@ -31,21 +31,21 @@ class ApiApplicationTest(AcceptanceTestCase):
 
     def test_simple(self):
         self.browser.get(self.path)
-        self.browser.wait_until_not(".loading")
+        self.browser.wait_until_not('[data-test-id="loading-indicator"]')
         self.browser.snapshot("api applications - no applications")
 
         self.browser.click_when_visible('[aria-label="Create New Application"]')
-        self.browser.wait_until_not(".loading")
+        self.browser.wait_until_not('[data-test-id="loading-indicator"]')
         self.browser.snapshot("api applications - new application")
 
         self.browser.click('[href="/settings/account/api/applications/"]')
-        self.browser.wait_until_not(".loading")
+        self.browser.wait_until_not('[data-test-id="loading-indicator"]')
         self.browser.click_when_visible('[data-test-id="toast-success"]')
         self.browser.wait_until_not('[data-test-id="toast-success"]')
         self.browser.snapshot("api applications - single application")
 
         self.browser.get(self.path)
-        self.browser.wait_until_not(".loading")
+        self.browser.wait_until_not('[data-test-id="loading-indicator"]')
         self.browser.click_when_visible('[aria-label="Remove"]')
         self.browser.wait_until_not('[data-test-id="toast-loading"]')
         self.browser.wait_until_test_id("empty-message")