Browse Source

chore(sentry apps): Adjust logs when we dont have a url (#79779)

Christinarlong 4 months ago
parent
commit
4a448fbb0d
1 changed files with 21 additions and 10 deletions
  1. 21 10
      src/sentry/sentry_apps/external_requests/select_requester.py

+ 21 - 10
src/sentry/sentry_apps/external_requests/select_requester.py

@@ -50,16 +50,27 @@ class SelectRequester:
 
 
             response = json.loads(body)
             response = json.loads(body)
         except Exception as e:
         except Exception as e:
-            logger.info(
-                "select-requester.error",
-                extra={
-                    "sentry_app_slug": self.sentry_app.slug,
-                    "install_uuid": self.install.uuid,
-                    "project_slug": self.project_slug,
-                    "error_message": str(e),
-                    "url": url,
-                },
-            )
+            extra = {
+                "sentry_app_slug": self.sentry_app.slug,
+                "install_uuid": self.install.uuid,
+                "project_slug": self.project_slug,
+                "error_message": str(e),
+            }
+
+            if not url:
+                extra.update(
+                    {
+                        "uri": self.uri,
+                        "dependent_data": self.dependent_data,
+                        "webhook_url": self.sentry_app.webhook_url,
+                    }
+                )
+                message = "select-requester.missing-url"
+            else:
+                extra.update({"url": url})
+                message = "select-requester.request-failed"
+
+            logger.info(message, extra=extra)
             raise APIError from e
             raise APIError from e
 
 
         if not self._validate_response(response):
         if not self._validate_response(response):