Fix all F841 lint violations and enforce

setup.cfg

@@ -4,7 +4,7 @@ addopts=--tb=native -p no:doctest
 norecursedirs=bin dist docs	htmlcov script hooks node_modules .* {args}
 
 [flake8]
-ignore = F999,E501,E128,E124,E402,W503,E731,F841
+ignore = F999,E501,E128,E124,E402,W503,E731
 max-line-length = 100
 exclude = .tox,.git,*/migrations/*,node_modules/*,src/sentry/static/sentry/vendor/*,docs/*
 

src/sentry/api/endpoints/group_tagkey_values.py

@@ -40,13 +40,12 @@ class GroupTagKeyValuesEndpoint(GroupEndpoint):
         else:
             lookup_key = key
 
-        try:
-            tagkey = TagKey.objects.get(
-                project=group.project_id,
-                key=lookup_key,
-                status=TagKeyStatus.VISIBLE,
-            )
-        except TagKey.DoesNotExist:
+        tagkey = TagKey.objects.filter(
+            project=group.project_id,
+            key=lookup_key,
+            status=TagKeyStatus.VISIBLE,
+        )
+        if not tagkey.exists():
             raise ResourceDoesNotExist
 
         queryset = GroupTagValue.objects.filter(

src/sentry/auth/helper.py

@@ -269,8 +269,6 @@ class AuthHelper(object):
 
     def _handle_new_user(self, identity):
         auth_provider = self.auth_provider
-        organization = self.organization
-        request = self.request
 
         user = User.objects.create(
             username=uuid4().hex,

src/sentry/event_manager.py

@@ -442,8 +442,6 @@ class EventManager(object):
             **group_kwargs
         )
 
-        using = group._state.db
-
         event.group = group
         event.group_id = group.id
         # store a reference to the group id to guarantee validation of isolation
@@ -560,7 +558,6 @@ class EventManager(object):
         )
 
     def _save_aggregate(self, event, hashes, **kwargs):
-        time_spent = event.time_spent
         project = event.project
 
         # attempt to find a matching hash

src/sentry/lang/javascript/processor.py

@@ -469,7 +469,6 @@ class SourceProcessor(object):
     def expand_frames(self, frames):
         last_state = None
         state = None
-        has_changes = False
 
         cache = self.cache
         sourcemaps = self.sourcemaps
@@ -478,7 +477,6 @@ class SourceProcessor(object):
         for frame in frames:
             errors = cache.get_errors(frame.abs_path)
             if errors:
-                has_changes = True
                 all_errors.extend(errors)
 
             source = cache.get(frame.abs_path)

src/sentry/nodestore/riak/client.py

@@ -223,7 +223,7 @@ class ConnectionManager(object):
                 conn = self.strategy.next(self.connections)
                 try:
                     return conn.urlopen(method, path, **kwargs)
-                except HTTPError as e:
+                except HTTPError:
                     self.mark_dead(conn)
 
                     if len(self.connections) == 0:

src/sentry/options/manager.py

@@ -82,7 +82,7 @@ class OptionsManager(object):
 
         try:
             self.update_cached_value(key, value)
-        except Exception as e:
+        except Exception:
             self.logger.warn(CACHE_UPDATE_ERR, key, exc_info=True)
 
     def get(self, key):
@@ -99,7 +99,7 @@ class OptionsManager(object):
 
         try:
             result = self.cache.get(cache_key)
-        except Exception as e:
+        except Exception:
             self.logger.warn(CACHE_FETCH_ERR, key, exc_info=True)
             result = None
             cache_success = False
@@ -120,7 +120,7 @@ class OptionsManager(object):
             if result is not None and cache_success:
                 try:
                     self.update_cached_value(key, result)
-                except Exception as e:
+                except Exception:
                     self.logger.warn(CACHE_UPDATE_ERR, key, exc_info=True)
 
         if not result:
@@ -145,7 +145,7 @@ class OptionsManager(object):
 
         try:
             self.cache.delete(cache_key)
-        except Exception as e:
+        except Exception:
             self.logger.warn(CACHE_UPDATE_ERR, key, exc_info=True)
 
     def update_cached_value(self, key, value):

src/sentry/plugins/interfaces/releasehook.py

@@ -34,7 +34,7 @@ class ReleaseHook(object):
             project=self.project,
             values=values,
         )
-        activity = Activity.objects.create(
+        Activity.objects.create(
             type=Activity.RELEASE,
             project=self.project,
             ident=version,

src/sentry/receivers/core.py

@@ -47,7 +47,7 @@ def create_default_projects(created_models, verbosity=2, **kwargs):
     )
 
     if settings.SENTRY_FRONTEND_PROJECT:
-        project = create_default_project(
+        create_default_project(
             id=settings.SENTRY_FRONTEND_PROJECT,
             name='Frontend',
             slug='frontend',

src/sentry/templatetags/sentry_helpers.py

@@ -321,8 +321,6 @@ def with_metadata(group_list, request):
 
 @register.inclusion_tag('sentry/plugins/bases/tag/widget.html')
 def render_tag_widget(group, tag):
-    cutoff = timezone.now() - timedelta(days=7)
-
     return {
         'title': tag['label'],
         'tag_name': tag['key'],