Browse Source

feat(api-idorslug): Rename Path paramaters to `function_id_or_slug` (#69539)

I renamed `function_slug`  to `function_id_or_slug`
Raj Joshi 10 months ago
parent
commit
41f338f5bd

+ 3 - 3
src/sentry/api/endpoints/organization_sentry_function_details.py

@@ -24,17 +24,17 @@ class OrganizationSentryFunctionDetailsEndpoint(OrganizationEndpoint):
         "PUT": ApiPublishStatus.PRIVATE,
     }
 
-    def convert_args(self, request, organization_slug, function_slug, *args, **kwargs):
+    def convert_args(self, request, organization_slug, function_id_or_slug, *args, **kwargs):
         args, kwargs = super().convert_args(request, organization_slug, *args, **kwargs)
 
         try:
             if id_or_slug_path_params_enabled(self.convert_args.__qualname__):
                 function = SentryFunction.objects.get(
-                    slug__id_or_slug=function_slug, organization=kwargs["organization"].id
+                    slug__id_or_slug=function_id_or_slug, organization=kwargs["organization"].id
                 )
             else:
                 function = SentryFunction.objects.get(
-                    slug=function_slug, organization=kwargs["organization"].id
+                    slug=function_id_or_slug, organization=kwargs["organization"].id
                 )
         except SentryFunction.DoesNotExist:
             raise Http404

+ 1 - 1
src/sentry/api/urls.py

@@ -1967,7 +1967,7 @@ ORGANIZATION_URLS = [
         name="sentry-api-0-organization-sentry-functions",
     ),
     re_path(
-        r"^(?P<organization_slug>[^\/]+)/functions/(?P<function_slug>[^\/]+)/$",
+        r"^(?P<organization_slug>[^\/]+)/functions/(?P<function_id_or_slug>[^\/]+)/$",
         OrganizationSentryFunctionDetailsEndpoint.as_view(),
         name="sentry-api-0-organization-sentry-function-details",
     ),

+ 1 - 1
src/sentry/apidocs/api_ownership_allowlist_dont_modify.py

@@ -156,7 +156,7 @@ API_OWNERSHIP_ALLOWLIST_DONT_MODIFY = [
     "/api/0/internal/packages/",
     "/api/0/users/{user_id}/notifications/{notification_type}/",
     "/api/0/projects/{organization_slug}/{project_slug}/users/{user_hash}/",
-    "/api/0/organizations/{organization_slug}/functions/{function_slug}/",
+    "/api/0/organizations/{organization_slug}/functions/{function_id_or_slug}/",
     "/api/0/projects/{organization_slug}/{project_slug}/{var}/stats/",
     "/api/0/internal/queue/tasks/",
     "/api/0/organizations/{organization_slug}/members/{member_id}/",

+ 5 - 1
src/sentry/apidocs/api_publish_status_allowlist_dont_modify.py

@@ -421,7 +421,11 @@ API_PUBLISH_STATUS_ALLOWLIST_DONT_MODIFY = {
     "/api/0/organizations/{organization_slug}/replay-count/": {"GET"},
     "/api/0/organizations/{organization_slug}/replays-events-meta/": {"GET"},
     "/api/0/organizations/{organization_slug}/functions/": {"GET", "POST"},
-    "/api/0/organizations/{organization_slug}/functions/{function_slug}/": {"DELETE", "GET", "PUT"},
+    "/api/0/organizations/{organization_slug}/functions/{function_id_or_slug}/": {
+        "DELETE",
+        "GET",
+        "PUT",
+    },
     "/api/0/organizations/{organization_slug}/scim/v2/Users/{member_id}": {"PUT"},
     "/api/0/organizations/{organization_slug}/scim/v2/Groups/{team_id}": {"PUT"},
     "/api/0/organizations/{organization_slug}/scim/v2/Schemas": {"GET"},