Browse Source

change filter to outliers (#25495)

Dora 3 years ago
parent
commit
3e8d91a96f

+ 2 - 2
static/app/utils/performance/histogram/constants.tsx

@@ -4,6 +4,6 @@ import {SelectValue} from 'app/types';
 import {DataFilter} from './types';
 
 export const FILTER_OPTIONS: SelectValue<DataFilter>[] = [
-  {label: t('Exclude Outliers'), value: 'exclude_outliers'},
-  {label: t('View All'), value: 'all'},
+  {label: t('Exclude'), value: 'exclude_outliers'},
+  {label: t('Include'), value: 'all'},
 ];

+ 1 - 1
static/app/views/performance/transactionSummary/latencyChart.tsx

@@ -283,7 +283,7 @@ export function LatencyChartControls(props: {location: Location}) {
         return (
           <React.Fragment>
             <OptionSelector
-              title={t('Filter')}
+              title={t('Outliers')}
               selected={activeFilter.value}
               options={filterOptions}
               onChange={handleFilterChange}

+ 1 - 1
static/app/views/performance/transactionVitals/content.tsx

@@ -100,7 +100,7 @@ class VitalsContent extends React.Component<Props, State> {
                       onSearch={this.handleSearch}
                     />
                     <DropdownControl
-                      buttonProps={{prefix: t('Filter')}}
+                      buttonProps={{prefix: t('Outliers')}}
                       label={activeFilter.label}
                     >
                       {FILTER_OPTIONS.map(({label, value}) => (

+ 2 - 4
tests/acceptance/test_performance_summary.py

@@ -168,10 +168,8 @@ class PerformanceSummaryTest(AcceptanceTestCase, SnubaTestCase):
 
             self.browser.snapshot("real user monitoring - exclude outliers")
 
-            self.browser.element(
-                xpath="//button//span[contains(text(), 'Exclude Outliers')]"
-            ).click()
-            self.browser.element(xpath="//li//span[contains(text(), 'View All')]").click()
+            self.browser.element(xpath="//button//span[contains(text(), 'Exclude')]").click()
+            self.browser.element(xpath="//li//span[contains(text(), 'Include')]").click()
             self.page.wait_until_loaded()
 
             self.browser.snapshot("real user monitoring - view all data")