Browse Source

feat(perf): Remove implicit filters for the transaction search experiment (#35629)

Dameli Ushbayeva 2 years ago
parent
commit
3c87f2e1df
1 changed files with 5 additions and 5 deletions
  1. 5 5
      static/app/views/performance/data.tsx

+ 5 - 5
static/app/views/performance/data.tsx

@@ -432,7 +432,7 @@ function generateGenericPerformanceEventView(
   const conditions = new MutableSearch(searchQuery);
 
   // This is not an override condition since we want the duration to appear in the search bar as a default.
-  if (shouldAddDefaultConditions(location) || withStaticFilters) {
+  if (shouldAddDefaultConditions(location) && !withStaticFilters) {
     conditions.setFilterValues('transaction.duration', ['<15m']);
   }
 
@@ -509,7 +509,7 @@ function generateBackendPerformanceEventView(
   const conditions = new MutableSearch(searchQuery);
 
   // This is not an override condition since we want the duration to appear in the search bar as a default.
-  if (shouldAddDefaultConditions(location) || withStaticFilters) {
+  if (shouldAddDefaultConditions(location) && !withStaticFilters) {
     conditions.setFilterValues('transaction.duration', ['<15m']);
   }
 
@@ -590,7 +590,7 @@ function generateMobilePerformanceEventView(
   const conditions = new MutableSearch(searchQuery);
 
   // This is not an override condition since we want the duration to appear in the search bar as a default.
-  if (shouldAddDefaultConditions(location) || withStaticFilters) {
+  if (shouldAddDefaultConditions(location) && !withStaticFilters) {
     conditions.setFilterValues('transaction.duration', ['<15m']);
   }
 
@@ -657,7 +657,7 @@ function generateFrontendPageloadPerformanceEventView(
   const conditions = new MutableSearch(searchQuery);
 
   // This is not an override condition since we want the duration to appear in the search bar as a default.
-  if (shouldAddDefaultConditions(location) || withStaticFilters) {
+  if (shouldAddDefaultConditions(location) && !withStaticFilters) {
     conditions.setFilterValues('transaction.duration', ['<15m']);
   }
 
@@ -725,7 +725,7 @@ function generateFrontendOtherPerformanceEventView(
   const conditions = new MutableSearch(searchQuery);
 
   // This is not an override condition since we want the duration to appear in the search bar as a default.
-  if (shouldAddDefaultConditions(location) || withStaticFilters) {
+  if (shouldAddDefaultConditions(location) && !withStaticFilters) {
     conditions.setFilterValues('transaction.duration', ['<15m']);
   }