Browse Source

chore(features) Remove requires_snuba tuple (#75173)

This list came from a time when snuba was optional for local
development. We are long past the point of being able to run sentry
without snuba and this list is incomplete and unmaintained.
Mark Story 7 months ago
parent
commit
3a31bd7d3d
2 changed files with 0 additions and 37 deletions
  1. 0 14
      src/sentry/features/__init__.py
  2. 0 23
      src/sentry/runner/initializer.py

+ 0 - 14
src/sentry/features/__init__.py

@@ -48,26 +48,12 @@ from .manager import *  # NOQA
 #
 #   NOTE: The actor kwarg should be passed when it's expected that the handler
 #         needs context of the user.
-#
-#   NOTE: Features that require Snuba to function, add to the
-#         `requires_snuba` tuple.
 
 default_manager = FeatureManager()  # NOQA
 
 register_permanent_features(default_manager)
 register_temporary_features(default_manager)
 
-# This is a gross hardcoded list, but there's no
-# other sensible way to manage this right now without augmenting
-# features themselves in the manager with detections like this.
-requires_snuba = (
-    "organizations:discover",
-    "organizations:global-views",
-    "organizations:incidents",
-    "organizations:minute-resolution-sessions",
-    "organizations:performance-view",
-)
-
 # expose public api
 add = default_manager.add
 entity_features = default_manager.entity_features

+ 0 - 23
src/sentry/runner/initializer.py

@@ -656,29 +656,6 @@ def validate_snuba() -> None:
     if has_all_snuba_required_backends and eventstream_is_snuba:
         return
 
-    from sentry.features import requires_snuba as snuba_features
-
-    snuba_enabled_features = set()
-
-    for feature in snuba_features:
-        if settings.SENTRY_FEATURES.get(feature, False):
-            snuba_enabled_features.add(feature)
-
-    if snuba_enabled_features and not eventstream_is_snuba:
-        show_big_error(
-            """
-You have features enabled which require Snuba,
-but you don't have any Snuba compatible configuration.
-
-Features you have enabled:
-%s
-
-See: https://github.com/getsentry/snuba#sentry--snuba
-"""
-            % "\n".join(snuba_enabled_features)
-        )
-        raise ConfigurationError("Cannot continue without Snuba configured.")
-
     if not eventstream_is_snuba:
         show_big_error(
             """