ref(js): Remove unnecessary await in api helpers (#35293)

These all already return Promise objects

static/app/actionCreators/events.tsx

@@ -164,7 +164,7 @@ export type Tag = {
 /**
  * Fetches tag facets for a query
  */
-export async function fetchTagFacets(
+export function fetchTagFacets(
   api: Client,
   orgSlug: string,
   query: EventQuery
@@ -181,7 +181,7 @@ export async function fetchTagFacets(
 /**
  * Fetches total count of events for a given query
  */
-export async function fetchTotalCount(
+export function fetchTotalCount(
   api: Client,
   orgSlug: String,
   query: EventQuery & LocationQuery

static/app/actionCreators/incident.tsx

@@ -6,11 +6,7 @@ import {NoteType} from 'sentry/types/alerts';
 /**
  * Fetches a list of activities for an incident
  */
-export async function fetchIncidentActivities(
-  api: Client,
-  orgId: string,
-  alertId: string
-) {
+export function fetchIncidentActivities(api: Client, orgId: string, alertId: string) {
   return api.requestPromise(`/organizations/${orgId}/incidents/${alertId}/activity/`);
 }
 

static/app/actionCreators/organization.tsx

@@ -110,7 +110,7 @@ async function fetchProjectsAndTeams(
  * @param silent Should we silently update the organization (do not clear the
  *               current organization in the store)
  */
-export async function fetchOrganizationDetails(
+export function fetchOrganizationDetails(
   api: Client,
   slug: string,
   silent: boolean,

static/app/utils/discover/genericDiscoverQuery.tsx

@@ -329,7 +329,7 @@ export function GenericDiscoverQuery<T, P>(props: OuterProps<T, P>) {
 
 export type DiscoverQueryRequestParams = Partial<EventQuery & LocationQuery>;
 
-export async function doDiscoverQuery<T>(
+export function doDiscoverQuery<T>(
   api: Client,
   url: string,
   params: DiscoverQueryRequestParams

static/app/utils/metrics/metricsProvider.tsx

@@ -9,7 +9,7 @@ import useApi from 'sentry/utils/useApi';
 
 import {MetricsContext, MetricsContextValue} from './metricsContext';
 
-async function fetchMetricMetas(
+function fetchMetricMetas(
   api: Client,
   organization: Organization,
   projects?: number[]
@@ -21,7 +21,7 @@ async function fetchMetricMetas(
   });
 }
 
-async function fetchMetricTags(
+function fetchMetricTags(
   api: Client,
   organization: Organization,
   projects?: number[],

static/app/views/alerts/rules/metric/actions.tsx

@@ -14,7 +14,7 @@ function isSavedRule(rule: MetricRule): rule is SavedMetricRule {
  * @param rule Saved or Unsaved Metric Rule
  * @param query Query parameters for the request eg - referrer
  */
-export async function addOrUpdateRule(
+export function addOrUpdateRule(
   api: Client,
   orgId: string,
   projectId: string,