Browse Source

ref(replays): remove user fields from subquery eligibility (#50615)

Helps with https://github.com/getsentry/sentry/issues/48957 -- this will
re-allow user fields to work correctly. We solved OOM problems with
https://github.com/getsentry/snuba/pull/4232, so it's unlikely this
would result in bad queries.



Note that there is a better fix which is doing a distinct query instead,
which we would need to add another clickhouse query option for, but this
would work jsut fine.
Josh Ferge 1 year ago
parent
commit
35828ee70d
1 changed files with 7 additions and 6 deletions
  1. 7 6
      src/sentry/replays/query.py

+ 7 - 6
src/sentry/replays/query.py

@@ -27,7 +27,6 @@ from sentry.api.event_search import ParenExpression, SearchConfig, SearchFilter
 from sentry.models.organization import Organization
 from sentry.replays.lib.query import (
     InvalidField,
-    IPAddress,
     ListField,
     Number,
     QueryConfig,
@@ -609,11 +608,6 @@ class ReplaySubqueryConfig(QueryConfig):
     sdk_name = String(field_alias="sdk.name")
     sdk_version = String(field_alias="sdk.version")
     started_at = String(is_filterable=False)
-    user = String(field_alias="user", query_alias="user_name")
-    user_email = String(field_alias="user.email")
-    user_id = String(field_alias="user.id")
-    user_ip_address = IPAddress(field_alias="user.ip", query_alias="ip_address_v4")
-    user_name = String(field_alias="user.username")
 
     tags = Tag(field_alias="*", tag_key_alias="tags.key", tag_value_alias="tags.value")
 
@@ -644,6 +638,13 @@ class ReplaySubqueryConfig(QueryConfig):
     urls = InvalidField(query_alias="urls_sorted")
     url = InvalidField(query_alias="urls_sorted")
 
+    # User fields, removing from subquery eligibility for now.
+    user = InvalidField(field_alias="user", query_alias="user_name")
+    user_email = InvalidField(field_alias="user.email")
+    user_id = InvalidField(field_alias="user.id")
+    user_name = InvalidField(field_alias="user.username")
+    user_ip_address = InvalidField(field_alias="user.ip", query_alias="ip_address_v4")
+
 
 # Pagination.