Browse Source

ref: unify signature of is_configured (#74893)

fixes errors pointed out by upgrading mypy to 1.11
<!-- Describe your PR here. -->
anthony sottile 7 months ago
parent
commit
3411112ba1

+ 4 - 4
src/sentry/plugins/bases/issue.py

@@ -55,7 +55,7 @@ class IssueTrackingPlugin(Plugin):
     def _get_group_title(self, request: Request, group, event):
         return event.title
 
-    def is_configured(self, request: Request, project, **kwargs):
+    def is_configured(self, project) -> bool:
         raise NotImplementedError
 
     def get_auth_for_user(self, user, **kwargs) -> RpcUserSocialAuth:
@@ -176,7 +176,7 @@ class IssueTrackingPlugin(Plugin):
 
     def view(self, request: Request, group, **kwargs):
         has_auth_configured = self.has_auth_configured()
-        if not (has_auth_configured and self.is_configured(project=group.project, request=request)):
+        if not (has_auth_configured and self.is_configured(project=group.project)):
             if self.auth_provider:
                 required_auth_settings = settings.AUTH_PROVIDERS[self.auth_provider]
             else:
@@ -290,7 +290,7 @@ class IssueTrackingPlugin(Plugin):
         return self.render(self.create_issue_template, context)
 
     def actions(self, request: Request, group, action_list, **kwargs):
-        if not self.is_configured(request=request, project=group.project):
+        if not self.is_configured(project=group.project):
             return action_list
         prefix = self.get_conf_key()
         if not GroupMeta.objects.get_value(group, "%s:tid" % prefix, None):
@@ -302,7 +302,7 @@ class IssueTrackingPlugin(Plugin):
         return action_list
 
     def tags(self, request: Request, group, tag_list, **kwargs):
-        if not self.is_configured(request=request, project=group.project):
+        if not self.is_configured(project=group.project):
             return tag_list
 
         prefix = self.get_conf_key()

+ 4 - 4
src/sentry/plugins/bases/issue2.py

@@ -79,7 +79,7 @@ class IssueTrackingPlugin2(Plugin):
     def get_group_title(self, request: Request, group, event):
         return event.title
 
-    def is_configured(self, request: Request, project, **kwargs):
+    def is_configured(self, project) -> bool:
         raise NotImplementedError
 
     def get_group_urls(self):
@@ -371,7 +371,7 @@ class IssueTrackingPlugin2(Plugin):
         return Response({"message": "No issues to unlink."}, status=400)
 
     def plugin_issues(self, request: Request, group, plugin_issues, **kwargs) -> None:
-        if not self.is_configured(request=request, project=group.project):
+        if not self.is_configured(project=group.project):
             return
 
         item = {
@@ -398,7 +398,7 @@ class IssueTrackingPlugin2(Plugin):
 
     def check_config_and_auth(self, request: Request, group):
         has_auth_configured = self.has_auth_configured()
-        if not (has_auth_configured and self.is_configured(project=group.project, request=request)):
+        if not (has_auth_configured and self.is_configured(project=group.project)):
             if self.auth_provider:
                 required_auth_settings = settings.AUTH_PROVIDERS[self.auth_provider]
             else:
@@ -421,7 +421,7 @@ class IssueTrackingPlugin2(Plugin):
 
     # TODO: should we get rid of this (move it to react?)
     def tags(self, request: Request, group, tag_list, **kwargs):
-        if not self.is_configured(request=request, project=group.project):
+        if not self.is_configured(project=group.project):
             return tag_list
 
         issue = self.build_issue(group)

+ 1 - 1
src/sentry/plugins/bases/notify.py

@@ -160,7 +160,7 @@ class NotificationPlugin(Plugin):
             project=group.project, key=self.get_conf_key(), limit=10
         )
 
-    def is_configured(self, project):
+    def is_configured(self, project) -> bool:
         raise NotImplementedError
 
     def should_notify(self, group, event):

+ 1 - 1
src/sentry/plugins/examples/issue_tracking.py

@@ -18,7 +18,7 @@ class ExampleIssueTrackingPlugin(IssuePlugin2):
     conf_title = title
     conf_key = "example-issue"
 
-    def is_configured(self, request: Request, project, **kwargs):
+    def is_configured(self, project) -> bool:
         return bool(self.get_option("repo", project))
 
     def get_new_issue_fields(self, request: Request, group, event, **kwargs):

+ 1 - 1
src/sentry/plugins/sentry_webhooks/plugin.py

@@ -82,7 +82,7 @@ class WebHooksPlugin(notify.NotificationPlugin):
         )
     ]
 
-    def is_configured(self, project, **kwargs):
+    def is_configured(self, project) -> bool:
         return bool(self.get_option("urls", project))
 
     def get_config(self, project, user=None, initial=None, add_additional_fields: bool = False):

+ 1 - 1
src/sentry/tasks/integrations/migrate_issues.py

@@ -32,7 +32,7 @@ def migrate_issues(integration_id: int, organization_id: int) -> None:
     for project in Project.objects.filter(organization_id=organization_id):
         plugin = None
         for p in plugins.for_project(project):
-            if isinstance(p, JiraPlugin) and p.is_configured(None, project):
+            if isinstance(p, JiraPlugin) and p.is_configured(project):
                 plugin = p
                 break
 

+ 1 - 1
src/sentry_plugins/asana/plugin.py

@@ -53,7 +53,7 @@ class AsanaPlugin(CorePluginMixin, IssuePlugin2):
             )
         ]
 
-    def is_configured(self, request: Request, project, **kwargs):
+    def is_configured(self, project) -> bool:
         return bool(self.get_option("workspace", project))
 
     def has_workspace_access(self, workspace, choices):

+ 1 - 1
src/sentry_plugins/bitbucket/plugin.py

@@ -72,7 +72,7 @@ class BitbucketPlugin(BitbucketMixin, IssuePlugin2):
     def get_url_module(self):
         return "sentry_plugins.bitbucket.urls"
 
-    def is_configured(self, request: Request, project, **kwargs):
+    def is_configured(self, project) -> bool:
         return bool(self.get_option("repo", project))
 
     def get_new_issue_fields(self, request: Request, group, event, **kwargs):

+ 1 - 1
src/sentry_plugins/github/plugin.py

@@ -102,7 +102,7 @@ class GitHubPlugin(GitHubMixin, IssuePlugin2):
     def get_url_module(self):
         return "sentry_plugins.github.urls"
 
-    def is_configured(self, request: Request, project, **kwargs):
+    def is_configured(self, project) -> bool:
         return bool(self.get_option("repo", project))
 
     def get_new_issue_fields(self, request: Request, group, event, **kwargs):

+ 1 - 1
src/sentry_plugins/gitlab/plugin.py

@@ -32,7 +32,7 @@ class GitLabPlugin(CorePluginMixin, IssuePlugin2):
         ),
     ]
 
-    def is_configured(self, request: Request, project, **kwargs):
+    def is_configured(self, project) -> bool:
         return bool(
             self.get_option("gitlab_repo", project)
             and self.get_option("gitlab_token", project)

Some files were not shown because too many files changed in this diff