Browse Source

fix(dashboards): Display an error message when widget validation fails on clicking add widget (#44376)

Displays an error message when a widget fails validation on clicking
add/update widget.
edwardgou-sentry 2 years ago
parent
commit
33f0ad3b69
1 changed files with 2 additions and 1 deletions
  1. 2 1
      static/app/views/dashboards/widgetBuilder/widgetBuilder.tsx

+ 2 - 1
static/app/views/dashboards/widgetBuilder/widgetBuilder.tsx

@@ -7,7 +7,7 @@ import omit from 'lodash/omit';
 import set from 'lodash/set';
 import set from 'lodash/set';
 
 
 import {validateWidget} from 'sentry/actionCreators/dashboards';
 import {validateWidget} from 'sentry/actionCreators/dashboards';
-import {addSuccessMessage} from 'sentry/actionCreators/indicator';
+import {addErrorMessage, addSuccessMessage} from 'sentry/actionCreators/indicator';
 import {fetchOrgMembers} from 'sentry/actionCreators/members';
 import {fetchOrgMembers} from 'sentry/actionCreators/members';
 import {loadOrganizationTags} from 'sentry/actionCreators/tags';
 import {loadOrganizationTags} from 'sentry/actionCreators/tags';
 import * as Layout from 'sentry/components/layouts/thirds';
 import * as Layout from 'sentry/components/layouts/thirds';
@@ -811,6 +811,7 @@ function WidgetBuilder({
         loading: false,
         loading: false,
         errors: {...state.errors, ...mapErrors(error?.responseJSON ?? {}, {})},
         errors: {...state.errors, ...mapErrors(error?.responseJSON ?? {}, {})},
       });
       });
+      addErrorMessage(t('Unable to save widget'));
       return false;
       return false;
     }
     }
   }
   }