fix(ui): Remove unnecessary condition in query string for transaction summaries (#31185)

* fix(ui): Remove unnecessary condition in query string for transaction summaries

When drilling down from the Performance landing page to transaction summary page, event.type:transaction
gets added to the query, but this is unnecessary since it is already implied. This change removes this
from the query string.

Fixes VIS-1308

* Update test to not expect event.type:transaction in query string

* Remove event.type:transaction from query string in content.spec.jsx test assertion

static/app/views/performance/transactionSummary/utils.tsx

@@ -25,6 +25,7 @@ export function generateTransactionSummaryRoute({orgSlug}: {orgSlug: String}): s
 function cleanTransactionSummaryFilter(query: string): string {
   const filterParams = new MutableSearch(query);
   filterParams.removeFilter('transaction');
+  filterParams.removeFilter('event.type');
   return filterParams.formatString();
 }
 

tests/js/spec/views/performance/content.spec.jsx

@@ -385,7 +385,7 @@ describe('Performance > Content', function () {
       expect.objectContaining({
         query: expect.objectContaining({
           transaction: '/apple/cart',
-          query: 'sentry:yes transaction.duration:<15m event.type:transaction',
+          query: 'sentry:yes transaction.duration:<15m',
         }),
       })
     );

tests/js/spec/views/performance/table.spec.jsx

@@ -181,7 +181,7 @@ describe('Performance > Table', function () {
         statsPeriod: '14d',
         start: '2019-10-01T00:00:00',
         end: '2019-10-02T00:00:00',
-        query: 'event.type:transaction', // drops 'transaction:/api*' from the query
+        query: '', // drops 'transaction:/api*' and 'event.type:transaction' from the query
         unselectedSeries: 'p100()',
         showTransactions: undefined,
         display: undefined,