Browse Source

feat(ci): Actually fix `action-visual-snapshot` (#42522)

Follow-up to https://github.com/getsentry/sentry/pull/42262 and the
revert to https://github.com/getsentry/sentry/pull/42430

Fix is https://github.com/getsentry/action-visual-snapshot/pull/97

> GitHub API treats `head_sha` with explicit `undefined` value
differently than when `head_sha` does not exist in object. Want the
latter.
Billy Vong 2 years ago
parent
commit
3150341908
2 changed files with 5 additions and 5 deletions
  1. 4 4
      .github/workflows/acceptance.yml
  2. 1 1
      .github/workflows/visual-diff.yml

+ 4 - 4
.github/workflows/acceptance.yml

@@ -103,7 +103,7 @@ jobs:
           css-path: src/sentry/static/sentry/dist/entrypoints/sentry.css
 
       - name: Save snapshots
-        uses: getsentry/action-visual-snapshot@5811b6c34e1ec3b9fc30613d4b55ef740fec6086
+        uses: getsentry/action-visual-snapshot@d08945864bd75129863897062b8c1687f1600a2d
         with:
           save-only: true
           snapshot-path: .artifacts/visual-snapshots
@@ -180,7 +180,7 @@ jobs:
           PYTEST_SNAPSHOTS_DIR: ${{ steps.setup.outputs.acceptance-dir }}
 
       - name: Save snapshots
-        uses: getsentry/action-visual-snapshot@5811b6c34e1ec3b9fc30613d4b55ef740fec6086
+        uses: getsentry/action-visual-snapshot@d08945864bd75129863897062b8c1687f1600a2d
         with:
           save-only: true
           snapshot-path: .artifacts/visual-snapshots
@@ -243,7 +243,7 @@ jobs:
           PYTEST_SNAPSHOTS_DIR: ${{ steps.setup.outputs.acceptance-dir }}
 
       - name: Save snapshots
-        uses: getsentry/action-visual-snapshot@5811b6c34e1ec3b9fc30613d4b55ef740fec6086
+        uses: getsentry/action-visual-snapshot@d08945864bd75129863897062b8c1687f1600a2d
         with:
           save-only: true
           snapshot-path: .artifacts/visual-snapshots
@@ -269,7 +269,7 @@ jobs:
           echo "One of the dependent jobs have failed. You may need to re-run it." && exit 1
 
       - name: Diff snapshots
-        uses: getsentry/action-visual-snapshot@5811b6c34e1ec3b9fc30613d4b55ef740fec6086
+        uses: getsentry/action-visual-snapshot@d08945864bd75129863897062b8c1687f1600a2d
         # Run this step only if there are acceptance related code changes
         # Forks are handled in visual-diff.yml
         if: needs.files-changed.outputs.acceptance == 'true' && github.event.pull_request.head.repo.full_name == 'getsentry/sentry'

+ 1 - 1
.github/workflows/visual-diff.yml

@@ -38,7 +38,7 @@ jobs:
     steps:
       - name: Diff snapshots
         id: visual-snapshots-diff
-        uses: getsentry/action-visual-snapshot@5811b6c34e1ec3b9fc30613d4b55ef740fec6086
+        uses: getsentry/action-visual-snapshot@d08945864bd75129863897062b8c1687f1600a2d
         with:
           api-token: ${{ secrets.VISUAL_SNAPSHOT_SECRET }}
           gcs-bucket: 'sentry-visual-snapshots'