ref(pyupgrade): set and dict literals for tests/ (#23560)

tests/sentry/api/bases/test_organization.py

@@ -164,7 +164,7 @@ class GetProjectIdsTest(BaseOrganizationEndpointTest):
             self.org,
             include_all_accessible=include_all_accessible,
         )
-        assert set([p.id for p in expected_projects]) == set(p.id for p in result)
+        assert {p.id for p in expected_projects} == {p.id for p in result}
 
     def test_no_ids_no_teams(self):
         # Should get nothing if not part of the org
@@ -267,7 +267,7 @@ class GetEnvironmentsTest(BaseOrganizationEndpointTest):
         if env_names:
             request_args["environment"] = env_names
         result = self.endpoint.get_environments(self.build_request(**request_args), self.org)
-        assert set([e.name for e in expected_envs]) == set([e.name for e in result])
+        assert {e.name for e in expected_envs} == {e.name for e in result}
 
     def test_no_params(self):
         self.run_test([])
@@ -323,11 +323,11 @@ class GetFilterParamsTest(BaseOrganizationEndpointTest):
             date_filter_optional=date_filter_optional,
         )
 
-        assert set([p.id for p in expected_projects]) == set(result["project_id"])
+        assert {p.id for p in expected_projects} == set(result["project_id"])
         assert expected_start == result["start"]
         assert expected_end == result["end"]
         if expected_envs:
-            assert set([e.name for e in expected_envs]) == set(result["environment"])
+            assert {e.name for e in expected_envs} == set(result["environment"])
         else:
             assert "environment" not in result
 

tests/sentry/api/endpoints/test_dif_assemble.py

@@ -129,7 +129,7 @@ class DifAssembleEndpoint(APITestCase):
 
         assert response.status_code == 200, response.content
         assert response.data[not_found_checksum]["state"] == ChunkFileState.NOT_FOUND
-        assert set(response.data[not_found_checksum]["missingChunks"]) == set([not_found_checksum])
+        assert set(response.data[not_found_checksum]["missingChunks"]) == {not_found_checksum}
 
     @patch("sentry.tasks.assemble.assemble_dif")
     def test_assemble(self, mock_assemble_dif):

tests/sentry/api/endpoints/test_group_tags.py

@@ -62,7 +62,7 @@ class GroupTagsTest(APITestCase, SnubaTestCase):
 
         assert data[0]["key"] == "foo"
         assert len(data[0]["topValues"]) == 2
-        assert set(v["value"] for v in data[0]["topValues"]) == set(["bar", "quux"])
+        assert {v["value"] for v in data[0]["topValues"]} == {"bar", "quux"}
 
         assert data[1]["key"] == "release"
         assert len(data[1]["topValues"]) == 1
@@ -90,9 +90,7 @@ class GroupTagsTest(APITestCase, SnubaTestCase):
         response = self.client.get(url, {"environment": "prod"}, format="json")
         assert response.status_code == 200
         assert len(response.data) == 4
-        assert set([tag["key"] for tag in response.data]) == set(
-            ["foo", "biz", "environment", "level"]
-        )
+        assert {tag["key"] for tag in response.data} == {"foo", "biz", "environment", "level"}
 
     def test_multi_env(self):
         min_ago = before_now(minutes=1)
@@ -123,4 +121,4 @@ class GroupTagsTest(APITestCase, SnubaTestCase):
             f"{url}?environment={env.name}&environment={env2.name}", format="json"
         )
         assert response.status_code == 200
-        assert set([tag["key"] for tag in response.data]) >= set(["biz", "environment", "foo"])
+        assert {tag["key"] for tag in response.data} >= {"biz", "environment", "foo"}

tests/sentry/api/endpoints/test_organization_details.py

@@ -727,7 +727,7 @@ class OrganizationDeleteTest(APITestCase):
 
         # Make sure we've emailed all owners
         assert len(mail.outbox) == len(owners)
-        owner_emails = set(o.email for o in owners)
+        owner_emails = {o.email for o in owners}
         for msg in mail.outbox:
             assert "Deletion" in msg.subject
             assert len(msg.to) == 1

tests/sentry/api/endpoints/test_organization_release_assemble.py

@@ -65,7 +65,7 @@ class OrganizationReleaseAssembleTest(APITestCase):
 
         assert response.status_code == 200, response.content
         assert response.data["state"] == ChunkFileState.CREATED
-        assert set(response.data["missingChunks"]) == set([])
+        assert set(response.data["missingChunks"]) == set()
 
         mock_assemble_artifacts.apply_async.assert_called_once_with(
             kwargs={

tests/sentry/api/endpoints/test_organization_user_issues_search.py

@@ -84,6 +84,7 @@ class OrganizationUserIssuesSearchTest(APITestCase, SnubaTestCase):
         # now result should include results from team2/project2
         assert response.status_code == 200
         assert len(response.data) == 2
-        assert set([r["project"]["slug"] for r in response.data]) == set(
-            [self.project1.slug, self.project2.slug]
-        )
+        assert {r["project"]["slug"] for r in response.data} == {
+            self.project1.slug,
+            self.project2.slug,
+        }

tests/sentry/api/endpoints/test_organization_user_reports.py

@@ -68,8 +68,8 @@ class OrganizationUserReportListTest(APITestCase, SnubaTestCase):
         response = self.get_response(self.project_1.organization.slug, **params)
 
         assert response.status_code == 200, response.content
-        result_ids = set(report["id"] for report in response.data)
-        assert result_ids == set(str(report.id) for report in expected)
+        result_ids = {report["id"] for report in response.data}
+        assert result_ids == {str(report.id) for report in expected}
 
     def test_no_filters(self):
         self.run_test([self.report_1, self.report_2])

tests/sentry/api/endpoints/test_project_issues_resolved_in_release.py

@@ -55,7 +55,7 @@ class ProjectIssuesResolvedInReleaseEndpointTest(APITestCase):
         response = self.get_valid_response(self.org.slug, self.project.slug, self.release.version)
         assert len(response.data) == len(expected_groups)
         expected = set(map(str, [g.id for g in expected_groups]))
-        assert set([item["id"] for item in response.data]) == expected
+        assert {item["id"] for item in response.data} == expected
 
     def test_shows_issues_from_groupresolution(self):
         """

tests/sentry/api/endpoints/test_project_user_reports.py

@@ -146,7 +146,7 @@ class ProjectUserReportListTest(APITestCase, SnubaTestCase):
 
         assert response.status_code == 200, response.content
         assert len(response.data) == 2
-        assert set([report["eventID"] for report in response.data]) == set(["a" * 32, "b" * 32])
+        assert {report["eventID"] for report in response.data} == {"a" * 32, "b" * 32}
 
         # Invalid environment
         response = self.client.get(base_url + "?environment=invalid_env")

tests/sentry/api/endpoints/test_relay_projectconfigs.py

@@ -109,7 +109,7 @@ def test_internal_relays_should_receive_minimal_configs_if_they_do_not_explicitl
 
     # Sweeping assertion that we do not have any snake_case in that config.
     # Might need refining.
-    assert not set(x for x in _get_all_keys(result) if "-" in x or "_" in x)
+    assert not {x for x in _get_all_keys(result) if "-" in x or "_" in x}
 
     cfg = safe.get_path(result, "configs", str(default_project.id))
     assert safe.get_path(cfg, "config", "filterSettings") is None
@@ -126,7 +126,7 @@ def test_internal_relays_should_receive_full_configs(
 
     # Sweeping assertion that we do not have any snake_case in that config.
     # Might need refining.
-    assert not set(x for x in _get_all_keys(result) if "-" in x or "_" in x)
+    assert not {x for x in _get_all_keys(result) if "-" in x or "_" in x}
 
     cfg = safe.get_path(result, "configs", str(default_project.id))
     assert safe.get_path(cfg, "disabled") is False