Browse Source

fix(tagstore): Ensure environment_id is int or None not empty list

Jess MacQueen 6 years ago
parent
commit
28bcf98f9b
2 changed files with 2 additions and 2 deletions
  1. 1 1
      src/sentry/tagstore/base.py
  2. 1 1
      src/sentry/tagstore/v2/backend.py

+ 1 - 1
src/sentry/tagstore/base.py

@@ -431,7 +431,7 @@ class TagStorage(Service):
             project_id, group_id, environment_ids, keys=keys
         )
 
-        environment_id = environment_ids and environment_ids[0]
+        environment_id = environment_ids[0] if environment_ids else None
         for tk in tag_keys:
             tk.top_values = self.get_top_group_tag_values(
                 project_id, group_id, environment_id, tk.key, limit=value_limit)

+ 1 - 1
src/sentry/tagstore/v2/backend.py

@@ -516,7 +516,7 @@ class V2TagStorage(TagStorage):
         if environment_ids and len(environment_ids) > 1:
             raise NotImplementedError
 
-        environment_id = environment_ids and environment_ids[0]
+        environment_id = environment_ids[0] if environment_ids else None
 
         qs = models.GroupTagKey.objects.select_related('_key').filter(
             project_id=project_id,