Browse Source

fix: Use event.dateReceived as fallback for relative times (#28533)

Alberto Leal 3 years ago
parent
commit
2849ae5cbb

+ 1 - 1
static/app/components/events/contexts/app/getAppKnownDataDetails.tsx

@@ -27,7 +27,7 @@ function getAppKnownDataDetails(
       return {
         subject: t('Start Time'),
         value: getRelativeTimeFromEventDateCreated(
-          event.dateCreated,
+          event.dateCreated ? event.dateCreated : event.dateReceived,
           data.app_start_time
         ),
       };

+ 4 - 1
static/app/components/events/contexts/device/getDeviceKnownDataDetails.tsx

@@ -137,7 +137,10 @@ function getDeviceKnownDataDetails(
     case DeviceKnownDataType.BOOT_TIME:
       return {
         subject: t('Boot Time'),
-        value: getRelativeTimeFromEventDateCreated(event.dateCreated, data.boot_time),
+        value: getRelativeTimeFromEventDateCreated(
+          event.dateCreated ? event.dateCreated : event.dateReceived,
+          data.boot_time
+        ),
       };
     case DeviceKnownDataType.TIMEZONE:
       return {

+ 1 - 1
static/app/components/events/eventTagsAndScreenshot/screenshot/modal.tsx

@@ -55,7 +55,7 @@ function Modal({
                   })}
                 />
                 {getRelativeTimeFromEventDateCreated(
-                  event.dateCreated,
+                  event.dateCreated ? event.dateCreated : event.dateReceived,
                   dateCreated,
                   false
                 )}

+ 2 - 2
static/app/types/event.tsx

@@ -176,7 +176,6 @@ type EventBase = {
   eventID: string;
   title: string;
   culprit: string;
-  dateCreated: string;
   dist: string | null;
   metadata: EventMetadata;
   contexts: EventContexts;
@@ -200,10 +199,11 @@ type EventBase = {
   nextEventID?: string;
   groupID?: string;
   context?: Record<string, any>;
+  dateCreated?: string;
   device?: Record<string, any>;
   packages?: Record<string, string>;
   platform?: PlatformType;
-  dateReceived?: string;
+  dateReceived: string;
   endTimestamp?: number;
   userReport?: any;
   sdk?: {

+ 8 - 1
static/app/views/organizationGroupDetails/grouping/newIssue.tsx

@@ -28,7 +28,14 @@ function NewIssue({sampleEvent, eventCount, organization}: Props) {
         <ExtraInfo>
           <TimeWrapper>
             <StyledIconClock size="11px" />
-            <TimeSince date={sampleEvent.dateCreated} suffix={t('old')} />
+            <TimeSince
+              date={
+                sampleEvent.dateCreated
+                  ? sampleEvent.dateCreated
+                  : sampleEvent.dateReceived
+              }
+              suffix={t('old')}
+            />
           </TimeWrapper>
         </ExtraInfo>
       </EventDetails>