Browse Source

fix(settings): Correct various rendering issues with hooks

- Use total for stat name
- Truncate hook url on list
David Cramer 7 years ago
parent
commit
25d2ce137e

+ 1 - 1
src/sentry/static/sentry/app/views/settings/project/projectServiceHookDetails.jsx

@@ -64,7 +64,7 @@ class HookStats extends AsyncComponent {
       if (p.total) emptyStats = false;
       return {
         x: p.ts,
-        y: [p.accepted, p.dropped],
+        y: [p.total],
       };
     });
 

+ 5 - 2
src/sentry/static/sentry/app/views/settings/project/projectServiceHooks.jsx

@@ -13,6 +13,7 @@ import IndicatorStore from '../../../stores/indicatorStore';
 import {Panel, PanelAlert, PanelBody, PanelHeader} from '../../../components/panels';
 import SettingsPageHeader from '../components/settingsPageHeader';
 import Switch from '../../../components/switch';
+import Truncate from '../../../components/truncate';
 
 const ServiceHookRow = createReactClass({
   displayName: 'ServiceHookRow',
@@ -38,10 +39,12 @@ const ServiceHookRow = createReactClass({
     return (
       <Field
         label={
-          <Link to={`/settings/${orgId}/${projectId}/hooks/${hook.id}/`}>{hook.url}</Link>
+          <Link to={`/settings/${orgId}/${projectId}/hooks/${hook.id}/`}>
+            <Truncate value={hook.url} />
+          </Link>
         }
         help={
-          hook.events.length !== 0 ? (
+          hook.events && hook.events.length !== 0 ? (
             <small>{hook.events.join(', ')}</small>
           ) : (
             <small>

+ 2 - 2
tests/acceptance/test_project_servicehooks.py

@@ -4,9 +4,9 @@ from sentry.models import ServiceHook
 from sentry.testutils import AcceptanceTestCase
 
 
-class ProjectTagsServiceHooksTest(AcceptanceTestCase):
+class ProjectServiceHooksTest(AcceptanceTestCase):
     def setUp(self):
-        super(ProjectTagsServiceHooksTest, self).setUp()
+        super(ProjectServiceHooksTest, self).setUp()
         self.user = self.create_user('foo@example.com')
         self.org = self.create_organization(
             name='Rowdy Tiger',