chore: Remove old dnd flags (#42164)

Remove unused feature flags

src/sentry/conf/server.py

@@ -984,8 +984,6 @@ SENTRY_FEATURES = {
     "organizations:discover-basic": True,
     # Enable discover 2 custom queries and saved queries
     "organizations:discover-query": True,
-    # Enable metrics baseline in discover
-    "organizations:discover-metrics-baseline": False,
     # Enable quick context in discover
     "organizations:discover-quick-context": False,
     # Allows an org to have a larger set of project ownership rules per project
@@ -1085,14 +1083,8 @@ SENTRY_FEATURES = {
     "organizations:dashboards-basic": True,
     # Enable custom editable dashboards
     "organizations:dashboards-edit": True,
-    # Enable dashboard widget library
-    "organizations:widget-library": False,
     # Enable metrics enhanced performance in dashboards
     "organizations:dashboards-mep": False,
-    # Enable top level query filters in dashboards
-    "organizations:dashboards-top-level-filter": True,
-    # Enables usage of custom measurements in dashboard widgets
-    "organizations:dashboard-custom-measurement-widgets": False,
     # Enable minimap in the widget viewer modal in dashboards
     "organizations:widget-viewer-modal-minimap": False,
     # Enable experimental performance improvements.
@@ -1187,10 +1179,6 @@ SENTRY_FEATURES = {
     "organizations:dynamic-sampling-demo": False,
     # Enable the new opinionated dynamic sampling
     "organizations:dynamic-sampling": False,
-    # Enable the mobile screenshots feature
-    "organizations:mobile-screenshots": False,
-    # Enable the mobile screenshot gallery in the attachments tab
-    "organizations:mobile-screenshot-gallery": False,
     # Enable View Hierarchies in issue details page
     "organizations:mobile-view-hierarchies": False,
     # Enable tag improvements in the issue details page

src/sentry/features/__init__.py

@@ -69,13 +69,10 @@ default_manager.add("organizations:api-keys", OrganizationFeature)
 default_manager.add("organizations:crash-rate-alerts", OrganizationFeature)
 default_manager.add("organizations:custom-event-title", OrganizationFeature)
 default_manager.add("organizations:customer-domains", OrganizationFeature, True)
-default_manager.add("organizations:dashboard-custom-measurement-widgets", OrganizationFeature, True)
 default_manager.add("organizations:dashboards-mep", OrganizationFeature, True)
 default_manager.add("organizations:dashboards-template", OrganizationFeature, True)
-default_manager.add("organizations:dashboards-top-level-filter", OrganizationFeature, True)
 default_manager.add("organizations:discover", OrganizationFeature)
 default_manager.add("organizations:discover-events-rate-limit", OrganizationFeature, True)
-default_manager.add("organizations:discover-metrics-baseline", OrganizationFeature, True)
 default_manager.add("organizations:discover-quick-context", OrganizationFeature, True)
 default_manager.add("organizations:discover-query-builder-as-landing-page", OrganizationFeature, True)
 default_manager.add("organizations:dynamic-sampling-demo", OrganizationFeature, True)
@@ -108,8 +105,6 @@ default_manager.add("organizations:metrics-extraction", OrganizationFeature)
 default_manager.add("organizations:metrics-performance-alerts", OrganizationFeature, True)
 default_manager.add("organizations:metrics-performance-ui", OrganizationFeature, True)
 default_manager.add("organizations:minute-resolution-sessions", OrganizationFeature)
-default_manager.add("organizations:mobile-screenshots", OrganizationFeature, True)
-default_manager.add("organizations:mobile-screenshot-gallery", OrganizationFeature, True)
 default_manager.add("organizations:mobile-view-hierarchies", OrganizationFeature, True)
 default_manager.add("organizations:monitors", OrganizationFeature)
 default_manager.add("organizations:native-stack-trace-v2", OrganizationFeature, True)
@@ -166,7 +161,6 @@ default_manager.add("organizations:transaction-name-clusterer", OrganizationFeat
 default_manager.add("organizations:transaction-metrics-extraction", OrganizationFeature)
 default_manager.add("organizations:unified-span-view", OrganizationFeature, True)
 default_manager.add("organizations:use-metrics-layer", OrganizationFeature, True)
-default_manager.add("organizations:widget-library", OrganizationFeature, True)
 default_manager.add("organizations:widget-viewer-modal-minimap", OrganizationFeature, True)
 default_manager.add("organizations:u2f-superuser-form", OrganizationFeature, True)
 # NOTE: Don't add features down here! Add them to their specific group and sort

tests/acceptance/test_organization_dashboards.py

@@ -33,8 +33,6 @@ FEATURE_NAMES = [
 
 EDIT_FEATURE = ["organizations:dashboards-edit"]
 
-WIDGET_LIBRARY_FEATURE = ["organizations:widget-library"]
-
 
 @region_silo_test
 class OrganizationDashboardsAcceptanceTest(AcceptanceTestCase):
@@ -429,7 +427,7 @@ class OrganizationDashboardsAcceptanceTest(AcceptanceTestCase):
     def test_cancel_without_changes_does_not_trigger_confirm_with_custom_widget_through_header(
         self,
     ):
-        with self.feature(FEATURE_NAMES + EDIT_FEATURE + WIDGET_LIBRARY_FEATURE):
+        with self.feature(FEATURE_NAMES + EDIT_FEATURE):
             self.page.visit_dashboard_detail()
 
             self.page.click_dashboard_header_add_widget_button()
@@ -449,7 +447,7 @@ class OrganizationDashboardsAcceptanceTest(AcceptanceTestCase):
     def test_position_when_adding_multiple_widgets_through_add_widget_tile_in_edit(
         self,
     ):
-        with self.feature(FEATURE_NAMES + EDIT_FEATURE + WIDGET_LIBRARY_FEATURE):
+        with self.feature(FEATURE_NAMES + EDIT_FEATURE):
             self.page.visit_dashboard_detail()
             self.page.enter_edit_state()
 
@@ -468,7 +466,7 @@ class OrganizationDashboardsAcceptanceTest(AcceptanceTestCase):
     def test_position_when_adding_multiple_widgets_through_add_widget_tile_in_create(
         self,
     ):
-        with self.feature(FEATURE_NAMES + EDIT_FEATURE + WIDGET_LIBRARY_FEATURE):
+        with self.feature(FEATURE_NAMES + EDIT_FEATURE):
             self.page.visit_create_dashboard()
 
             # Widgets should take up the whole first row and the first spot in second row
@@ -519,7 +517,7 @@ class OrganizationDashboardsAcceptanceTest(AcceptanceTestCase):
             )
             for widget in existing_widgets
         )
-        with self.feature(FEATURE_NAMES + EDIT_FEATURE + WIDGET_LIBRARY_FEATURE):
+        with self.feature(FEATURE_NAMES + EDIT_FEATURE):
             self.page.visit_dashboard_detail()
 
             dropdown_trigger = self.browser.element('[aria-label="Widget actions"]')
@@ -570,7 +568,7 @@ class OrganizationDashboardsAcceptanceTest(AcceptanceTestCase):
             )
             for widget in existing_widgets
         )
-        with self.feature(FEATURE_NAMES + EDIT_FEATURE + WIDGET_LIBRARY_FEATURE):
+        with self.feature(FEATURE_NAMES + EDIT_FEATURE):
             self.page.visit_dashboard_detail()
 
             # Open edit modal for first widget
@@ -619,7 +617,7 @@ class OrganizationDashboardsAcceptanceTest(AcceptanceTestCase):
         DashboardWidgetQuery.objects.create(
             widget=existing_widget, fields=["count()"], columns=[], aggregates=["count()"], order=0
         )
-        with self.feature(FEATURE_NAMES + EDIT_FEATURE + WIDGET_LIBRARY_FEATURE):
+        with self.feature(FEATURE_NAMES + EDIT_FEATURE):
             self.page.visit_dashboard_detail()
 
             # Open edit modal for first widget
@@ -668,7 +666,7 @@ class OrganizationDashboardsAcceptanceTest(AcceptanceTestCase):
         DashboardWidgetQuery.objects.create(
             widget=existing_widget, fields=["count()"], columns=[], aggregates=["count()"], order=0
         )
-        with self.feature(FEATURE_NAMES + EDIT_FEATURE + WIDGET_LIBRARY_FEATURE):
+        with self.feature(FEATURE_NAMES + EDIT_FEATURE):
             self.page.visit_dashboard_detail()
 
             # Open edit modal for first widget

tests/sentry/api/serializers/test_organization.py

@@ -45,7 +45,6 @@ class OrganizationSerializerTest(TestCase):
             "data-forwarding",
             "dashboards-basic",
             "dashboards-edit",
-            "dashboards-top-level-filter",
             "discover-basic",
             "discover-query",
             "discover-query-builder-as-landing-page",

tests/snuba/api/endpoints/test_discover_homepage_query.py

@@ -4,7 +4,7 @@ from sentry.api.serializers import serialize
 from sentry.discover.models import DiscoverSavedQuery
 from tests.snuba.api.endpoints.test_discover_saved_queries import DiscoverSavedQueryBase
 
-FEATURES = ("organizations:discover-query", "organizations:discover-query-builder-as-landing-page")
+FEATURES = ("organizations:discover-query",)
 
 
 class DiscoverHomepageQueryTest(DiscoverSavedQueryBase):