Browse Source

fix(onboarding): fix typing of analytics (#75891)

fix `trackAnalytics` call to log a boolean value rather than provider
details + remove unused button render analytics
Mia Hsu 7 months ago
parent
commit
1e837befa7

+ 0 - 5
static/app/utils/analytics/onboardingAnalyticsEvents.tsx

@@ -53,9 +53,6 @@ export type OnboardingEventParameters = {
     platform: string;
     project_id: string;
   };
-  'onboarding.setup_messaging_integration_button_rendered': {
-    project_id: string;
-  };
   'onboarding.source_maps_wizard_button_copy_clicked': {
     platform: string;
     project_id: string;
@@ -90,8 +87,6 @@ export const onboardingEventMap: Record<keyof OnboardingEventParameters, string>
   'onboarding.source_maps_wizard_selected_and_copied':
     'Onboarding: Source Maps Wizard Selected and Copied',
   'onboarding.nextjs-dsn-copied': 'Onboarding: NextJS DSN Copied',
-  'onboarding.setup_messaging_integration_button_rendered':
-    'Onboarding: Setup Messaging Integration Button Rendered',
   'onboarding.messaging_integration_modal_rendered':
     'Onboarding: Messaging Integration Modal Rendered',
   'onboarding.messaging_integration_external_install_clicked':

+ 2 - 2
static/app/views/alerts/rules/issue/setupMessagingIntegrationButton.tsx

@@ -52,9 +52,9 @@ function SetupMessagingIntegrationButton({projectSlug, refetchConfigs}: Props) {
   const {IntegrationFeatures} = getIntegrationFeatureGate();
 
   const shouldRenderSetupButton =
-    projectQuery.data &&
+    projectQuery.data != null &&
     !projectQuery.data.hasAlertIntegrationInstalled &&
-    integrationQuery.data;
+    integrationQuery.data != null;
 
   useRouteAnalyticsParams({
     setup_message_integration_button_shown: shouldRenderSetupButton,