ref(bug reports): remove dashes from feedback_id in serializer (#57327)

Closes https://github.com/getsentry/sentry/issues/57321

src/sentry/feedback/serializers.py

@@ -46,7 +46,7 @@ class FeedbackSerializer(Serializer):
             "sdk": obj.data.get("sdk"),
             "contact_email": obj.data.get("feedback").get("contact_email"),
             "environment": env,
-            "feedback_id": obj.feedback_id,
+            "feedback_id": str(obj.feedback_id).replace("-", ""),
             "message": obj.message,
             "platform": obj.data.get("platform"),
             "project_id": obj.project_id,

tests/sentry/feedback/test_organization_feedback_index.py

@@ -117,7 +117,9 @@ class OrganizationFeedbackIndexTest(APITestCase):
             assert feedback["environment"] == "dev"
             assert feedback["url"] == "https://docs.sentry.io/platforms/electron/"
             assert feedback["message"] == "I also really like this user-feedback feature!"
-            assert feedback["feedback_id"] == uuid.UUID("2ffe0775ac0f4417aed9de36d9f6f8ab")
+            assert feedback["feedback_id"] == str(
+                uuid.UUID("2ffe0775ac0f4417aed9de36d9f6f8ab")
+            ).replace("-", "")
             assert feedback["platform"] == "electron"
             assert feedback["sdk"]["name"] == "sentry.javascript.react"
             assert feedback["sdk"]["version"] == "5.18.1"
@@ -127,7 +129,9 @@ class OrganizationFeedbackIndexTest(APITestCase):
             assert feedback["dist"] == "abc123"
             assert feedback["url"] == "https://docs.sentry.io/platforms/javascript/"
             assert feedback["message"] == "I really like this user-feedback feature!"
-            assert feedback["feedback_id"] == uuid.UUID("1ffe0775ac0f4417aed9de36d9f6f8dc")
+            assert feedback["feedback_id"] == str(
+                uuid.UUID("1ffe0775ac0f4417aed9de36d9f6f8dc")
+            ).replace("-", "")
             assert feedback["platform"] == "javascript"
             assert feedback["sdk"]["name"] == "sentry.javascript.react"
             assert feedback["tags"]["key"] == "value"
@@ -170,7 +174,9 @@ class OrganizationFeedbackIndexTest(APITestCase):
             # Should get item that matches the project
             assert len(response.data) == 1
             feedback = response.data[0]
-            assert feedback["feedback_id"] == uuid.UUID("2ffe0775ac0f4417aed9de36d9f6f8ab")
+            assert feedback["feedback_id"] == str(
+                uuid.UUID("2ffe0775ac0f4417aed9de36d9f6f8ab")
+            ).replace("-", "")
 
     def test_stats_period_filter(self):
         with self.feature({"organizations:user-feedback-ingest": True}):
@@ -191,7 +197,9 @@ class OrganizationFeedbackIndexTest(APITestCase):
             # Should get item that matches the time period
             assert len(response.data) == 1
             feedback = response.data[0]
-            assert feedback["feedback_id"] == uuid.UUID("2ffe0775ac0f4417aed9de36d9f6f8ab")
+            assert feedback["feedback_id"] == str(
+                uuid.UUID("2ffe0775ac0f4417aed9de36d9f6f8ab")
+            ).replace("-", "")
 
     def test_env_filter(self):
         with self.feature({"organizations:user-feedback-ingest": True}):
@@ -208,7 +216,9 @@ class OrganizationFeedbackIndexTest(APITestCase):
             # Should get item that matches the environment
             assert len(response.data) == 1
             feedback = response.data[0]
-            assert feedback["feedback_id"] == uuid.UUID("1ffe0775ac0f4417aed9de36d9f6f8dc")
+            assert feedback["feedback_id"] == str(
+                uuid.UUID("1ffe0775ac0f4417aed9de36d9f6f8dc")
+            ).replace("-", "")
             assert feedback["environment"] == self.environment_1.name
 
     def test_invalid_env_filter(self):

tests/sentry/feedback/test_project_feedback_details.py

@@ -113,7 +113,7 @@ class ProjectFeedbackDetailTest(APITestCase):
         assert feedback["dist"] == "abc123"
         assert feedback["url"] == "https://docs.sentry.io/platforms/javascript/"
         assert feedback["message"] == "I really like this user-feedback feature!"
-        assert feedback["feedback_id"] == uuid.UUID(self.feedback_id_1)
+        assert feedback["feedback_id"] == str(uuid.UUID(self.feedback_id_1)).replace("-", "")
         assert feedback["platform"] == "javascript"
         assert feedback["sdk"]["name"] == "sentry.javascript.react"
         assert feedback["tags"]["key"] == "value"
@@ -131,7 +131,7 @@ class ProjectFeedbackDetailTest(APITestCase):
         response = self.client.get(path)
         assert response.status_code == 200
         feedback = response.data
-        assert feedback["feedback_id"] == uuid.UUID(self.feedback_id_2)
+        assert feedback["feedback_id"] == str(uuid.UUID(self.feedback_id_2)).replace("-", "")
         assert feedback["contact_email"] == "michelle.zhang@sentry.io"
 
     @with_feature(FEATURES)