Browse Source

ref(crons): Refactor prop orgId to orgSlug in monitor details (#54389)

David Wang 1 year ago
parent
commit
1dee4d5b92

+ 4 - 4
static/app/views/monitors/components/monitorCheckIns.tsx

@@ -34,7 +34,7 @@ import {statusToText} from 'sentry/views/monitors/utils';
 type Props = {
   monitor: Monitor;
   monitorEnvs: MonitorEnvironment[];
-  orgId: string;
+  orgSlug: string;
 };
 
 const checkStatusToIndicatorStatus: Record<
@@ -48,11 +48,11 @@ const checkStatusToIndicatorStatus: Record<
   [CheckInStatus.TIMEOUT]: 'error',
 };
 
-function MonitorCheckIns({monitor, monitorEnvs, orgId}: Props) {
+function MonitorCheckIns({monitor, monitorEnvs, orgSlug}: Props) {
   const location = useLocation();
   const organization = useOrganization();
   const queryKey = [
-    `/organizations/${orgId}/monitors/${monitor.slug}/checkins/`,
+    `/organizations/${orgSlug}/monitors/${monitor.slug}/checkins/`,
     {
       query: {
         per_page: '10',
@@ -75,7 +75,7 @@ function MonitorCheckIns({monitor, monitorEnvs, orgId}: Props) {
   }
 
   const generateDownloadUrl = (checkin: CheckIn) =>
-    `/api/0/organizations/${orgId}/monitors/${monitor.slug}/checkins/${checkin.id}/attachment/`;
+    `/api/0/organizations/${orgSlug}/monitors/${monitor.slug}/checkins/${checkin.id}/attachment/`;
 
   const emptyCell = <Text>{'\u2014'}</Text>;
 

+ 4 - 4
static/app/views/monitors/components/monitorIssues.tsx

@@ -11,7 +11,7 @@ import {Monitor, MonitorEnvironment} from '../types';
 type Props = {
   monitor: Monitor;
   monitorEnvs: MonitorEnvironment[];
-  orgId: string;
+  orgSlug: string;
 };
 
 function MonitorIssuesEmptyMessage() {
@@ -26,7 +26,7 @@ function MonitorIssuesEmptyMessage() {
   );
 }
 
-function MonitorIssues({orgId, monitor, monitorEnvs}: Props) {
+function MonitorIssues({orgSlug, monitor, monitorEnvs}: Props) {
   const {selection} = usePageFilters();
   const {start, end, period} = selection.datetime;
   const timeProps =
@@ -43,8 +43,8 @@ function MonitorIssues({orgId, monitor, monitorEnvs}: Props) {
 
   return (
     <GroupList
-      orgId={orgId}
-      endpointPath={`/organizations/${orgId}/issues/`}
+      orgId={orgSlug}
+      endpointPath={`/organizations/${orgSlug}/issues/`}
       queryParams={{
         query: `monitor.slug:"${monitor.slug}" environment:[${monitorEnvs
           .map(e => e.name)

+ 3 - 3
static/app/views/monitors/components/monitorStats.tsx

@@ -23,10 +23,10 @@ import {Monitor, MonitorEnvironment, MonitorStat} from '../types';
 type Props = {
   monitor: Monitor;
   monitorEnvs: MonitorEnvironment[];
-  orgId: string;
+  orgSlug: string;
 };
 
-function MonitorStats({monitor, monitorEnvs, orgId}: Props) {
+function MonitorStats({monitor, monitorEnvs, orgSlug}: Props) {
   const {selection} = usePageFilters();
   const {start, end, period} = selection.datetime;
 
@@ -43,7 +43,7 @@ function MonitorStats({monitor, monitorEnvs, orgId}: Props) {
   }
 
   const queryKey = [
-    `/organizations/${orgId}/monitors/${monitor.slug}/stats/`,
+    `/organizations/${orgSlug}/monitors/${monitor.slug}/stats/`,
     {
       query: {
         since: since.toString(),

+ 3 - 3
static/app/views/monitors/details.tsx

@@ -94,19 +94,19 @@ function MonitorDetails({params, location}: Props) {
             ) : (
               <Fragment>
                 <MonitorStats
-                  orgId={organization.slug}
+                  orgSlug={organization.slug}
                   monitor={monitor}
                   monitorEnvs={monitor.environments}
                 />
 
                 <MonitorIssues
-                  orgId={organization.slug}
+                  orgSlug={organization.slug}
                   monitor={monitor}
                   monitorEnvs={monitor.environments}
                 />
 
                 <MonitorCheckIns
-                  orgId={organization.slug}
+                  orgSlug={organization.slug}
                   monitor={monitor}
                   monitorEnvs={monitor.environments}
                 />