Browse Source

ref(docintegration): Use BooleanField, limit charfield max len (#30584)

* ref(docintegration): Use BooleanField, limit charfield max len
Colleen O'Rourke 3 years ago
parent
commit
1d21077d8a

+ 1 - 1
migrations_lockfile.txt

@@ -6,5 +6,5 @@ To resolve this, rebase against latest master and regenerate your migration. Thi
 will then be regenerated, and you should be able to merge without conflicts.
 
 nodestore: 0002_nodestore_no_dictfield
-sentry: 0263_remove_not_null_integrationfeature
+sentry: 0264_use_booleanfield_docintegration
 social_auth: 0001_initial

+ 42 - 0
src/sentry/migrations/0264_use_booleanfield_docintegration.py

@@ -0,0 +1,42 @@
+# Generated by Django 2.2.24 on 2021-12-11 00:40
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+    # This flag is used to mark that a migration shouldn't be automatically run in
+    # production. We set this to True for operations that we think are risky and want
+    # someone from ops to run manually and monitor.
+    # General advice is that if in doubt, mark your migration as `is_dangerous`.
+    # Some things you should always mark as dangerous:
+    # - Large data migrations. Typically we want these to be run manually by ops so that
+    #   they can be monitored. Since data migrations will now hold a transaction open
+    #   this is even more important.
+    # - Adding columns to highly active tables, even ones that are NULL.
+    is_dangerous = False
+
+    # This flag is used to decide whether to run this migration in a transaction or not.
+    # By default we prefer to run in a transaction, but for migrations where you want
+    # to `CREATE INDEX CONCURRENTLY` this needs to be set to False. Typically you'll
+    # want to create an index concurrently when adding one to an existing table.
+    # You'll also usually want to set this to `False` if you're writing a data
+    # migration, since we don't want the entire migration to run in one long-running
+    # transaction.
+    atomic = True
+
+    dependencies = [
+        ("sentry", "0263_remove_not_null_integrationfeature"),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name="docintegration",
+            name="is_draft",
+            field=models.BooleanField(default=True),
+        ),
+        migrations.AlterField(
+            model_name="docintegration",
+            name="name",
+            field=models.CharField(max_length=64),
+        ),
+    ]

+ 2 - 2
src/sentry/models/integration.py

@@ -28,14 +28,14 @@ class DocIntegration(Model):
 
     __include_in_export__ = False
 
-    name = models.CharField(max_length=255)
+    name = models.CharField(max_length=64)
     slug = models.CharField(max_length=64, unique=True)
     author = models.CharField(max_length=255)
     description = models.TextField()
     url = models.URLField()
     popularity = models.PositiveSmallIntegerField(null=True, default=1)
     # Quickly hide/show integration, used for logo uploads
-    is_draft = models.NullBooleanField(default=True)
+    is_draft = models.BooleanField(default=True)
 
     # Allow future extensions by adding more metadata.
     # To start, only { resources: [{title, link}] }