Browse Source

:wrench: chore: Change SLO to Halt temporarily for Slack Team Linking (#82565)

Raj Joshi 2 months ago
parent
commit
1aece4849c

+ 1 - 1
src/sentry/integrations/slack/webhooks/base.py

@@ -200,7 +200,7 @@ class SlackCommandDispatcher(MessagingIntegrationCommandDispatcher[Response]):
         for message, reason in self.TEAM_HALT_MAPPINGS.items():
             if message in str(response.data):
                 return IntegrationResponse(
-                    interaction_result=EventLifecycleOutcome.SUCCESS,
+                    interaction_result=EventLifecycleOutcome.HALTED,
                     response=response,
                     outcome_reason=str(reason),
                 )

+ 4 - 4
tests/sentry/integrations/slack/webhooks/commands/test_link_team.py

@@ -65,7 +65,7 @@ class SlackCommandsLinkTeamTest(SlackCommandsLinkTeamTestBase):
         data = orjson.loads(response.content)
         assert CHANNEL_ALREADY_LINKED_MESSAGE in get_response_text(data)
 
-        assert_slo_metric(mock_record, EventLifecycleOutcome.SUCCESS)
+        assert_slo_metric(mock_record, EventLifecycleOutcome.HALTED)
 
     @with_feature("organizations:slack-multiple-team-single-channel-linking")
     @patch("sentry.integrations.utils.metrics.EventLifecycle.record_event")
@@ -109,7 +109,7 @@ class SlackCommandsLinkTeamTest(SlackCommandsLinkTeamTestBase):
         data = orjson.loads(response.content)
         assert LINK_FROM_CHANNEL_MESSAGE in get_response_text(data)
 
-        assert_slo_metric(mock_record, EventLifecycleOutcome.SUCCESS)
+        assert_slo_metric(mock_record, EventLifecycleOutcome.HALTED)
 
     @responses.activate
     @patch("sentry.integrations.utils.metrics.EventLifecycle.record_event")
@@ -123,7 +123,7 @@ class SlackCommandsLinkTeamTest(SlackCommandsLinkTeamTestBase):
         data = self.send_slack_message("link team", user_id=OTHER_SLACK_ID)
         assert LINK_USER_FIRST_MESSAGE in get_response_text(data)
 
-        assert_slo_metric(mock_record, EventLifecycleOutcome.SUCCESS)
+        assert_slo_metric(mock_record, EventLifecycleOutcome.HALTED)
 
     @responses.activate
     @patch("sentry.integrations.utils.metrics.EventLifecycle.record_event")
@@ -142,7 +142,7 @@ class SlackCommandsLinkTeamTest(SlackCommandsLinkTeamTestBase):
         data = self.send_slack_message("link team", user_id=OTHER_SLACK_ID)
         assert INSUFFICIENT_ROLE_MESSAGE in get_response_text(data)
 
-        assert_slo_metric(mock_record, EventLifecycleOutcome.SUCCESS)
+        assert_slo_metric(mock_record, EventLifecycleOutcome.HALTED)
 
     @responses.activate
     @patch("sentry.integrations.utils.metrics.EventLifecycle.record_event")