test(ui): Return router props from initializeOrg (#49372)

static/app/components/createAlertButton.spec.jsx

@@ -171,9 +171,9 @@ describe('CreateAlertFromViewButton', () => {
     expect(navigateTo).toHaveBeenCalledWith(
       `/organizations/org-slug/alerts/wizard/?`,
       expect.objectContaining({
-        params: {
+        params: expect.objectContaining({
           orgId: 'org-slug',
-        },
+        }),
       })
     );
   });

static/app/components/datePageFilter.spec.tsx

@@ -6,9 +6,6 @@ import OrganizationStore from 'sentry/stores/organizationStore';
 import PageFiltersStore from 'sentry/stores/pageFiltersStore';
 
 const {organization, router, routerContext} = initializeOrg({
-  organization: {},
-  project: undefined,
-  projects: undefined,
   router: {
     location: {
       query: {},

static/app/components/events/eventReplay/replayPreview.spec.tsx

@@ -60,9 +60,6 @@ jest.mock('sentry/utils/replays/hooks/useReplayData', () => {
 
 const render: typeof baseRender = children => {
   const {router, routerContext} = initializeOrg({
-    organization: {},
-    project: TestStubs.Project(),
-    projects: [TestStubs.Project()],
     router: {
       routes: [
         {path: '/'},

static/app/components/organizations/datePageFilter.spec.tsx

@@ -7,9 +7,6 @@ import OrganizationStore from 'sentry/stores/organizationStore';
 import PageFiltersStore from 'sentry/stores/pageFiltersStore';
 
 const {organization, router, routerContext} = initializeOrg({
-  organization: {},
-  project: undefined,
-  projects: undefined,
   router: {
     location: {
       query: {},
@@ -132,9 +129,6 @@ describe('DatePageFilter', function () {
       router: desyncRouter,
       routerContext: desyncRouterContext,
     } = initializeOrg({
-      organization: {},
-      project: undefined,
-      projects: undefined,
       router: {
         location: {
           // the datetime parameters need to be non-null for desync detection to work

static/app/views/alerts/rules/metric/details/index.spec.tsx

@@ -36,7 +36,7 @@ describe('MetricAlertDetails', () => {
   });
 
   it('renders', async () => {
-    const {routerContext, organization, router} = initializeOrg();
+    const {routerContext, organization, routerProps} = initializeOrg();
     const incident = TestStubs.Incident();
     const rule = TestStubs.MetricRule({
       projects: [project.slug],
@@ -55,11 +55,7 @@ describe('MetricAlertDetails', () => {
     render(
       <MetricAlertDetails
         organization={organization}
-        route={{}}
-        router={router}
-        routes={router.routes}
-        routeParams={router.params}
-        location={router.location}
+        {...routerProps}
         params={{ruleId: rule.id}}
       />,
       {context: routerContext, organization}
@@ -81,7 +77,7 @@ describe('MetricAlertDetails', () => {
   });
 
   it('renders selected incident', async () => {
-    const {routerContext, organization, router} = initializeOrg();
+    const {routerContext, organization, router, routerProps} = initializeOrg();
     const rule = TestStubs.MetricRule({projects: [project.slug]});
     const incident = TestStubs.Incident();
 
@@ -106,10 +102,7 @@ describe('MetricAlertDetails', () => {
     render(
       <MetricAlertDetails
         organization={organization}
-        route={{}}
-        router={router}
-        routes={router.routes}
-        routeParams={router.params}
+        {...routerProps}
         location={{...router.location, query: {alert: incident.id}}}
         params={{ruleId: rule.id}}
       />,

static/app/views/alerts/rules/metric/duplicate.spec.tsx

@@ -61,7 +61,7 @@ describe('Incident Rules Duplicate', function () {
     });
     rule.resolveThreshold = 50;
 
-    const {organization, project, router} = initializeOrg({
+    const {organization, project, routerProps} = initializeOrg({
       organization: {
         access: ['alerts:write'],
       },
@@ -69,7 +69,7 @@ describe('Incident Rules Duplicate', function () {
         params: {},
         location: {
           query: {
-            createFromDuplicate: true,
+            createFromDuplicate: 'true',
             duplicateRuleId: `${rule.id}`,
           },
         },
@@ -87,15 +87,10 @@ describe('Incident Rules Duplicate', function () {
       <Fragment>
         <GlobalModal />
         <MetricRulesDuplicate
-          params={{}}
-          route={{}}
-          routeParams={router.params}
-          router={router}
-          routes={router.routes}
-          location={router.location}
           organization={organization}
           project={project}
           userTeamIds={[]}
+          {...routerProps}
         />
       </Fragment>
     );
@@ -126,7 +121,7 @@ describe('Incident Rules Duplicate', function () {
       desc: 'Send a Slack notification to #feed-ecosystem',
     });
 
-    const {organization, project, router} = initializeOrg({
+    const {organization, project, routerProps} = initializeOrg({
       organization: {
         access: ['alerts:write'],
       },
@@ -134,7 +129,7 @@ describe('Incident Rules Duplicate', function () {
         params: {},
         location: {
           query: {
-            createFromDuplicate: true,
+            createFromDuplicate: 'true',
             duplicateRuleId: `${rule.id}`,
           },
         },
@@ -150,15 +145,10 @@ describe('Incident Rules Duplicate', function () {
 
     render(
       <MetricRulesDuplicate
-        params={{}}
-        route={{}}
-        routeParams={router.params}
-        router={router}
-        routes={router.routes}
-        location={router.location}
         organization={organization}
         project={project}
         userTeamIds={[]}
+        {...routerProps}
       />
     );
 

static/app/views/alerts/wizard/index.spec.tsx

@@ -5,7 +5,7 @@ import AlertWizard from 'sentry/views/alerts/wizard/index';
 
 describe('AlertWizard', () => {
   it('sets crash free dataset to metrics', async () => {
-    const {organization, project, router, routerContext} = initializeOrg({
+    const {organization, project, routerProps, routerContext} = initializeOrg({
       organization: {
         features: [
           'alert-crash-free-metrics',
@@ -15,20 +15,12 @@ describe('AlertWizard', () => {
         ],
         access: ['org:write', 'alerts:write'],
       },
-      project: undefined,
-      projects: undefined,
-      router: undefined,
     });
     render(
       <AlertWizard
         organization={organization}
-        route={{}}
-        router={router}
-        routes={router.routes}
-        routeParams={router.params}
-        location={router.location}
-        params={{projectId: project.slug}}
         projectId={project.slug}
+        {...routerProps}
       />,
       {context: routerContext, organization}
     );

static/app/views/discover/results.spec.tsx

@@ -478,7 +478,7 @@ describe('Results', function () {
             query: {
               ...generateFields(),
               statsPeriod: '60d',
-              project: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11],
+              project: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11].map(String),
             },
           },
         },
@@ -547,7 +547,11 @@ describe('Results', function () {
         organization,
         router: {
           location: {
-            query: {...generateFields(), statsPeriod: '90d', project: [1, 2, 3, 4]},
+            query: {
+              ...generateFields(),
+              statsPeriod: '90d',
+              project: [1, 2, 3, 4].map(String),
+            },
           },
         },
       });
@@ -644,7 +648,7 @@ describe('Results', function () {
             query: {
               id: '1',
               statsPeriod: '7d',
-              project: [2],
+              project: ['2'],
               environment: ['production'],
             },
           },
@@ -1043,7 +1047,7 @@ describe('Results', function () {
       const initialData = initializeOrg({
         organization,
         router: {
-          location: {query: {fromMetric: true, id: '1'}},
+          location: {query: {fromMetric: 'true', id: '1'}},
         },
       });
 
@@ -1080,7 +1084,7 @@ describe('Results', function () {
       const initialData = initializeOrg({
         organization,
         router: {
-          location: {query: {showUnparameterizedBanner: true, id: '1'}},
+          location: {query: {showUnparameterizedBanner: 'true', id: '1'}},
         },
       });
 

static/app/views/issueDetails/groupTagValues.spec.jsx

@@ -8,9 +8,6 @@ const tags = TestStubs.Tags();
 
 function init(tagKey) {
   return initializeOrg({
-    organization: {},
-    project: undefined,
-    projects: undefined,
     router: {
       location: {
         query: {},

static/app/views/onboarding/onboarding.spec.tsx

@@ -22,7 +22,7 @@ describe('Onboarding', function () {
       step: 'welcome',
     };
 
-    const {router, route, routerContext, organization} = initializeOrg({
+    const {routerProps, routerContext, organization} = initializeOrg({
       router: {
         params: routeParams,
       },
@@ -30,14 +30,7 @@ describe('Onboarding', function () {
 
     render(
       <OnboardingContextProvider>
-        <Onboarding
-          router={router}
-          location={router.location}
-          params={routeParams}
-          routes={router.routes}
-          routeParams={router.params}
-          route={route}
-        />
+        <Onboarding {...routerProps} />
       </OnboardingContextProvider>,
       {
         context: routerContext,
@@ -54,7 +47,7 @@ describe('Onboarding', function () {
       step: 'select-platform',
     };
 
-    const {router, route, routerContext, organization} = initializeOrg({
+    const {routerProps, routerContext, organization} = initializeOrg({
       router: {
         params: routeParams,
       },
@@ -62,14 +55,7 @@ describe('Onboarding', function () {
 
     render(
       <OnboardingContextProvider>
-        <Onboarding
-          router={router}
-          location={router.location}
-          params={routeParams}
-          routes={router.routes}
-          routeParams={router.params}
-          route={route}
-        />
+        <Onboarding {...routerProps} />
       </OnboardingContextProvider>,
       {
         context: routerContext,
@@ -93,7 +79,7 @@ describe('Onboarding', function () {
       step: 'setup-docs',
     };
 
-    const {router, route, routerContext, organization} = initializeOrg({
+    const {routerProps, routerContext, organization} = initializeOrg({
       router: {
         params: routeParams,
       },
@@ -146,14 +132,7 @@ describe('Onboarding', function () {
           },
         }}
       >
-        <Onboarding
-          router={router}
-          location={router.location}
-          params={routeParams}
-          routes={router.routes}
-          routeParams={router.params}
-          route={route}
-        />
+        <Onboarding {...routerProps} />
       </OnboardingContextProvider>,
       {
         context: routerContext,
@@ -179,7 +158,7 @@ describe('Onboarding', function () {
       step: 'setup-docs',
     };
 
-    const {router, route, routerContext, organization} = initializeOrg({
+    const {routerProps, routerContext, organization} = initializeOrg({
       organization: {
         features: ['onboarding-project-deletion-on-back-click'],
       },
@@ -235,14 +214,7 @@ describe('Onboarding', function () {
           },
         }}
       >
-        <Onboarding
-          router={router}
-          location={router.location}
-          params={routeParams}
-          routes={router.routes}
-          routeParams={router.params}
-          route={route}
-        />
+        <Onboarding {...routerProps} />
       </OnboardingContextProvider>,
       {
         context: routerContext,
@@ -278,7 +250,7 @@ describe('Onboarding', function () {
       step: 'setup-docs',
     };
 
-    const {router, route, routerContext, organization} = initializeOrg({
+    const {routerProps, routerContext, organization} = initializeOrg({
       organization: {
         features: ['onboarding-project-deletion-on-back-click'],
       },
@@ -334,14 +306,7 @@ describe('Onboarding', function () {
           },
         }}
       >
-        <Onboarding
-          router={router}
-          location={router.location}
-          params={routeParams}
-          routes={router.routes}
-          routeParams={router.params}
-          route={route}
-        />
+        <Onboarding {...routerProps} />
       </OnboardingContextProvider>,
       {
         context: routerContext,
@@ -368,7 +333,7 @@ describe('Onboarding', function () {
       step: 'select-platform',
     };
 
-    const {router, route, routerContext, organization} = initializeOrg({
+    const {routerProps, routerContext, organization} = initializeOrg({
       organization: {
         features: ['onboarding-sdk-selection'],
       },
@@ -379,14 +344,7 @@ describe('Onboarding', function () {
 
     render(
       <OnboardingContextProvider>
-        <Onboarding
-          router={router}
-          location={router.location}
-          params={routeParams}
-          routes={router.routes}
-          routeParams={router.params}
-          route={route}
-        />
+        <Onboarding {...routerProps} />
       </OnboardingContextProvider>,
       {
         context: routerContext,
@@ -414,7 +372,7 @@ describe('Onboarding', function () {
       step: 'select-platform',
     };
 
-    const {router, route, routerContext, organization} = initializeOrg({
+    const {routerProps, routerContext, organization} = initializeOrg({
       organization: {
         features: ['onboarding-sdk-selection'],
       },
@@ -425,14 +383,7 @@ describe('Onboarding', function () {
 
     render(
       <OnboardingContextProvider>
-        <Onboarding
-          router={router}
-          location={router.location}
-          params={routeParams}
-          routes={router.routes}
-          routeParams={router.params}
-          route={route}
-        />
+        <Onboarding {...routerProps} />
       </OnboardingContextProvider>,
       {
         context: routerContext,