test(ui): Add types to test mocks (#79255)

static/app/components/modals/widgetViewerModal.spec.tsx

@@ -26,7 +26,7 @@ jest.mock('echarts-for-react/lib/core', () => {
 
 const stubEl = (props: {children?: React.ReactNode}) => <div>{props.children}</div>;
 
-let eventsMetaMock;
+let eventsMetaMock: jest.Mock;
 
 const waitForMetaToHaveBeenCalled = async () => {
   await waitFor(() => {

static/app/components/quickTrace/index.spec.tsx

@@ -3,11 +3,12 @@ import {render, screen} from 'sentry-test/reactTestingLibrary';
 
 import QuickTrace from 'sentry/components/quickTrace';
 import type {Event} from 'sentry/types/event';
+import type {Organization} from 'sentry/types/organization';
 import type {QuickTraceEvent} from 'sentry/utils/performance/quickTrace/types';
 
 describe('Quick Trace', function () {
-  let location;
-  let organization;
+  let location: any;
+  let organization: Organization;
 
   const initialize = () => {
     const context = initializeOrg();

static/app/components/search/sources/apiSource.spec.tsx

@@ -15,13 +15,13 @@ import ConfigStore from 'sentry/stores/configStore';
 
 describe('ApiSource', function () {
   const {organization, router} = initializeOrg();
-  let orgsMock;
-  let projectsMock;
-  let teamsMock;
-  let membersMock;
-  let shortIdMock;
-  let eventIdMock;
-  let configState;
+  let orgsMock: jest.Mock;
+  let projectsMock: jest.Mock;
+  let teamsMock: jest.Mock;
+  let membersMock: jest.Mock;
+  let shortIdMock: jest.Mock;
+  let eventIdMock: jest.Mock;
+  let configState: ReturnType<typeof ConfigStore.getState>;
 
   const defaultProps: ComponentProps<typeof ApiSource> = {
     query: '',

static/app/stores/groupingStore.spec.tsx

@@ -2,7 +2,7 @@ import * as GroupActionCreators from 'sentry/actionCreators/group';
 import GroupingStore from 'sentry/stores/groupingStore';
 
 describe('Grouping Store', function () {
-  let trigger;
+  let trigger!: jest.SpyInstance;
 
   beforeAll(function () {
     MockApiClient.asyncDelay = 1;

static/app/utils/replays/playback/providers/replayPlayerEventsContext.spec.tsx

@@ -44,7 +44,7 @@ describe('replayPlayerEventsContext', () => {
       errors: [],
       replayRecord: ReplayRecordFixture(),
     });
-    const mockRRwebFrames = [];
+    const mockRRwebFrames: any[] = [];
     mockReplay!.getRRWebFrames = jest.fn().mockReturnValue(mockRRwebFrames);
 
     const {result} = renderHook(useReplayPlayerEvents, {

static/app/utils/replays/playback/providers/replayPlayerPluginsContextProvider.spec.tsx

@@ -39,7 +39,7 @@ describe('replayPlayerPluginsContext', () => {
 
   it('should return no plugins if you dont use the Provider', () => {
     const mockOrganization = OrganizationFixture();
-    const mockEvents = [];
+    const mockEvents: any[] = [];
 
     const {result} = renderHook(useReplayPlayerPlugins, {
       wrapper: ({children}: {children?: ReactNode}) => (
@@ -57,7 +57,7 @@ describe('replayPlayerPluginsContext', () => {
     const mockOrganizationWithCanvas = OrganizationFixture({
       features: ['session-replay-enable-canvas-replayer'],
     });
-    const mockEvents = [];
+    const mockEvents: any[] = [];
 
     const {result: noCanvasResult} = renderHook(useReplayPlayerPlugins, {
       wrapper: makeWrapper(mockOrganizationNoCanvas),

static/app/views/dashboards/dashboard.spec.tsx

@@ -59,7 +59,8 @@ describe('Dashboards > Dashboard', () => {
     ],
   };
 
-  let initialData, tagsMock;
+  let initialData: ReturnType<typeof initializeOrg>;
+  let tagsMock: jest.Mock;
 
   beforeEach(() => {
     initialData = initializeOrg({organization, router: {}, projects: []});

static/app/views/dashboards/manage/dashboardList.spec.tsx

@@ -14,10 +14,13 @@ import {
 } from 'sentry-test/reactTestingLibrary';
 
 import DashboardList from 'sentry/views/dashboards/manage/dashboardList';
-import {DisplayType} from 'sentry/views/dashboards/types';
+import {type DashboardListItem, DisplayType} from 'sentry/views/dashboards/types';
 
 describe('Dashboards - DashboardList', function () {
-  let dashboards, deleteMock, dashboardUpdateMock, createMock;
+  let dashboards: DashboardListItem[];
+  let deleteMock: jest.Mock;
+  let dashboardUpdateMock: jest.Mock;
+  let createMock: jest.Mock;
   const organization = OrganizationFixture({
     features: ['global-views', 'dashboards-basic', 'dashboards-edit', 'discover-query'],
   });

static/app/views/dashboards/widgetCard/index.spec.tsx

@@ -78,7 +78,7 @@ describe('Dashboards > WidgetCard', function () {
   };
 
   const api = new MockApiClient();
-  let eventsMock;
+  let eventsMock: jest.Mock;
 
   beforeEach(function () {
     MockApiClient.addMockResponse({

static/app/views/discover/savedQuery/index.spec.tsx

@@ -3,7 +3,7 @@ import {OrganizationFixture} from 'sentry-fixture/organization';
 import {render, screen, userEvent, waitFor} from 'sentry-test/reactTestingLibrary';
 
 import {openAddToDashboardModal} from 'sentry/actionCreators/modal';
-import type {NewQuery} from 'sentry/types/organization';
+import type {NewQuery, Organization, SavedQuery} from 'sentry/types/organization';
 import EventView from 'sentry/utils/discover/eventView';
 import {DisplayModes, SavedQueryDatasets} from 'sentry/utils/discover/types';
 import {WidgetType} from 'sentry/views/dashboards/types';
@@ -41,12 +41,12 @@ function mount(
 }
 
 describe('Discover > SaveQueryButtonGroup', function () {
-  let organization,
-    errorsView,
-    savedQuery,
-    errorsViewSaved,
-    errorsViewModified,
-    errorsQuery;
+  let organization: Organization;
+  let errorsView: EventView;
+  let savedQuery: SavedQuery;
+  let errorsViewSaved: EventView;
+  let errorsViewModified: EventView;
+  let errorsQuery: NewQuery;
   const location = {
     pathname: '/organization/eventsv2/',
     query: {},
@@ -272,7 +272,7 @@ describe('Discover > SaveQueryButtonGroup', function () {
   });
 
   describe('viewing a saved query', () => {
-    let mockUtils;
+    let mockUtils: jest.SpyInstance;
 
     beforeEach(() => {
       mockUtils = jest
@@ -362,7 +362,7 @@ describe('Discover > SaveQueryButtonGroup', function () {
   });
 
   describe('modifying a saved query', () => {
-    let mockUtils;
+    let mockUtils: jest.SpyInstance;
 
     it('renders the correct set of buttons', async () => {
       mount(