Browse Source

ref(crons): Remove crons-ownership feature flag (backend) (#69522)

Evan Purkhiser 10 months ago
parent
commit
11ae138611

+ 0 - 2
src/sentry/conf/server.py

@@ -1500,8 +1500,6 @@ SENTRY_FEATURES: dict[str, bool | None] = {
     "organizations:crons-broken-monitor-detection": False,
     # Disables legacy cron ingest endpoints
     "organizations:crons-disable-ingest-endpoints": False,
-    # Enables ownership features for cron monitors
-    "organizations:crons-ownership": False,
     # Metrics: Enable ingestion and storage of custom metrics. See ddm-ui and ddm-sidebar-item-hidden for UI.
     "organizations:custom-metrics": False,
     # Allow organizations to configure custom external symbol sources.

+ 0 - 1
src/sentry/features/temporary.py

@@ -52,7 +52,6 @@ def register_temporary_features(manager: FeatureManager):
     manager.add("organizations:codecov-commit-sha-from-git-blame", OrganizationFeature, FeatureHandlerStrategy.REMOTE)
     manager.add("organizations:crons-broken-monitor-detection", OrganizationFeature, FeatureHandlerStrategy.INTERNAL)
     manager.add("organizations:crons-disable-ingest-endpoints", OrganizationFeature, FeatureHandlerStrategy.INTERNAL)
-    manager.add("organizations:crons-ownership", OrganizationFeature, FeatureHandlerStrategy.REMOTE)
     manager.add("organizations:daily-summary", OrganizationFeature, FeatureHandlerStrategy.INTERNAL)
     manager.add("organizations:dashboard-widget-indicators", OrganizationFeature, FeatureHandlerStrategy.REMOTE)
     manager.add("organizations:dashboards-import", OrganizationFeature, FeatureHandlerStrategy.REMOTE)

+ 1 - 7
src/sentry/monitors/logic/mark_failed.py

@@ -251,12 +251,6 @@ def create_issue_platform_occurrence(
     if last_successful_checkin:
         last_successful_checkin_timestamp = last_successful_checkin.date_added.isoformat()
 
-    assignee = None
-    # TODO: Remove org fetch after we remove feature flag
-    organization = Organization.objects.get_from_cache(id=monitor_env.monitor.organization_id)
-    if features.has("organizations:crons-ownership", organization):
-        assignee = monitor_env.monitor.owner_actor
-
     occurrence = IssueOccurrence(
         id=uuid.uuid4().hex,
         resource_id=None,
@@ -281,7 +275,7 @@ def create_issue_platform_occurrence(
         culprit=occurrence_data["reason"],
         detection_time=current_timestamp,
         level=occurrence_data["level"],
-        assignee=assignee,
+        assignee=monitor_env.monitor.owner_actor,
     )
 
     if failed_checkin.trace_id:

+ 0 - 1
tests/sentry/monitors/logic/test_mark_failed.py

@@ -903,7 +903,6 @@ class MarkFailedTestCase(TestCase):
         assert monitor_environment.active_incident is not None
 
     @with_feature("organizations:issue-platform")
-    @with_feature("organizations:crons-ownership")
     def test_mark_failed_issue_assignment(self):
         monitor = Monitor.objects.create(
             name="test monitor",