Browse Source

chore(issues): Remove unused GroupManager.from_kwargs (#68052)

This method is not called anywhere in sentry or getsentry except in the
test which is also being removed.
Matt Duncan 11 months ago
parent
commit
0fef0e0c01
2 changed files with 0 additions and 20 deletions
  1. 0 13
      src/sentry/models/group.py
  2. 0 7
      tests/sentry/manager/test_group_manager.py

+ 0 - 13
src/sentry/models/group.py

@@ -354,19 +354,6 @@ class GroupManager(BaseManager["Group"]):
                 raise Group.DoesNotExist()
         return groups
 
-    def from_kwargs(self, project, **kwargs):
-        from sentry.event_manager import EventManager
-        from sentry.exceptions import HashDiscarded
-
-        manager = EventManager(kwargs)
-        manager.normalize()
-        try:
-            return manager.save(project)
-
-        # TODO(jess): this method maybe isn't even used?
-        except HashDiscarded as e:
-            logger.info("discarded.hash", extra={"project_id": project, "description": str(e)})
-
     def from_event_id(self, project, event_id):
         """Resolves the 32 character event_id string into a Group for which it is found."""
         group_id = None

+ 0 - 7
tests/sentry/manager/test_group_manager.py

@@ -7,13 +7,6 @@ pytestmark = requires_snuba
 
 
 class SentryManagerTest(TestCase):
-    def test_valid_only_message(self):
-        proj = self.create_project()
-        event = Group.objects.from_kwargs(proj.id, message="foo")
-        self.assertEqual(event.group.last_seen, event.datetime)
-        self.assertEqual(event.message, "foo")
-        self.assertEqual(event.project_id, proj.id)
-
     def test_get_groups_by_external_issue(self):
         external_issue_key = "api-123"
         group = self.create_group()