Browse Source

Rm unused feedback.spam-detection-actions (#71864)

Couldn't find any references in sentry, getsentry, and
options-automator. I believe this was replaced with
`organizations.user-feedback-spam-filter-actions`
Andrew Liu 9 months ago
parent
commit
0f314b3470
2 changed files with 0 additions and 13 deletions
  1. 0 7
      src/sentry/options/defaults.py
  2. 0 6
      tests/sentry/tasks/test_post_process.py

+ 0 - 7
src/sentry/options/defaults.py

@@ -485,13 +485,6 @@ register(
     flags=FLAG_AUTOMATOR_MODIFIABLE,
 )
 
-# Let spam detection run but don't take action on it.
-register(
-    "feedback.spam-detection-actions",
-    default=False,
-    flags=FLAG_AUTOMATOR_MODIFIABLE,
-)
-
 
 # Extract spans only from a random fraction of transactions.
 #

+ 0 - 6
tests/sentry/tasks/test_post_process.py

@@ -2853,7 +2853,6 @@ class PostProcessGroupFeedbackTest(
             )
         return cache_key
 
-    @override_options({"feedback.spam-detection-actions": True})
     def test_not_ran_if_crash_report_option_disabled(self):
         self.project.update_option("sentry:feedback_user_report_notifications", False)
         event = self.create_event(
@@ -2879,7 +2878,6 @@ class PostProcessGroupFeedbackTest(
             )
         assert mock_process_func.call_count == 0
 
-    @override_options({"feedback.spam-detection-actions": True})
     def test_not_ran_if_spam(self):
         event = self.create_event(
             data={},
@@ -2905,7 +2903,6 @@ class PostProcessGroupFeedbackTest(
             )
         assert mock_process_func.call_count == 0
 
-    @override_options({"feedback.spam-detection-actions": True})
     def test_not_ran_if_crash_report_project_option_enabled(self):
         self.project.update_option("sentry:feedback_user_report_notifications", True)
 
@@ -2932,7 +2929,6 @@ class PostProcessGroupFeedbackTest(
             )
         assert mock_process_func.call_count == 1
 
-    @override_options({"feedback.spam-detection-actions": True})
     def test_not_ran_if_crash_report_setting_option_epoch_0(self):
         self.project.update_option("sentry:option-epoch", 1)
         event = self.create_event(
@@ -2958,7 +2954,6 @@ class PostProcessGroupFeedbackTest(
             )
         assert mock_process_func.call_count == 0
 
-    @override_options({"feedback.spam-detection-actions": True})
     def test_ran_if_default_on_new_projects(self):
         event = self.create_event(
             data={},
@@ -2983,7 +2978,6 @@ class PostProcessGroupFeedbackTest(
             )
         assert mock_process_func.call_count == 1
 
-    @override_options({"feedback.spam-detection-actions": True})
     def test_ran_if_crash_feedback_envelope(self):
         event = self.create_event(
             data={},