ref(integrationfeature): Make target_id and target_type not nullable (#30583)

* ref(integrationfeature): Make target_id and target_type not nullable

migrations_lockfile.txt

@@ -6,5 +6,5 @@ To resolve this, rebase against latest master and regenerate your migration. Thi
 will then be regenerated, and you should be able to merge without conflicts.
 
 nodestore: 0002_nodestore_no_dictfield
-sentry: 0262_drop_sentry_app_from_integrationfeature
+sentry: 0263_remove_not_null_integrationfeature
 social_auth: 0001_initial

src/sentry/migrations/0263_remove_not_null_integrationfeature.py

@@ -0,0 +1,44 @@
+# Generated by Django 2.2.24 on 2021-12-10 23:26
+
+from django.db import migrations
+
+import sentry.db.models.fields.bounded
+
+
+class Migration(migrations.Migration):
+    # This flag is used to mark that a migration shouldn't be automatically run in
+    # production. We set this to True for operations that we think are risky and want
+    # someone from ops to run manually and monitor.
+    # General advice is that if in doubt, mark your migration as `is_dangerous`.
+    # Some things you should always mark as dangerous:
+    # - Large data migrations. Typically we want these to be run manually by ops so that
+    #   they can be monitored. Since data migrations will now hold a transaction open
+    #   this is even more important.
+    # - Adding columns to highly active tables, even ones that are NULL.
+    is_dangerous = False
+
+    # This flag is used to decide whether to run this migration in a transaction or not.
+    # By default we prefer to run in a transaction, but for migrations where you want
+    # to `CREATE INDEX CONCURRENTLY` this needs to be set to False. Typically you'll
+    # want to create an index concurrently when adding one to an existing table.
+    # You'll also usually want to set this to `False` if you're writing a data
+    # migration, since we don't want the entire migration to run in one long-running
+    # transaction.
+    atomic = True
+
+    dependencies = [
+        ("sentry", "0262_drop_sentry_app_from_integrationfeature"),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name="integrationfeature",
+            name="target_id",
+            field=sentry.db.models.fields.bounded.BoundedBigIntegerField(),
+        ),
+        migrations.AlterField(
+            model_name="integrationfeature",
+            name="target_type",
+            field=sentry.db.models.fields.bounded.BoundedPositiveIntegerField(default=0),
+        ),
+    ]

src/sentry/models/integrationfeature.py

@@ -79,11 +79,9 @@ class IntegrationFeature(Model):
     __include_in_export__ = False
 
     # the id of the sentry_app or doc_integration
-    # TODO(CEO): change this to null=False
-    target_id = BoundedBigIntegerField(null=True)
+    target_id = BoundedBigIntegerField()
     target_type = BoundedPositiveIntegerField(
         default=0,
-        null=True,
         choices=(
             (IntegrationTypes.SENTRY_APP, "sentry_app"),
             (IntegrationTypes.DOC_INTEGRATION, "doc_integration"),