Просмотр исходного кода

ref(analytics): convert more quicktrace analytics (#47115)

Stephen Cefali 1 год назад
Родитель
Сommit
0cecec048d

+ 4 - 0
static/app/utils/analytics/issueAnalyticsEvents.tsx

@@ -166,6 +166,9 @@ export type IssueEventParameters = {
   'quick_trace.node.clicked': {
     node_key: string;
   };
+  'quick_trace.trace_id.clicked': {
+    source: string;
+  };
   resolve_issue: {release: string};
   'source_map_debug.docs_link_clicked': SourceMapDebugParam;
   'source_map_debug.expand_clicked': SourceMapDebugParam;
@@ -218,6 +221,7 @@ export const issueEventMap: Record<IssueEventKey, string | null> = {
   'quick_trace.dropdown.clicked_extra': 'Quick Trace: Dropdown clicked',
   'quick_trace.node.clicked': 'Quick Trace: Node clicked',
   'quick_trace.connected_services': 'Quick Trace: Connected Services',
+  'quick_trace.trace_id.clicked': 'Quick Trace: Trace ID clicked',
   'span_view.embedded_child.hide': 'Span View: Hide Embedded Transaction',
   'span_view.embedded_child.show': 'Span View: Show Embedded Transaction',
   'issue_group_details.tab.clicked': 'Issue Group Details: Header Tab Clicked',

+ 4 - 6
static/app/views/issueDetails/quickTrace/traceLink.tsx

@@ -6,7 +6,7 @@ import {generateTraceTarget} from 'sentry/components/quickTrace/utils';
 import {t} from 'sentry/locale';
 import {space} from 'sentry/styles/space';
 import {Event} from 'sentry/types';
-import {trackAnalyticsEvent} from 'sentry/utils/analytics';
+import trackAdvancedAnalyticsEvent from 'sentry/utils/analytics/trackAdvancedAnalyticsEvent';
 import {QuickTraceContext} from 'sentry/utils/performance/quickTrace/quickTraceContext';
 import useOrganization from 'sentry/utils/useOrganization';
 
@@ -18,13 +18,11 @@ export function TraceLink({event}: TraceLinkProps) {
   const organization = useOrganization();
   const quickTrace = useContext(QuickTraceContext);
   const handleTraceLink = useCallback(() => {
-    trackAnalyticsEvent({
-      eventKey: 'quick_trace.trace_id.clicked',
-      eventName: 'Quick Trace: Trace ID clicked',
-      organization_id: parseInt(organization.id, 10),
+    trackAdvancedAnalyticsEvent('quick_trace.trace_id.clicked', {
+      organization,
       source: 'issues',
     });
-  }, [organization.id]);
+  }, [organization]);
 
   if (
     !quickTrace ||

+ 3 - 5
static/app/views/performance/transactionDetails/quickTraceMeta.tsx

@@ -12,7 +12,7 @@ import {generateTraceTarget} from 'sentry/components/quickTrace/utils';
 import {t, tct, tn} from 'sentry/locale';
 import {AvatarProject, OrganizationSummary} from 'sentry/types';
 import {Event} from 'sentry/types/event';
-import {trackAnalyticsEvent} from 'sentry/utils/analytics';
+import trackAdvancedAnalyticsEvent from 'sentry/utils/analytics/trackAdvancedAnalyticsEvent';
 import {getConfigureTracingDocsLink} from 'sentry/utils/docs';
 import {getShortEventId} from 'sentry/utils/events';
 import {
@@ -36,10 +36,8 @@ type Props = Pick<
 };
 
 function handleTraceLink(organization: OrganizationSummary) {
-  trackAnalyticsEvent({
-    eventKey: 'quick_trace.trace_id.clicked',
-    eventName: 'Quick Trace: Trace ID clicked',
-    organization_id: parseInt(organization.id, 10),
+  trackAdvancedAnalyticsEvent('quick_trace.trace_id.clicked', {
+    organization: organization.id,
     source: 'events',
   });
 }