test(js): Remove all usages of routerContext (#72041)

This is replaced with `router`. We already had this and there were
simply two ways of doing things.

static/app/components/breadcrumbs.spec.tsx

@@ -1,11 +1,11 @@
-import {RouterContextFixture} from 'sentry-fixture/routerContextFixture';
+import {RouterFixture} from 'sentry-fixture/routerFixture';
 
 import {render, screen, userEvent} from 'sentry-test/reactTestingLibrary';
 
 import {Breadcrumbs} from 'sentry/components/breadcrumbs';
 
 describe('Breadcrumbs', () => {
-  const routerContext = RouterContextFixture();
+  const router = RouterFixture();
 
   afterEach(() => {
     jest.resetAllMocks();
@@ -29,7 +29,7 @@ describe('Breadcrumbs', () => {
           },
         ]}
       />,
-      {context: routerContext}
+      {router}
     );
   }
 
@@ -46,15 +46,15 @@ describe('Breadcrumbs', () => {
   it('generates correct links', async () => {
     createWrapper();
     await userEvent.click(screen.getByText('Test 1'));
-    expect(routerContext.context.router.push).toHaveBeenCalledWith('/test1');
+    expect(router.push).toHaveBeenCalledWith('/test1');
     await userEvent.click(screen.getByText('Test 2'));
-    expect(routerContext.context.router.push).toHaveBeenCalledWith('/test2');
+    expect(router.push).toHaveBeenCalledWith('/test2');
   });
 
   it('does not make links where no `to` is provided', async () => {
     createWrapper();
     await userEvent.click(screen.getByText('Test 3'));
-    expect(routerContext.context.router.push).not.toHaveBeenCalled();
+    expect(router.push).not.toHaveBeenCalled();
   });
 
   it('renders a crumb dropdown', async () => {
@@ -81,7 +81,7 @@ describe('Breadcrumbs', () => {
           },
         ]}
       />,
-      {context: routerContext}
+      {router}
     );
     await userEvent.hover(screen.getByText('dropdown crumb'));
 

static/app/components/charts/optionSelector.spec.tsx

@@ -53,7 +53,7 @@ describe('Charts > OptionSelector (Multiple)', function () {
       projects: [],
     });
 
-    return render(<TestComponent />, {context: initialData.routerContext});
+    return render(<TestComponent />, {router: initialData.router});
   };
 
   it('renders yAxisOptions with yAxisValue selected', async function () {

static/app/components/createAlertButton.spec.tsx

@@ -1,6 +1,6 @@
 import {OrganizationFixture} from 'sentry-fixture/organization';
 import {ProjectFixture} from 'sentry-fixture/project';
-import {RouterContextFixture} from 'sentry-fixture/routerContextFixture';
+import {RouterFixture} from 'sentry-fixture/routerFixture';
 
 import {render, screen, userEvent} from 'sentry-test/reactTestingLibrary';
 
@@ -251,7 +251,7 @@ describe('CreateAlertFromViewButton', () => {
   });
 
   it('removes a duplicate project filter', async () => {
-    const context = RouterContextFixture();
+    const router = RouterFixture();
 
     const projects = [ProjectFixture()];
     jest.mocked(useProjects).mockReturnValue({
@@ -276,10 +276,10 @@ describe('CreateAlertFromViewButton', () => {
         projects={projects}
         onClick={onClickMock}
       />,
-      {context}
+      {router}
     );
     await userEvent.click(screen.getByRole('button'));
-    expect(context.context.router.push).toHaveBeenCalledWith({
+    expect(router.push).toHaveBeenCalledWith({
       pathname: `/organizations/org-slug/alerts/new/metric/`,
       query: expect.objectContaining({
         query: 'event.type:error ',

static/app/components/eventOrGroupExtraDetails.spec.tsx

@@ -1,12 +1,9 @@
-import {initializeOrg} from 'sentry-test/initializeOrg';
 import {render} from 'sentry-test/reactTestingLibrary';
 
 import EventOrGroupExtraDetails from 'sentry/components/eventOrGroupExtraDetails';
 import type {Group} from 'sentry/types/group';
 
 describe('EventOrGroupExtraDetails', function () {
-  const {routerContext} = initializeOrg();
-
   it('renders last and first seen', function () {
     render(
       <EventOrGroupExtraDetails
@@ -18,8 +15,7 @@ describe('EventOrGroupExtraDetails', function () {
             firstSeen: '2017-07-01T02:06:02Z',
           } as Group
         }
-      />,
-      {context: routerContext}
+      />
     );
   });
 
@@ -33,8 +29,7 @@ describe('EventOrGroupExtraDetails', function () {
             firstSeen: '2017-07-01T02:06:02Z',
           } as Group
         }
-      />,
-      {context: routerContext}
+      />
     );
   });
 
@@ -48,8 +43,7 @@ describe('EventOrGroupExtraDetails', function () {
             lastSeen: '2017-07-25T22:56:12Z',
           } as Group
         }
-      />,
-      {context: routerContext}
+      />
     );
   });
 
@@ -71,8 +65,7 @@ describe('EventOrGroupExtraDetails', function () {
             status: 'resolved',
           } as Group
         }
-      />,
-      {context: routerContext}
+      />
     );
   });
 
@@ -95,8 +88,7 @@ describe('EventOrGroupExtraDetails', function () {
           } as Group
         }
         showAssignee
-      />,
-      {context: routerContext}
+      />
     );
   });
 
@@ -115,8 +107,7 @@ describe('EventOrGroupExtraDetails', function () {
             subscriptionDetails: {reason: 'mentioned'},
           } as Group
         }
-      />,
-      {context: routerContext}
+      />
     );
   });
 });

static/app/components/eventOrGroupHeader.spec.tsx

@@ -36,7 +36,7 @@ const event = EventFixture({
 });
 
 describe('EventOrGroupHeader', function () {
-  const {organization, router, routerContext} = initializeOrg();
+  const {organization, router} = initializeOrg();
 
   describe('Group', function () {
     it('renders with `type = error`', function () {
@@ -181,7 +181,6 @@ describe('EventOrGroupHeader', function () {
           }}
         />,
         {
-          context: routerContext,
           router: {
             ...router,
             location: {
@@ -211,7 +210,6 @@ describe('EventOrGroupHeader', function () {
           }}
         />,
         {
-          context: routerContext,
           router: {
             ...router,
             location: {

static/app/components/events/eventAttachments.spec.tsx

@@ -14,7 +14,7 @@ import {
 import {EventAttachments} from 'sentry/components/events/eventAttachments';
 
 describe('EventAttachments', function () {
-  const {routerContext, organization, project} = initializeOrg({
+  const {router, organization, project} = initializeOrg({
     organization: {
       features: ['event-attachments'],
       orgRole: 'member',
@@ -41,7 +41,7 @@ describe('EventAttachments', function () {
     });
     const strippedCrashEvent = {...event, metadata: {stripped_crash: true}};
     render(<EventAttachments {...props} event={strippedCrashEvent} />, {
-      context: routerContext,
+      router,
       organization,
     });
 
@@ -77,7 +77,7 @@ describe('EventAttachments', function () {
         {...props}
         event={{...event, metadata: {stripped_crash: false}}}
       />,
-      {context: routerContext, organization}
+      {router, organization}
     );
 
     // No loading state to wait for
@@ -87,14 +87,13 @@ describe('EventAttachments', function () {
   });
 
   it('displays message when user lacks permission to preview an attachment', async function () {
-    const {routerContext: newRouterContext, organization: orgWithWrongAttachmentRole} =
-      initializeOrg({
-        organization: {
-          features: ['event-attachments'],
-          orgRole: 'member',
-          attachmentsRole: 'admin',
-        },
-      } as any);
+    const {router: newRouter, organization: orgWithWrongAttachmentRole} = initializeOrg({
+      organization: {
+        features: ['event-attachments'],
+        orgRole: 'member',
+        attachmentsRole: 'admin',
+      },
+    } as any);
     const attachment = EventAttachmentFixture({
       name: 'some_file.txt',
       headers: {
@@ -114,7 +113,7 @@ describe('EventAttachments', function () {
     });
 
     render(<EventAttachments {...props} />, {
-      context: newRouterContext,
+      router: newRouter,
       organization: orgWithWrongAttachmentRole,
     });
 
@@ -145,7 +144,7 @@ describe('EventAttachments', function () {
       body: 'file contents',
     });
 
-    render(<EventAttachments {...props} />, {context: routerContext, organization});
+    render(<EventAttachments {...props} />, {router, organization});
 
     expect(await screen.findByText('Attachments (1)')).toBeInTheDocument();
 
@@ -172,7 +171,7 @@ describe('EventAttachments', function () {
       method: 'DELETE',
     });
 
-    render(<EventAttachments {...props} />, {context: routerContext, organization});
+    render(<EventAttachments {...props} />, {router, organization});
     renderGlobalModal();
 
     expect(await screen.findByText('Attachments (2)')).toBeInTheDocument();

static/app/components/events/eventReplay/replayClipPreview.spec.tsx

@@ -65,7 +65,7 @@ const render = (
   children: React.ReactElement,
   orgParams: Partial<DetailedOrganization> = {}
 ) => {
-  const {routerContext, organization} = initializeOrg({
+  const {router, organization} = initializeOrg({
     organization: {slug: mockOrgSlug, ...orgParams},
     router: {
       routes: [
@@ -81,7 +81,7 @@ const render = (
   });
 
   return baseRender(children, {
-    context: routerContext,
+    router,
     organization,
   });
 };

static/app/components/events/eventReplay/replayPreview.spec.tsx

@@ -63,7 +63,7 @@ mockUseReplayReader.mockImplementation(() => {
 });
 
 const render: typeof baseRender = children => {
-  const {routerContext} = initializeOrg({
+  const {router} = initializeOrg({
     router: {
       routes: [
         {path: '/'},
@@ -78,7 +78,7 @@ const render: typeof baseRender = children => {
   });
 
   return baseRender(children, {
-    context: routerContext,
+    router,
     organization: OrganizationFixture({slug: mockOrgSlug}),
   });
 };

static/app/components/events/eventTagsAndScreenshot/screenshot/modal.spec.tsx

@@ -14,7 +14,7 @@ import type {EventAttachment, Project} from 'sentry/types';
 const stubEl = (props: {children?: React.ReactNode}) => <div>{props.children}</div>;
 
 function renderModal({
-  initialData: {organization, routerContext},
+  initialData: {organization, router},
   eventAttachment,
   projectSlug,
   attachmentIndex,
@@ -53,7 +53,7 @@ function renderModal({
       enablePagination={enablePagination}
     />,
     {
-      context: routerContext,
+      router,
       organization,
     }
   );
@@ -172,7 +172,7 @@ describe('Modals -> ScreenshotModal', function () {
         enablePagination
       />,
       {
-        context: initialData.routerContext,
+        router: initialData.router,
         organization: initialData.organization,
       }
     );
@@ -209,7 +209,7 @@ describe('Modals -> ScreenshotModal', function () {
         enablePagination
       />,
       {
-        context: initialData.routerContext,
+        router: initialData.router,
         organization: initialData.organization,
       }
     );

static/app/components/events/interfaces/crashContent/exception/content.spec.tsx

@@ -46,11 +46,7 @@ describe('Exception Content', function () {
       body: projectDetails,
     });
 
-    const {
-      organization: org,
-      router,
-      routerContext,
-    } = initializeOrg({
+    const {organization: org, router} = initializeOrg({
       router: {
         location: {query: {project: project.id}},
       },
@@ -145,7 +141,7 @@ describe('Exception Content', function () {
         meta={event._meta!.entries[0].data.values}
         projectSlug={project.slug}
       />,
-      {organization: org, router, context: routerContext}
+      {organization: org, router}
     );
 
     expect(screen.getAllByText(/redacted/)).toHaveLength(2);