Просмотр исходного кода

ref: Move statsPeriodToDays() into utils/duration/ (#71962)

Related to https://github.com/getsentry/frontend-tsc/issues/13
Ryan Albrecht 9 месяцев назад
Родитель
Сommit
0c9a82d5ab

+ 0 - 18
static/app/utils/dates.tsx

@@ -1,7 +1,6 @@
 import moment from 'moment';
 
 import ConfigStore from 'sentry/stores/configStore';
-import type {DateString} from 'sentry/types/core';
 
 import type {TableDataRow} from './discover/discoverQuery';
 
@@ -184,23 +183,6 @@ export function getStartOfPeriodAgo(
   return getStartOfDay(getPeriodAgo(period, unit));
 }
 
-export function statsPeriodToDays(
-  statsPeriod?: string | null,
-  start?: DateString,
-  end?: DateString
-) {
-  if (statsPeriod?.endsWith('d')) {
-    return parseInt(statsPeriod.slice(0, -1), 10);
-  }
-  if (statsPeriod?.endsWith('h')) {
-    return parseInt(statsPeriod.slice(0, -1), 10) / 24;
-  }
-  if (start && end) {
-    return (new Date(end).getTime() - new Date(start).getTime()) / (24 * 60 * 60 * 1000);
-  }
-  return 0;
-}
-
 /**
  * Does the user prefer a 24 hour clock?
  */

+ 1 - 1
static/app/utils/discover/eventView.tsx

@@ -41,6 +41,7 @@ import {
   type SavedQueryDatasets,
   TOP_N,
 } from 'sentry/utils/discover/types';
+import {statsPeriodToDays} from 'sentry/utils/duration/statsPeriodToDays';
 import {decodeList, decodeScalar, decodeSorts} from 'sentry/utils/queryString';
 import {normalizeUrl} from 'sentry/utils/withDomainRequired';
 import type {TableColumn, TableColumnSort} from 'sentry/views/discover/table/types';
@@ -49,7 +50,6 @@ import {decodeColumnOrder} from 'sentry/views/discover/utils';
 import type {SpanOperationBreakdownFilter} from 'sentry/views/performance/transactionSummary/filter';
 import type {EventsDisplayFilterName} from 'sentry/views/performance/transactionSummary/transactionEvents/utils';
 
-import {statsPeriodToDays} from '../dates';
 import type {WebVital} from '../fields';
 import {MutableSearch} from '../tokenizeSearch';
 

+ 18 - 0
static/app/utils/duration/statsPeriodToDays.tsx

@@ -0,0 +1,18 @@
+import type {DateString} from 'sentry/types/core';
+
+export function statsPeriodToDays(
+  statsPeriod?: string | null,
+  start?: DateString,
+  end?: DateString
+) {
+  if (statsPeriod?.endsWith('d')) {
+    return parseInt(statsPeriod.slice(0, -1), 10);
+  }
+  if (statsPeriod?.endsWith('h')) {
+    return parseInt(statsPeriod.slice(0, -1), 10) / 24;
+  }
+  if (start && end) {
+    return (new Date(end).getTime() - new Date(start).getTime()) / (24 * 60 * 60 * 1000);
+  }
+  return 0;
+}

+ 1 - 1
static/app/utils/metrics/index.tsx

@@ -30,8 +30,8 @@ import type {
   MRI,
   UseCase,
 } from 'sentry/types/metrics';
-import {statsPeriodToDays} from 'sentry/utils/dates';
 import {isMeasurement} from 'sentry/utils/discover/fields';
+import {statsPeriodToDays} from 'sentry/utils/duration/statsPeriodToDays';
 import {getMeasurements} from 'sentry/utils/measurements/measurements';
 import {DEFAULT_AGGREGATES} from 'sentry/utils/metrics/constants';
 import {formatMRI, formatMRIField, MRIToField, parseMRI} from 'sentry/utils/metrics/mri';

+ 1 - 1
static/app/views/dashboards/datasetConfig/releases.tsx

@@ -16,10 +16,10 @@ import type {
 import {SessionField} from 'sentry/types';
 import type {Series} from 'sentry/types/echarts';
 import {defined} from 'sentry/utils';
-import {statsPeriodToDays} from 'sentry/utils/dates';
 import type {TableData} from 'sentry/utils/discover/discoverQuery';
 import {getFieldRenderer} from 'sentry/utils/discover/fieldRenderers';
 import type {QueryFieldValue} from 'sentry/utils/discover/fields';
+import {statsPeriodToDays} from 'sentry/utils/duration/statsPeriodToDays';
 import type {OnDemandControlContext} from 'sentry/utils/performance/contexts/onDemandControl';
 import type {FieldValueOption} from 'sentry/views/discover/table/queryField';
 import type {FieldValue} from 'sentry/views/discover/table/types';

+ 1 - 1
static/app/views/metrics/createAlertModal.tsx

@@ -18,8 +18,8 @@ import {Tooltip} from 'sentry/components/tooltip';
 import {t} from 'sentry/locale';
 import {space} from 'sentry/styles/space';
 import type {PageFilters, Project} from 'sentry/types';
-import {statsPeriodToDays} from 'sentry/utils/dates';
 import {parsePeriodToHours} from 'sentry/utils/duration/parsePeriodToHours';
+import {statsPeriodToDays} from 'sentry/utils/duration/statsPeriodToDays';
 import {
   getFieldFromMetricsQuery as getAlertAggregate,
   getMetricsInterval,

+ 1 - 1
static/app/views/organizationStats/usageChart/index.tsx

@@ -22,8 +22,8 @@ import {IconWarning} from 'sentry/icons';
 import {t} from 'sentry/locale';
 import {space} from 'sentry/styles/space';
 import type {DataCategoryInfo, IntervalPeriod, SelectValue} from 'sentry/types/core';
-import {statsPeriodToDays} from 'sentry/utils/dates';
 import {parsePeriodToHours} from 'sentry/utils/duration/parsePeriodToHours';
+import {statsPeriodToDays} from 'sentry/utils/duration/statsPeriodToDays';
 import {hasCustomMetrics} from 'sentry/utils/metrics/features';
 import commonTheme from 'sentry/utils/theme';
 import useOrganization from 'sentry/utils/useOrganization';

+ 1 - 1
static/app/views/performance/utils/index.tsx

@@ -14,10 +14,10 @@ import type {
 import {trackAnalytics} from 'sentry/utils/analytics';
 import toArray from 'sentry/utils/array/toArray';
 import {browserHistory} from 'sentry/utils/browserHistory';
-import {statsPeriodToDays} from 'sentry/utils/dates';
 import type {EventData} from 'sentry/utils/discover/eventView';
 import EventView from 'sentry/utils/discover/eventView';
 import {TRACING_FIELDS} from 'sentry/utils/discover/fields';
+import {statsPeriodToDays} from 'sentry/utils/duration/statsPeriodToDays';
 import getCurrentSentryReactRootSpan from 'sentry/utils/getCurrentSentryReactRootSpan';
 import {useQuery} from 'sentry/utils/queryClient';
 import {decodeScalar} from 'sentry/utils/queryString';