Просмотр исходного кода

chore(outcomes) Remove QueryDefinition.build() (#46053)

This method was meant to be transitional. Now that all callers are using
__init__() with primitives we don't need to keep this method around
anymore.

Requires https://github.com/getsentry/getsentry/pull/9890 to be merged
first.
Mark Story 2 лет назад
Родитель
Сommit
0af454990f
2 измененных файлов с 1 добавлено и 42 удалено
  1. 1 1
      src/sentry/api/endpoints/project_key_stats.py
  2. 0 41
      src/sentry/snuba/outcomes.py

+ 1 - 1
src/sentry/api/endpoints/project_key_stats.py

@@ -43,7 +43,7 @@ class ProjectKeyStatsEndpoint(ProjectEndpoint, StatsMixin):
             raise ParseError(detail="Invalid request data")
 
         try:
-            outcomes_query = QueryDefinition.build(
+            outcomes_query = QueryDefinition(
                 fields=["sum(quantity)"],
                 start=stats_params["start"].isoformat(),
                 end=stats_params["end"].isoformat(),

+ 0 - 41
src/sentry/snuba/outcomes.py

@@ -224,47 +224,6 @@ class QueryDefinition:
     `fields` and `groupby` definitions as [`ColumnDefinition`] objects.
     """
 
-    @classmethod
-    def build(
-        cls,
-        *,
-        fields: List[str],
-        start: Optional[str] = None,
-        end: Optional[str] = None,
-        stats_period: Optional[str] = None,
-        organization_id: Optional[int] = None,
-        project_ids: Optional[List[int]] = None,
-        key_id: Optional[int] = None,
-        interval: Optional[str] = None,
-        outcome: Optional[List[str]] = None,
-        group_by: Optional[List[str]] = None,
-        category: Optional[List[str]] = None,
-        reason: Optional[str] = None,
-        allow_minute_resolution: bool = True,
-    ) -> QueryDefinition:
-        """
-        Factory method for building a `QueryDefintion` from python primitives.
-
-        Ideally this would be the constructor, but we have cross repository dependencies
-        that need to be addressed first.
-        """
-        # TODO(mark) remove this once callers are using __init__()
-        return cls(
-            fields=fields,
-            start=start,
-            end=end,
-            stats_period=stats_period,
-            group_by=group_by,
-            outcome=outcome,
-            interval=interval,
-            reason=reason,
-            category=category,
-            key_id=key_id,
-            project_ids=project_ids,
-            organization_id=organization_id,
-            allow_minute_resolution=allow_minute_resolution,
-        )
-
     @classmethod
     def from_query_dict(
         cls,